Tom Stellard via llvm-dev
2021-Nov-02 20:58 UTC
[llvm-dev] Preparing BOLT for LLVM monorepo
On 11/2/21 1:52 PM, Maksim Panchenko wrote:> Hi All, > > Since the acceptance of the "BOLT framework for binary analysis, > > transformation, and optimization" RFC > > (https://lists.llvm.org/pipermail/llvm-dev/2020-October/145902.html), > > we've been working on addressing the feedback and getting ready for > > inclusion into the monorepo. We've cleaned up interfaces with core LLVM > > libraries, refactored our codebase to match LLVM coding standards, and > > added more open-source tests. Additionally, we've made BOLT faster and > > more compact. > > As of this writing, BOLT could be built as a separate project in the > > LLVM monorepo without any patches other than build configuration > > changes. You can view the latest sources at the monorepo fork > > https://github.com/facebookincubator/BOLT, under "/bolt". > > During the past year, we were happy to see an ever-growing inflow of > > pull requests from external contributors. We believe that accelerating > > the monorepo integration will streamline the open-source review process > > and make it more transparent. >Since you mentioned pull requests, I just wanted to make sure you are aware that we don't use pull requests in the monorepo, so you community would need to transition to doing reviews in Phabricator. Do you think this will be an issue? -Tom> While we are finishing the final steps before the integration > > (https://github.com/facebookincubator/BOLT/issues/248), we would like to > > hear from the community and address any remaining concerns. If > > everything goes smoothly, we anticipate the merge to happen early next > > month and in time for LLVM 14 release. > > We are still working on finalizing the exact logistics of the merge. > > However, we expect to follow the Flang project's footsteps and run the > > "--no-ff" merge to preserve the history of ~1K commits. We would like to > > ask for help and coordination from the release managers Tom Stellard and > > Hans Wennborg. > > We haven't made the final decision on including BOLT in > > LLVM_ALL_PROJECTS, but we are ready to make BOLT the default project in > > the initial merge commit. Currently, we do not support building on > > Windows; thus, the project will be automatically disabled with the > > warning when building on unsupported platforms. As we anticipate the > > increased load on buildbots, we would like to know how we can help with > > adding more build machines. Please let us know! > > Thank you, > > Maksim and BOLT Team >
Renato Golin via llvm-dev
2021-Nov-02 21:30 UTC
[llvm-dev] Preparing BOLT for LLVM monorepo
On Tue, 2 Nov 2021 at 20:59, Tom Stellard via llvm-dev < llvm-dev at lists.llvm.org> wrote:> Since you mentioned pull requests, I just wanted to make sure you are aware > that we don't use pull requests in the monorepo, so you community would > need > to transition to doing reviews in Phabricator. Do you think this will be > an > issue? >If it is, then please report in this issue in Github: https://github.com/llvm/llvm-iwg/issues/73 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20211102/80f73b18/attachment.html>