Tom Stellard via llvm-dev
2021-Nov-01 17:51 UTC
[llvm-dev] Consolidating copies of google/benchmark in the repo (Was: Proposal: introduce dependency on abseil when building benchmarks)
On 11/1/21 10:39 AM, Reid Kleckner via llvm-dev wrote:> On Sun, Oct 31, 2021 at 11:57 AM Chris Lattner via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote: > > I think it would make sense to move third party dependencies out of llvm-project/llvm for other reasons too, including layering (they can’t depend on other things in llvm) and license clarity. > > > +1, gtest & gmock come to mind.I'm in favor of this, but gtest currently has a dependency on LLVMSupport. -Tom> > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >
via llvm-dev
2021-Nov-01 19:15 UTC
[llvm-dev] Consolidating copies of google/benchmark in the repo (Was: Proposal: introduce dependency on abseil when building benchmarks)
> On 11/1/21 10:39 AM, Reid Kleckner via llvm-dev wrote: > > On Sun, Oct 31, 2021 at 11:57 AM Chris Lattner via llvm-dev <llvm- > dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote: > > > > I think it would make sense to move third party dependencies out of > llvm-project/llvm for other reasons too, including layering (they can’t > depend on other things in llvm) and license clarity. > > > > > > +1, gtest & gmock come to mind. > > I'm in favor of this, but gtest currently has a dependency on LLVMSupport.According to the README we have local patches to support a few targets that upstream gtest doesn't, and also allow some LLVM types (StringRef etc) to be used in the printing features. --paulr