I like the idea, and would be happy to help in an advisory capacity - answering folks questions about whether a given FIXME is easy/hard (as far as I know) and where to go to maybe fix it. But doubt I have the motivation to be driving/working on fixes myself, unfortunately. On Thu, Oct 28, 2021 at 3:05 AM Vassil Vassilev via llvm-dev < llvm-dev at lists.llvm.org> wrote:> Hi folks, > > I was thinking to submit a round table focusing on resolving FIXMEs > in the codebase of clang and llvm. The idea is FIXME hunters to bring a > laptop and start hunting down the 13K FIXMEs in both codebases. > > Ideally we would invite code owners to provide key insights and to > possibly review patches quickly. > > I am wondering if that sounds fun and are there people willing to > engage? > > Best, Vassil > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20211028/cac2487b/attachment.html>
Anastasia Stulova via llvm-dev
2021-Oct-29 13:22 UTC
[llvm-dev] [cfe-dev] FIXME Hunt Round Table
This topic is very relevant indeed. I made a quick check in the clang sources and this is the FIXME count for different releases: Release #FIXME Increase 14 6101 12 13 6089 57 12 6032 242 11 5790 134 10 5656 320 9 5336 286 8 5050 53 7 4997 200 6 4797 157 5 4640 214 4 4426 In summary, the number of FIXMEs keeps growing... While I think we should definitely address this I feel it might not be easy within 1h slot. This could be an excellent task for a Hacker Lab for example. I am not sure though whether it is planned for this year? Other formats we can consider are: * Brainstorming our FIXME policy and what can be done to avoid/reduce the growth. Should we start tagging FIXMEs by a domain or severity level and etc to help find the most relevant ones? * Build some tooling e.g. finding the oldest FIXMEs or checking which domains have more FIXMEs. I would particularly be interested in a way to classify them... It's been a while I am trying to find a way to filter OpenCL-specific FIXMEs. I think finding relevant FIXME could be a good first step forward. Overall I would be happy to join this session in whichever format as soon as it is in reasonable enough timing for me (AM hours would work best!). Cheers, Anastasia ________________________________ From: cfe-dev <cfe-dev-bounces at lists.llvm.org> on behalf of David Blaikie via cfe-dev <cfe-dev at lists.llvm.org> Sent: 28 October 2021 20:55 To: Vassil Vassilev <v.g.vassilev at gmail.com> Cc: llvm-dev <llvm-dev at lists.llvm.org>; Clang Dev <cfe-dev at lists.llvm.org> Subject: Re: [cfe-dev] [llvm-dev] FIXME Hunt Round Table I like the idea, and would be happy to help in an advisory capacity - answering folks questions about whether a given FIXME is easy/hard (as far as I know) and where to go to maybe fix it. But doubt I have the motivation to be driving/working on fixes myself, unfortunately. On Thu, Oct 28, 2021 at 3:05 AM Vassil Vassilev via llvm-dev <llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>> wrote: Hi folks, I was thinking to submit a round table focusing on resolving FIXMEs in the codebase of clang and llvm. The idea is FIXME hunters to bring a laptop and start hunting down the 13K FIXMEs in both codebases. Ideally we would invite code owners to provide key insights and to possibly review patches quickly. I am wondering if that sounds fun and are there people willing to engage? Best, Vassil _______________________________________________ LLVM Developers mailing list llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20211029/67aa52db/attachment.html>