llvm dev - Aug 2021 - Phabricator Creator Pulling the Plug

On Mon, 23 Aug 2021 at 18:56, James Y Knight <jyknight at google.com>
wrote:
> If phabricator/phorge do turn out to be non-viable in the future, I think
> we may want to reopen the option of moving to Gerrit for the primary
> code-review platform.
>
> I'll note that the Golang folks are using Gerrit as their review
platform,
> and they have a GitHub bot setup to translate GH pull-requests into a
> gerrit review, so as to be friendly to first-time or drive-by contributors.
> See e.g. https://github.com/golang/go/pull/47766 for an example.
>
Honestly, this is a thing we can do regardless of which tool we use.

There are other tools that integrate with Github more closely that Anton
was looking at, but I think none of them had the functionality we needed
(which both Phab and Gerrit do).

The main problem with that (Go) solution is that the Gerrit install doesn't
single-sign-on with Github accounts, it asked me for my Google account. We
shouldn't ask people to create more accounts if we want integration with
Github. I guess this is just a configuration issue, right?

A minor issue is that the messages Gerrit sends to Github are a bit
pointless "Message from PersonA: (1 comment)". It would be better if
the
integration either works (like adding comments to a specific line or
updating the commits) or not pollute.

Same goes for bug tracker...

cheers,
--renato
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20210824/85da9baa/attachment.html>

On Tue, Aug 24, 2021 at 7:33 AM Renato Golin via cfe-commits
<cfe-commits at lists.llvm.org> wrote:
>
> On Mon, 23 Aug 2021 at 18:56, James Y Knight <jyknight at google.com>
wrote:
>>
>> If phabricator/phorge do turn out to be non-viable in the future, I
think we may want to reopen the option of moving to Gerrit for the primary
code-review platform.
>>
>> I'll note that the Golang folks are using Gerrit as their review
platform, and they have a GitHub bot setup to translate GH pull-requests into a
gerrit review, so as to be friendly to first-time or drive-by contributors. See
e.g. https://github.com/golang/go/pull/47766 for an example.
>
>
> Honestly, this is a thing we can do regardless of which tool we use.
>
> There are other tools that integrate with Github more closely that Anton
was looking at, but I think none of them had the functionality we needed (which
both Phab and Gerrit do).
>
> The main problem with that (Go) solution is that the Gerrit install
doesn't single-sign-on with Github accounts, it asked me for my Google
account. We shouldn't ask people to create more accounts if we want
integration with Github. I guess this is just a configuration issue, right?
>
> A minor issue is that the messages Gerrit sends to Github are a bit
pointless "Message from PersonA: (1 comment)". It would be better if
the integration either works (like adding comments to a specific line or
updating the commits) or not pollute.
Also, the Gerrit review process uses a different workflow than the
Phabricator review process, and we should make sure we're comfortable
with that. My uses of Gerrit (which have been purely corporate in
nature, so my experience may be with an older version of the tool)
have run into some pretty big usability concerns -- like the fact that
it only shows you the diff contents of one file at a time, lacks the
ability to "stack" related patches, comments are easier to lose track
of when updating a review, there's no way to mark comments as
"done"
or not, etc.

~Aaron
>
> Same goes for bug tracker...
>
> cheers,
> --renato
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

On Tue, Aug 24, 2021 at 7:33 AM Renato Golin <rengolin at gmail.com>
wrote:
> The main problem with that (Go) solution is that the Gerrit install
> doesn't single-sign-on with Github accounts, it asked me for my Google
> account. We shouldn't ask people to create more accounts if we want
> integration with Github. I guess this is just a configuration issue, right?
>
Yes, the Gerrit hosting which Go uses ("googlesource.com") only
permits a
google-account login as a matter of policy. But that's not a restriction of
Gerrit itself -- it can perfectly well be configured to use a github login.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20210824/002ce1d8/attachment.html>