llvm dev - Aug 2021 - Phabricator Creator Pulling the Plug

If phabricator/phorge do turn out to be non-viable in the future, I think
we may want to reopen the option of moving to Gerrit for the primary
code-review platform.

I'll note that the Golang folks are using Gerrit as their review platform,
and they have a GitHub bot setup to translate GH pull-requests into a
gerrit review, so as to be friendly to first-time or drive-by contributors.
See e.g. https://github.com/golang/go/pull/47766 for an example.

On Mon, Aug 23, 2021 at 1:38 PM Renato Golin via llvm-dev <
llvm-dev at lists.llvm.org> wrote:
> On Wed, 18 Aug 2021 at 18:17, MyDeveloper Day via llvm-dev <
> llvm-dev at lists.llvm.org> wrote:
>
>> But unless I missed this, was there any discussion regarding the recent
>> "Winding Down" announcement of Phabricator? and what it might
mean for us
>> in LLVM
>>
>
> I think we have our own self-hosted version and enough local people that
> has hacked on it to "maintain" it, but we'd stop getting the
updated from
> upstream, which have been substantial over the years.
>
> I don't think this should be a rush to replace with an alternative, as
> there is no imminent peril, but it is an additional important point for the
> ongoing discussion of potential transition.
>
> Personally I'm excited by the concept of a community driven replacement
(
>> https://we.phorge.it/) .
>> epriestley did a truly amazing job, it wasn't open to public
>> contributions. Perhaps more open development could lead to closing some
of
>> the github gaps that were of concern.
>>
>
> IMO, it would have to be seriously active upstream, understand our
> existing database "as is" and import without problems, and
interface with
> Github more closely to be worth the hassle of migration.
>
> Github pull requests don't seem to be improving a lot, so
"phorge" may be
> the right answer sooner than they catch up...
>
> cheers,
> --renato
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20210823/252549a3/attachment.html>

On Mon, 23 Aug 2021 at 18:56, James Y Knight <jyknight at google.com>
wrote:
> If phabricator/phorge do turn out to be non-viable in the future, I think
> we may want to reopen the option of moving to Gerrit for the primary
> code-review platform.
>
> I'll note that the Golang folks are using Gerrit as their review
platform,
> and they have a GitHub bot setup to translate GH pull-requests into a
> gerrit review, so as to be friendly to first-time or drive-by contributors.
> See e.g. https://github.com/golang/go/pull/47766 for an example.
>
Honestly, this is a thing we can do regardless of which tool we use.

There are other tools that integrate with Github more closely that Anton
was looking at, but I think none of them had the functionality we needed
(which both Phab and Gerrit do).

The main problem with that (Go) solution is that the Gerrit install doesn't
single-sign-on with Github accounts, it asked me for my Google account. We
shouldn't ask people to create more accounts if we want integration with
Github. I guess this is just a configuration issue, right?

A minor issue is that the messages Gerrit sends to Github are a bit
pointless "Message from PersonA: (1 comment)". It would be better if
the
integration either works (like adding comments to a specific line or
updating the commits) or not pollute.

Same goes for bug tracker...

cheers,
--renato
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20210824/85da9baa/attachment.html>