llvm dev - Apr 2021 - Reviewer, with WebAssembly knowledge, requested for D78778

Hi,

I have put together a patch https://reviews.llvm.org/D78778 for the AsmPrinter.

It aims at being able to emit the CFI unwind information for debugging
purposes as needed when exceptions are not enabled/supported.
Currently no CFI unwind information will be emitted if
`MCAsmInfo::getExceptionHandlingType() == ExceptionHandling::None`,
even if `--force-dwarf-frame-section` is used.

Due to this patch, llvm/test/MC/WebAssembly/{debug-info.ll,
debug-info64.ll} needed updates to accommodate the .debug_frame
section that is being generated now.

While the outcome of the patch is in the right direction, I am
wondering if someone could review if the updates to WebAssembly LIT
tests are expected?

Thanks,
Ram

You'll probably have to go check the commit history on the WebAssembly
patches and email someone directly (add them to the 'to' line of this
thread and/or add them to the review).

On Tue, Apr 27, 2021 at 1:37 PM Venkata Ramanaiah Nalamothu via
llvm-dev <llvm-dev at lists.llvm.org> wrote:
>
> Hi,
>
> I have put together a patch https://reviews.llvm.org/D78778 for the
AsmPrinter.
>
> It aims at being able to emit the CFI unwind information for debugging
> purposes as needed when exceptions are not enabled/supported.
> Currently no CFI unwind information will be emitted if
> `MCAsmInfo::getExceptionHandlingType() == ExceptionHandling::None`,
> even if `--force-dwarf-frame-section` is used.
>
> Due to this patch, llvm/test/MC/WebAssembly/{debug-info.ll,
> debug-info64.ll} needed updates to accommodate the .debug_frame
> section that is being generated now.
>
> While the outcome of the patch is in the right direction, I am
> wondering if someone could review if the updates to WebAssembly LIT
> tests are expected?
>
> Thanks,
> Ram
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

On 2021-04-28, Venkata Ramanaiah Nalamothu via llvm-dev
wrote:
>Hi,
>
>I have put together a patch https://reviews.llvm.org/D78778 for the
AsmPrinter.
>
>It aims at being able to emit the CFI unwind information for debugging
>purposes as needed when exceptions are not enabled/supported.
>Currently no CFI unwind information will be emitted if
>`MCAsmInfo::getExceptionHandlingType() == ExceptionHandling::None`,
>even if `--force-dwarf-frame-section` is used.
>
>Due to this patch, llvm/test/MC/WebAssembly/{debug-info.ll,
>debug-info64.ll} needed updates to accommodate the .debug_frame
>section that is being generated now.
>
>While the outcome of the patch is in the right direction, I am
>wondering if someone could review if the updates to WebAssembly LIT
>tests are expected?
>
>Thanks,
>Ram
I CCed a wasm developer sbc100 on D78778.