Paul C. Anagnostopoulos via llvm-dev
2020-Sep-22 19:54 UTC
[llvm-dev] Now I really have broken the build
Can you explain how to revert for someone who is a 2 on a git scale of 0 to 10? At 9/22/2020 03:51 PM, Arthur Eubanks wrote:>Yes, push whatever is needed to fix the build if the fix is fairly simple (else revert and get an LGTM with the fix). > >Next time I'd recommend creating and pushing a revert first if you can't quickly figure out the issue.---------------------------------------------------------------- Windfall Paul C. Anagnostopoulos ---------------------------------------------------------- Software 978 369-0839 www.windfall.com ---------------------------------------------------------------- My life has been filled with calamities, some of which actually happened. ---Mark Twain Guga 'mzimba, sala 'nhliziyo
Arthur Eubanks via llvm-dev
2020-Sep-22 20:14 UTC
[llvm-dev] Now I really have broken the build
$ git revert $COMMIT creates a revert of the commit https://git-scm.com/docs/git-revert for more info On Tue, Sep 22, 2020 at 12:57 PM Paul C. Anagnostopoulos <paul at windfall.com> wrote:> Can you explain how to revert for someone who is a 2 on a git scale of 0 > to 10? > > At 9/22/2020 03:51 PM, Arthur Eubanks wrote: > >Yes, push whatever is needed to fix the build if the fix is fairly simple > (else revert and get an LGTM with the fix). > > > >Next time I'd recommend creating and pushing a revert first if you can't > quickly figure out the issue. > > > > ---------------------------------------------------------------- > Windfall Paul C. Anagnostopoulos > ---------------------------------------------------------- > Software 978 369-0839 <(978)%20369-0839> > www.windfall.com > ---------------------------------------------------------------- > My life has been filled with calamities, > some of which actually happened. > ---Mark Twain > > Guga 'mzimba, sala 'nhliziyo > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200922/7a3f6f61/attachment.html>
Paul C. Anagnostopoulos via llvm-dev
2020-Sep-22 20:24 UTC
[llvm-dev] Now I really have broken the build
>From that page:"Given one or more existing commits, revert the changes that the related patches introduce, and record some new commits that record them." After my copyediting instincts calmed down, I found another description and I understand what it does. Thanks! At 9/22/2020 04:14 PM, Arthur Eubanks wrote:>$ git revert $COMMIT >creates a revert of the commit ><https://git-scm.com/docs/git-revert>https://git-scm.com/docs/git-revert for more info > >On Tue, Sep 22, 2020 at 12:57 PM Paul C. Anagnostopoulos <<mailto:paul at windfall.com>paul at windfall.com> wrote: >Can you explain how to revert for someone who is a 2 on a git scale of 0 to 10? > >At 9/22/2020 03:51 PM, Arthur Eubanks wrote: >>Yes, push whatever is needed to fix the build if the fix is fairly simple (else revert and get an LGTM with the fix). >> >>Next time I'd recommend creating and pushing a revert first if you can't quickly figure out the issue.