llvm dev - Aug 2020 - My first real submission with Phabricator

Madhur Amilkanthwar via llvm-dev <llvm-dev at lists.llvm.org>於 2020年8月9日
週日，上午1:53寫道：
> Hi Paul,
> I hope you have gone through
> https://llvm.org/docs/Contributing.html#how-to-submit-a-patch.
>
> Generally, I would do 'git add' on the new file. 'git diff'
should show me
> the newly added file. Further, I'd just do 'arc diff' and this
should
> eventually generate a phabricator revision for you. There is UI way to
> create patches but I personally prefer 'arc' tool for reviews.
>
> I hope this helps.
>
Yeah, we usually use ‘arc diff’ to create a patch. If you have problem in
installing that tool, you might need to generate the diff with ‘-U9999’ to
include the context for your change which is good for reviewing.
‘git diff HEAD -U9999’

Hope it helps.

Best Regards,
Xing

>
> On Sat, Aug 8, 2020 at 11:07 PM Paul C. Anagnostopoulos via llvm-dev <
> llvm-dev at lists.llvm.org> wrote:
>
>> I am ready to submit my first real submission for review with
>> Phabricator. Please forgive my meager knowledge of Git. I did a
'git diff'
>> to generate the diff file. The contents look good. However, there is
one
>> new file, a TableGen test file. How do I get that file included in the
>> diff, or otherwise included in the submission?
>>
>> _______________________________________________
>> LLVM Developers mailing list
>> llvm-dev at lists.llvm.org
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>>
>
>
> --
> *Disclaimer: Views, concerns, thoughts, questions, ideas expressed in this
> mail are of my own and my employer has no take in it. *
> Thank You.
> Madhur D. Amilkanthwar
>
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
-- 
Cheers,
Xing
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20200809/17e8fb76/attachment.html>

This LLVM dev meeting talk might be useful -
https://www.youtube.com/watch?v=C5Y977rLqpw

On Sat, Aug 8, 2020 at 11:34 PM Xing GUO <higuoxing at gmail.com> wrote:
>
>
> Madhur Amilkanthwar via llvm-dev <llvm-dev at lists.llvm.org>於
2020年8月9日
> 週日，上午1:53寫道：
>
>> Hi Paul,
>> I hope you have gone through
>> https://llvm.org/docs/Contributing.html#how-to-submit-a-patch.
>>
>> Generally, I would do 'git add' on the new file. 'git
diff' should show
>> me the newly added file. Further, I'd just do 'arc diff'
and this should
>> eventually generate a phabricator revision for you. There is UI way to
>> create patches but I personally prefer 'arc' tool for reviews.
>>
>> I hope this helps.
>>
>
> Yeah, we usually use ‘arc diff’ to create a patch. If you have problem in
> installing that tool, you might need to generate the diff with ‘-U9999’ to
> include the context for your change which is good for reviewing.
> ‘git diff HEAD -U9999’
>
> Hope it helps.
>
> Best Regards,
> Xing
>
>
>>
>> On Sat, Aug 8, 2020 at 11:07 PM Paul C. Anagnostopoulos via llvm-dev
<
>> llvm-dev at lists.llvm.org> wrote:
>>
>>> I am ready to submit my first real submission for review with
>>> Phabricator. Please forgive my meager knowledge of Git. I did a
'git diff'
>>> to generate the diff file. The contents look good. However, there
is one
>>> new file, a TableGen test file. How do I get that file included in
the
>>> diff, or otherwise included in the submission?
>>>
>>> _______________________________________________
>>> LLVM Developers mailing list
>>> llvm-dev at lists.llvm.org
>>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>>>
>>
>>
>> --
>> *Disclaimer: Views, concerns, thoughts, questions, ideas expressed in
>> this mail are of my own and my employer has no take in it. *
>> Thank You.
>> Madhur D. Amilkanthwar
>>
>> _______________________________________________
>> LLVM Developers mailing list
>> llvm-dev at lists.llvm.org
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>>
> --
> Cheers,
> Xing
>
>
>
>
-- 
*Disclaimer: Views, concerns, thoughts, questions, ideas expressed in this
mail are of my own and my employer has no take in it. *
Thank You.
Madhur D. Amilkanthwar
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20200808/d00b0cf7/attachment.html>

I will definitely watch the video. Thanks for the link!

At 8/8/2020 02:09 PM, Madhur Amilkanthwar wrote:
>This LLVM dev meeting talk might be useful -
<https://www.youtube.com/watch?v=C5Y977rLqpw>https://www.youtube.com/watch?v=C5Y977rLqpw