On Tue, Jul 28, 2020 at 3:29 PM James Y Knight <jyknight at google.com> wrote:> > Please assume good faith -- I'm pretty sure this is simply a configuration mistake, since Mehdi just upgraded Phabricator to a new upstream revision last night. > Probably the default behavior changed in the new upstream version, and it just needs to be turned off.Yep, that's why i'm asking for the right configuration to be put in place :)> On Tue, Jul 28, 2020 at 8:09 AM Roman Lebedev via llvm-dev <llvm-dev at lists.llvm.org> wrote: >> >> Since the update, new revisions aren't posted immediately, >> but first appear as drafts. There's also this message: >> "This draft revision will be sent for review once this build passes: >> Build 82647: pre-merge checks." (https://reviews.llvm.org/D84742) >> >> As many have seen, pre-merge checks are flaky and just generally unusable, >> and this case was no exception, the build failed and the phabricator >> hsa rejected the revision: "Harbormaster returned this revision to the author >> for changes because remote builds failed." >> There is still no mention of that review in llvm-commits. >> >> Please unbreak phabricator at once :) >> I don't recall seeing any discussion/proposal for any such behaviour. >> >> Roman >> _______________________________________________ >> LLVM Developers mailing list >> llvm-dev at lists.llvm.org >> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
See the "Draft Mode" changes, might be related https://secure.phabricator.com/w/changelog/2020.16/ MyDeveloperDay On Tue, Jul 28, 2020 at 1:32 PM Roman Lebedev via llvm-dev < llvm-dev at lists.llvm.org> wrote:> On Tue, Jul 28, 2020 at 3:29 PM James Y Knight <jyknight at google.com> > wrote: > > > > Please assume good faith -- I'm pretty sure this is simply a > configuration mistake, since Mehdi just upgraded Phabricator to a new > upstream revision last night. > > Probably the default behavior changed in the new upstream version, and > it just needs to be turned off. > Yep, that's why i'm asking for the right configuration to be put in place > :) > > > On Tue, Jul 28, 2020 at 8:09 AM Roman Lebedev via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > >> > >> Since the update, new revisions aren't posted immediately, > >> but first appear as drafts. There's also this message: > >> "This draft revision will be sent for review once this build passes: > >> Build 82647: pre-merge checks." (https://reviews.llvm.org/D84742) > >> > >> As many have seen, pre-merge checks are flaky and just generally > unusable, > >> and this case was no exception, the build failed and the phabricator > >> hsa rejected the revision: "Harbormaster returned this revision to the > author > >> for changes because remote builds failed." > >> There is still no mention of that review in llvm-commits. > >> > >> Please unbreak phabricator at once :) > >> I don't recall seeing any discussion/proposal for any such behaviour. > >> > >> Roman > >> _______________________________________________ > >> LLVM Developers mailing list > >> llvm-dev at lists.llvm.org > >> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200728/2bb69fc0/attachment.html>
This is configured in the "pre-merge checks" build plan, the "Hold Drafts" needs to be set to "Never" I should be able to change this in the build plan if you want but I don't want to step on anyone's toes MyDeveloperDay On Tue, Jul 28, 2020 at 1:35 PM MyDeveloper Day <mydeveloperday at gmail.com> wrote:> See the "Draft Mode" changes, might be related > https://secure.phabricator.com/w/changelog/2020.16/ > > MyDeveloperDay > > On Tue, Jul 28, 2020 at 1:32 PM Roman Lebedev via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > >> On Tue, Jul 28, 2020 at 3:29 PM James Y Knight <jyknight at google.com> >> wrote: >> > >> > Please assume good faith -- I'm pretty sure this is simply a >> configuration mistake, since Mehdi just upgraded Phabricator to a new >> upstream revision last night. >> > Probably the default behavior changed in the new upstream version, and >> it just needs to be turned off. >> Yep, that's why i'm asking for the right configuration to be put in place >> :) >> >> > On Tue, Jul 28, 2020 at 8:09 AM Roman Lebedev via llvm-dev < >> llvm-dev at lists.llvm.org> wrote: >> >> >> >> Since the update, new revisions aren't posted immediately, >> >> but first appear as drafts. There's also this message: >> >> "This draft revision will be sent for review once this build passes: >> >> Build 82647: pre-merge checks." (https://reviews.llvm.org/D84742) >> >> >> >> As many have seen, pre-merge checks are flaky and just generally >> unusable, >> >> and this case was no exception, the build failed and the phabricator >> >> hsa rejected the revision: "Harbormaster returned this revision to the >> author >> >> for changes because remote builds failed." >> >> There is still no mention of that review in llvm-commits. >> >> >> >> Please unbreak phabricator at once :) >> >> I don't recall seeing any discussion/proposal for any such behaviour. >> >> >> >> Roman >> >> _______________________________________________ >> >> LLVM Developers mailing list >> >> llvm-dev at lists.llvm.org >> >> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >> _______________________________________________ >> LLVM Developers mailing list >> llvm-dev at lists.llvm.org >> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >> >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200728/ff028001/attachment.html>
Bruno Ricci via llvm-dev
2020-Jul-28 12:46 UTC
[llvm-dev] Thanks for updating Phab (was: "Re: Please unbreak phabricator")
Modulo this little config whopsie, thank you for updating Phab! Bruno Ricci (and other people on IRC) On 28/07/2020 13:35, MyDeveloper Day via llvm-dev wrote:> See the "Draft Mode" changes, might be related https://secure.phabricator.com/w/changelog/2020.16/ > > MyDeveloperDay