llvm dev - Apr 2019 - compiler-rt builtins on MSVC 2019

Hi,

compiler-rt builtins currently doesn't build on MSVC 2019,
I the problem is that compiler-rt\lib\builtins\int_math.h includes the header
ymath.h.
according to eg.
https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/finite-finitef?view=vs-2019
the header to include is float.h
also the ymath.h file contains the comment /* ymath.h internal header */ so
probably shall not be used.

I do not know how compiler-rt works only tried to compile rustc that is using
compiler-rt
How shall I go forward with this problem?

BR/Andreas Jonson

-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20190404/a7ffce47/attachment-0001.html>

Since that file already includes float.h, I wonder whether the ymath.h
is needed at all. I tried removing it on my MSVC 2017 machine and the
build didn't complain. Could you try the same with 2019?

On Thu, Apr 4, 2019 at 10:12 AM Andreas Jonson via llvm-dev
<llvm-dev at lists.llvm.org> wrote:
>
> Hi,
>
>
>
> compiler-rt builtins currently doesn't build on MSVC 2019,
>
> I the problem is that compiler-rt\lib\builtins\int_math.h includes the
header ymath.h.
>
> according to eg.
https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/finite-finitef?view=vs-2019
the header to include is float.h
>
> also the ymath.h file contains the comment /* ymath.h internal header */ so
probably shall not be used.
>
>
>
> I do not know how compiler-rt works only tried to compile rustc that is
using compiler-rt
>
> How shall I go forward with this problem?
>
>
>
> BR/Andreas Jonson
>
>
>
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

removed the ymath.h and it works with 2019 also,
see now that the doc say float.h or math.h is needed
so remove the ymath.h shall be enough

BR//Andreas

Från: David Major<mailto:dmajor at mozilla.com>
Skickat: den 4 april 2019 16:46
Till: Andreas Jonson<mailto:andjo403 at hotmail.com>
Kopia: llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>
Ämne: Re: [llvm-dev] compiler-rt builtins on MSVC 2019

Since that file already includes float.h, I wonder whether the ymath.h
is needed at all. I tried removing it on my MSVC 2017 machine and the
build didn't complain. Could you try the same with 2019?

On Thu, Apr 4, 2019 at 10:12 AM Andreas Jonson via llvm-dev
<llvm-dev at lists.llvm.org> wrote:
>
> Hi,
>
>
>
> compiler-rt builtins currently doesn't build on MSVC 2019,
>
> I the problem is that compiler-rt\lib\builtins\int_math.h includes the
header ymath.h.
>
> according to eg.
https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/finite-finitef?view=vs-2019
the header to include is float.h
>
> also the ymath.h file contains the comment /* ymath.h internal header */ so
probably shall not be used.
>
>
>
> I do not know how compiler-rt works only tried to compile rustc that is
using compiler-rt
>
> How shall I go forward with this problem?
>
>
>
> BR/Andreas Jonson
>
>
>
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20190404/38bbd239/attachment.html>