llvm dev - Nov 2018 - apt.llvm.org has the wrong binaries/headers for llvm-toolchain-xenial-7

It appears that there was an out-of-band patch from Samuel Thibault:

https://salsa.debian.org/pkg-llvm-team/llvm-toolchain/blob/7/debian/patches/D54378-hurd-triple.diff

Although the patch was approved here https://reviews.llvm.org/D54378

Is this patch going to land in 7.0.1 or 8?

kristopher
> Here's further proof:
>
> wget
>
http://apt.llvm.org/xenial/pool/main/l/llvm-toolchain-7/llvm-7-dev_7.0.1~svn347285-1~exp1~20181124105320.40_amd64.deb
>
> ar vx llvm-7-dev_7.0.1~svn347285-1~exp1~20181124105320.40_amd64.deb
>
> tar xvf data.tar.xz
>
> grep Hurd usr/include/llvm-7/llvm/ADT/Triple.h
>
>     Hurd,       // GNU/Hurd
>     LastOSType = Hurd
>   /// Tests whether the OS is Hurd.
>   bool isOSHurd() const {
>     return getOS() == Triple::Hurd;
>             getOS() == Triple::Hurd) &&
>
> grep Hurd ~/downloads/llvm_release_70/include/llvm/ADT/Triple.h
> (nothing)
>
>>> From: Andrew Kelley <superjoe30 at gmail.com>
>>> Date: Mon, Nov 26, 2018 at 10:38 AM
>>> Subject: apt.llvm.org has the wrong binaries/headers for
llvm-toolchain-xenial-7
>>> To: LLVM Dev <llvm-dev at lists.llvm.org>
>>>
>>>
>>> This build worked on Nov 24 and stopped working Nov 25.
>>>
>>> 2018-11-25T16:48:47.6020966Z + sudo sh -c echo "deb
>>> http://apt.llvm.org/xenial/ llvm-toolchain-xenial-7 main"
>>
>>> /etc/apt/sources.list
>>> ...
>>> 2018-11-25T16:53:30.7836235Z
>>> /home/vsts/work/1/s/src/zig_llvm.cpp:686:1: error: static assertion
>>> failed
>>> 2018-11-25T16:53:30.7837134Z
>>> static_assert((Triple::OSType)ZigLLVM_LastOSType =>>>
Triple::LastOSType, "");
>>> 2018-11-25T16:53:30.7837409Z ^~~~~~~~~~~~~
>>> full logs
https://dev.azure.com/ziglang/zig/_build/results?buildId=229&view=logs
>>>
>>> The version on apt.llvm.org has
>>>     HermitCore, // HermitCore Unikernel/Multikernel
>>>     LastOSType = HermitCore
>>>
>>> But llvm 7.0.0 and 7.0.1 have
>>>     AMDPAL,     // AMD PAL Runtime
>>>     LastOSType = AMDPAL
>>>
>>> Downstream issue https://github.com/ziglang/zig/issues/1788
>>>
>>> Is anyone working on this?
>>>
>>> Regards,
>>> Andrew

On 11/28/2018 5:28 PM, Kristopher Tate via llvm-dev
wrote:
> Although the patch was approved here https://reviews.llvm.org/D54378
>
> Is this patch going to land in 7.0.1 or 8?
For trunk (and therefore 8), looks like it was approved, and it's just 
waiting for someone with commit rights to merge it.

Probably won't be merged to 7.0.1, since it's a new feature.

-Eli

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux
Foundation Collaborative Project

On 11/28/18 8:46 PM, Friedman, Eli via llvm-dev wrote:
> On 11/28/2018 5:28 PM, Kristopher Tate via llvm-dev wrote:
>> Although the patch was approved here https://reviews.llvm.org/D54378
>>
>> Is this patch going to land in 7.0.1 or 8?
>
> For trunk (and therefore 8), looks like it was approved, and it's just
> waiting for someone with commit rights to merge it.
>
> Probably won't be merged to 7.0.1, since it's a new feature.
It was merged as a debian-specific patch to apt.llvm.org in
https://salsa.debian.org/pkg-llvm-team/llvm-toolchain/merge_requests/22

I worked around the issue downstream, by not depending on a consistent
value for Triple::LastOSType. So I would consider the issue resolved,
although I would mention that I consider it unwise to make API breaking
changes to bugfix versions.

That said, we're all open-source developers here, and software is
provided without any warranty, yadda yadda, so, at the end of the day,
thanks everyone, and warm regards.

Sincerely,

Andrew


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20181128/33030bc3/attachment.sig>