vivek pandya via llvm-dev
2018-Mar-14 04:03 UTC
[llvm-dev] [Support][RFC] MessagePack reader/writer
> > Hello all, > > I have prepared a small patch to add support for reading and writing > MessagePack in LLVM, and want to propose including it in trunk. > MessagePack is > a binary object serialization format, with the goal of being more > compact than > text formats like JSON or YAML. The specification can be found at > https://github.com/msgpack/msgpack/blob/master/spec.md > > There is no use of the code currently (outside of unit tests), but at > AMD we > are defining our next code object metadata format in terms of > MessagePack, so > patches which use the new format will be coming soon. I wanted to > propose the > addition now before writing dependant code, so anyone with interest can > have > a chance to review it. > > Hi Scott,I have a work in progress patch to tty out message pack format to emit Optimization remarks. I am using https://github.com/msgpack/msgpack-c it is header only library available under boost license. But however if this is sufficient for my experiment I would love to use this. - Vivek> The API in this patch is low-level; the next step would be to define a > high-level API, closer to the YAML library, to read and write whole > structs. > > The patch is at https://reviews.llvm.org/D44429 > > Regards, > Scott > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20180314/3af44c69/attachment.html>
Hi Vivek, I'm glad to hear there is some interest in the library. From a quick look at msgpack-c it appears this should be sufficient, but if you get a chance to look at my API please let me know if there is anything you need which is missing. As I mentioned, there is no equivalent to msgpack-c's MSGPACK_DEFINE for user-defined structs, but I plan to implement something similar. Regards, Scott On 2018-03-13 21:03, vivek pandya via llvm-dev wrote:>> Hello all, >> >> I have prepared a small patch to add support for reading and writing >> MessagePack in LLVM, and want to propose including it in trunk. >> MessagePack is >> a binary object serialization format, with the goal of being more >> compact than >> text formats like JSON or YAML. The specification can be found at >> https://github.com/msgpack/msgpack/blob/master/spec.md [1] >> >> There is no use of the code currently (outside of unit tests), but >> at >> AMD we >> are defining our next code object metadata format in terms of >> MessagePack, so >> patches which use the new format will be coming soon. I wanted to >> propose the >> addition now before writing dependant code, so anyone with interest >> can >> have >> a chance to review it. > > Hi Scott, > > I have a work in progress patch to tty out message pack format to emit > Optimization > remarks. I am using https://github.com/msgpack/msgpack-c [3] > it is header only library available under boost license. But however > if this is sufficient for my experiment I would love to use this. > - Vivek > >> The API in this patch is low-level; the next step would be to define >> a >> high-level API, closer to the YAML library, to read and write whole >> structs. >> >> The patch is at https://reviews.llvm.org/D44429 [2] >> >> Regards, >> Scott > > > Links: > ------ > [1] https://github.com/msgpack/msgpack/blob/master/spec.md > [2] https://reviews.llvm.org/D44429 > [3] https://github.com/msgpack/msgpack-c > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev