llvm dev - Feb 2018 - [Openmp-dev] [cfe-dev] [Release-testers] [6.0.0 Release] Release Candidate 2 tagged

On 9 Feb 2018, at 22:30, Dimitry Andric <dimitry at andric.com>
wrote:
> 
> On 9 Feb 2018, at 22:11, Dimitry Andric via Openmp-dev <openmp-dev at
lists.llvm.org> wrote:
>> 
>> On 9 Feb 2018, at 20:40, Dimitry Andric via cfe-dev <cfe-dev at
lists.llvm.org> wrote:
>>> 
>>>> On 9 Feb 2018, at 10:20, Hans Wennborg <hans at
chromium.org> wrote:
>> ...
>>>> What are all these test failures? Does it seems like they have
a
>>>> common root cause and do we have a bug for it?
>> ...
>>> The Clang Tools and Extra Tools Unit tests all appear to crash
with:
>>> 
>>>  exception_ptr not yet implemented
>> 
>> This turns out to be caused by libc++ being compiled without
-DLIBCXXRT.  (In the FreeBSD base system build, we always add this option, so
libc++ knows how to handle exceptions.)
>> 
>> In the libc++ CMakeFiles, it appears to be governed by
LIBCXX_CXX_ABI_LIBNAME, but it isn't being set to the correct value of
"cxxrt" on FreeBSD.  I am going to try the following diff:
>> 
>> --- llvm.src/projects/libcxx/CMakeLists.txt
>> +++ llvm.src/projects/libcxx/CMakeLists.txt
>> @@ -135,6 +135,8 @@
>>  elseif (APPLE)
>>    set(LIBCXX_CXX_ABI_LIBNAME "libcxxabi")
>>    set(LIBCXX_CXX_ABI_SYSTEM 1)
>> +  elseif (CMAKE_SYSTEM_NAME MATCHES "FreeBSD")
>> +    set(LIBCXX_CXX_ABI_LIBNAME "libcxxrt")
>>  else()
>>    set(LIBCXX_CXX_ABI_LIBNAME "default")
>>  endif()
> 
> ... and unfortunately that didn't work, since the CMakeFiles are unable
to find the libcxxrt headers:
> 
> CMake Warning at projects/libcxx/cmake/Modules/HandleLibCXXABI.cmake:67
(message):
>  Failed to find cxxabi.h
> Call Stack (most recent call first):
>  projects/libcxx/cmake/Modules/HandleLibCXXABI.cmake:112 (setup_abi_lib)
>  projects/libcxx/CMakeLists.txt:428 (include)
Ok, this turned out to be easier than I thought.  After applying
https://reviews.llvm.org/D43166, the number of failed tests drops roughly by
half (from 896 to 512):

  Expected Passes    : 45381
  Expected Failures  : 185
  Unsupported Tests  : 2937
  Unexpected Passes  : 1
  Unexpected Failures: 521

I am going to have a look at some other low hanging fruit, and I have also
created a few PRs to merge test changes into 6.0.

-Dimitry

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 223 bytes
Desc: Message signed with OpenPGP
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20180211/caaeca8f/attachment.sig>

On Sun, Feb 11, 2018 at 3:31 PM, Dimitry Andric <dimitry at andric.com>
wrote:
> On 9 Feb 2018, at 22:30, Dimitry Andric <dimitry at andric.com>
wrote:
>>
>> On 9 Feb 2018, at 22:11, Dimitry Andric via Openmp-dev <openmp-dev
at lists.llvm.org> wrote:
>>>
>>> On 9 Feb 2018, at 20:40, Dimitry Andric via cfe-dev <cfe-dev at
lists.llvm.org> wrote:
>>>>
>>>>> On 9 Feb 2018, at 10:20, Hans Wennborg <hans at
chromium.org> wrote:
>>> ...
>>>>> What are all these test failures? Does it seems like they
have a
>>>>> common root cause and do we have a bug for it?
>>> ...
>>>> The Clang Tools and Extra Tools Unit tests all appear to crash
with:
>>>>
>>>>  exception_ptr not yet implemented
>>>
>>> This turns out to be caused by libc++ being compiled without
-DLIBCXXRT.  (In the FreeBSD base system build, we always add this option, so
libc++ knows how to handle exceptions.)
>>>
>>> In the libc++ CMakeFiles, it appears to be governed by
LIBCXX_CXX_ABI_LIBNAME, but it isn't being set to the correct value of
"cxxrt" on FreeBSD.  I am going to try the following diff:
>>>
>>> --- llvm.src/projects/libcxx/CMakeLists.txt
>>> +++ llvm.src/projects/libcxx/CMakeLists.txt
>>> @@ -135,6 +135,8 @@
>>>  elseif (APPLE)
>>>    set(LIBCXX_CXX_ABI_LIBNAME "libcxxabi")
>>>    set(LIBCXX_CXX_ABI_SYSTEM 1)
>>> +  elseif (CMAKE_SYSTEM_NAME MATCHES "FreeBSD")
>>> +    set(LIBCXX_CXX_ABI_LIBNAME "libcxxrt")
>>>  else()
>>>    set(LIBCXX_CXX_ABI_LIBNAME "default")
>>>  endif()
>>
>> ... and unfortunately that didn't work, since the CMakeFiles are
unable to find the libcxxrt headers:
>>
>> CMake Warning at projects/libcxx/cmake/Modules/HandleLibCXXABI.cmake:67
(message):
>>  Failed to find cxxabi.h
>> Call Stack (most recent call first):
>>  projects/libcxx/cmake/Modules/HandleLibCXXABI.cmake:112
(setup_abi_lib)
>>  projects/libcxx/CMakeLists.txt:428 (include)
>
> Ok, this turned out to be easier than I thought.  After applying
https://reviews.llvm.org/D43166, the number of failed tests drops roughly by
half (from 896 to 512):
>
>   Expected Passes    : 45381
>   Expected Failures  : 185
>   Unsupported Tests  : 2937
>   Unexpected Passes  : 1
>   Unexpected Failures: 521
>
> I am going to have a look at some other low hanging fruit, and I have also
created a few PRs to merge test changes into 6.0.
Nice!

It sounds like most of this is stuff that's always been failing, so
I'm not going to worry too much, but it's very nice to see the error
numbers go down.

Thanks,
Hans

I noticed a problem with llvm-config.exe on Windows:
>"c:\Users\andy\llvm+clang-6.0.0rc2-win64-msvc-release\bin\llvm-config.exe"
--system-libs
psapi.lib shell32.lib ole32.lib uuid.lib

But then when I link against LLVM and these libs, I get:

lld: error: LLVMSupport.lib(Process.obj): undefined symbol:
__imp_CryptAcquireContextW
lld: error: LLVMSupport.lib(RandomNumberGenerator.obj): undefined
symbol: __imp_CryptAcquireContextW
lld: error: LLVMSupport.lib(Signals.obj): undefined symbol: __imp_RegCloseKey
lld: error: LLVMSupport.lib(Signals.obj): undefined symbol: __imp_RegOpenKeyExA
lld: error: LLVMSupport.lib(Signals.obj): undefined symbol: __imp_RegGetValueW


It seems that Advapi32.lib is missing from the --system-libs list.

On Mon, Feb 12, 2018 at 4:16 AM, Hans Wennborg via llvm-dev
<llvm-dev at lists.llvm.org> wrote:
> On Sun, Feb 11, 2018 at 3:31 PM, Dimitry Andric <dimitry at
andric.com> wrote:
>> On 9 Feb 2018, at 22:30, Dimitry Andric <dimitry at andric.com>
wrote:
>>>
>>> On 9 Feb 2018, at 22:11, Dimitry Andric via Openmp-dev
<openmp-dev at lists.llvm.org> wrote:
>>>>
>>>> On 9 Feb 2018, at 20:40, Dimitry Andric via cfe-dev <cfe-dev
at lists.llvm.org> wrote:
>>>>>
>>>>>> On 9 Feb 2018, at 10:20, Hans Wennborg <hans at
chromium.org> wrote:
>>>> ...
>>>>>> What are all these test failures? Does it seems like
they have a
>>>>>> common root cause and do we have a bug for it?
>>>> ...
>>>>> The Clang Tools and Extra Tools Unit tests all appear to
crash with:
>>>>>
>>>>>  exception_ptr not yet implemented
>>>>
>>>> This turns out to be caused by libc++ being compiled without
-DLIBCXXRT.  (In the FreeBSD base system build, we always add this option, so
libc++ knows how to handle exceptions.)
>>>>
>>>> In the libc++ CMakeFiles, it appears to be governed by
LIBCXX_CXX_ABI_LIBNAME, but it isn't being set to the correct value of
"cxxrt" on FreeBSD.  I am going to try the following diff:
>>>>
>>>> --- llvm.src/projects/libcxx/CMakeLists.txt
>>>> +++ llvm.src/projects/libcxx/CMakeLists.txt
>>>> @@ -135,6 +135,8 @@
>>>>  elseif (APPLE)
>>>>    set(LIBCXX_CXX_ABI_LIBNAME "libcxxabi")
>>>>    set(LIBCXX_CXX_ABI_SYSTEM 1)
>>>> +  elseif (CMAKE_SYSTEM_NAME MATCHES "FreeBSD")
>>>> +    set(LIBCXX_CXX_ABI_LIBNAME "libcxxrt")
>>>>  else()
>>>>    set(LIBCXX_CXX_ABI_LIBNAME "default")
>>>>  endif()
>>>
>>> ... and unfortunately that didn't work, since the CMakeFiles
are unable to find the libcxxrt headers:
>>>
>>> CMake Warning at
projects/libcxx/cmake/Modules/HandleLibCXXABI.cmake:67 (message):
>>>  Failed to find cxxabi.h
>>> Call Stack (most recent call first):
>>>  projects/libcxx/cmake/Modules/HandleLibCXXABI.cmake:112
(setup_abi_lib)
>>>  projects/libcxx/CMakeLists.txt:428 (include)
>>
>> Ok, this turned out to be easier than I thought.  After applying
https://reviews.llvm.org/D43166, the number of failed tests drops roughly by
half (from 896 to 512):
>>
>>   Expected Passes    : 45381
>>   Expected Failures  : 185
>>   Unsupported Tests  : 2937
>>   Unexpected Passes  : 1
>>   Unexpected Failures: 521
>>
>> I am going to have a look at some other low hanging fruit, and I have
also created a few PRs to merge test changes into 6.0.
>
> Nice!
>
> It sounds like most of this is stuff that's always been failing, so
> I'm not going to worry too much, but it's very nice to see the
error
> numbers go down.
>
> Thanks,
> Hans
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev