On 17 Jan 2017, at 01:17, Chris Lattner via llvm-dev <llvm-dev at lists.llvm.org> wrote:> - The download size of a mono-repo is manageable, and seems scalable for a project the size of LLVM (including reasonable growth over the next 10 years).Did you consider that GitHub has a 1GB size limit/recommendation? https://help.github.com/articles/what-is-my-disk-quota/ The full mono-repo is already approaching this limit: llvm-project 1.5G (.git 871M) (GitHub API 830,702K) On Tue, Jan 17, 2017 at 4:24 PM, David Chisnall via llvm-dev <llvm-dev at lists.llvm.org> wrote:> > I would be in favour of a monorepo for everything that links against LLVM libraries and everything else being in separate repos.I agree fully. I work on a project that use submodules for external dependencies. For llvm this means compiling and linking statically with dependencies for Linux and OSX platforms. So these: (compiler-rt, libcxx, libcxxabi, libunwind) 141M (.git 60M) I would hesitate to add a dependency that use 1.5G disk space, so if you go with the mono-repo approach I would probably use the supposed read only mirror repos for these modules. This in turn would mean that the hurdle for contributing back to these projects would increase and thus the the likelihood of contributions. Consolidating other projects with interdependencies into other mono-repos would also make sense. E.g. libcxx with dependencies. The most important thing is to make a decision. I have some small contributions just waiting for a sane contribution process (GitHub pull requests) ;) Erik
github would probably do a 1GB limit exception for the project, but you'd need to ask them. Personally I'm against the mono project for reasons others have stated before. On Sat, Apr 22, 2017 at 4:37 PM, Erik Olofsson via llvm-dev <llvm-dev at lists.llvm.org> wrote:> On 17 Jan 2017, at 01:17, Chris Lattner via llvm-dev > <llvm-dev at lists.llvm.org> wrote: >> - The download size of a mono-repo is manageable, and seems scalable for a project the size of LLVM (including reasonable growth over the next 10 years). > > Did you consider that GitHub has a 1GB size limit/recommendation? > https://help.github.com/articles/what-is-my-disk-quota/ > > The full mono-repo is already approaching this limit: > llvm-project 1.5G (.git 871M) (GitHub API 830,702K) > > > > On Tue, Jan 17, 2017 at 4:24 PM, David Chisnall via llvm-dev > <llvm-dev at lists.llvm.org> wrote: >> >> I would be in favour of a monorepo for everything that links against LLVM libraries and everything else being in separate repos. > > I agree fully. I work on a project that use submodules for external > dependencies. For llvm this means compiling and linking statically > with dependencies for Linux and OSX platforms. So these: > > (compiler-rt, libcxx, libcxxabi, libunwind) 141M (.git 60M) > > I would hesitate to add a dependency that use 1.5G disk space, so if > you go with the mono-repo approach I would probably use the supposed > read only mirror repos for these modules. > > This in turn would mean that the hurdle for contributing back to these > projects would increase and thus the the likelihood of contributions. > > Consolidating other projects with interdependencies into other > mono-repos would also make sense. E.g. libcxx with dependencies. > > > > The most important thing is to make a decision. I have some small > contributions just waiting for a sane contribution process (GitHub > pull requests) ;) > > Erik > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
On Sat, Apr 22, 2017 at 10:37:06AM +0200, Erik Olofsson via llvm-dev wrote:> On 17 Jan 2017, at 01:17, Chris Lattner via llvm-dev > <llvm-dev at lists.llvm.org> wrote: > > - The download size of a mono-repo is manageable, and seems scalable for a project the size of LLVM (including reasonable growth over the next 10 years). > > Did you consider that GitHub has a 1GB size limit/recommendation? > https://help.github.com/articles/what-is-my-disk-quota/They are normally quite willing to lift that one for FOSS. It is primarily a 1GB pack size limit. Joerg
Last time I checked, the llvm pack size (mono repo) was about 450 MB. It won't be growing very quickly. On Sat, Apr 22, 2017 at 5:46 PM, Joerg Sonnenberger via llvm-dev < llvm-dev at lists.llvm.org> wrote:> On Sat, Apr 22, 2017 at 10:37:06AM +0200, Erik Olofsson via llvm-dev wrote: > > On 17 Jan 2017, at 01:17, Chris Lattner via llvm-dev > > <llvm-dev at lists.llvm.org> wrote: > > > - The download size of a mono-repo is manageable, and seems scalable > for a project the size of LLVM (including reasonable growth over the next > 10 years). > > > > Did you consider that GitHub has a 1GB size limit/recommendation? > > https://help.github.com/articles/what-is-my-disk-quota/ > > They are normally quite willing to lift that one for FOSS. It is > primarily a 1GB pack size limit. > > Joerg > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20170422/e841a9d8/attachment.html>
On Sat, Apr 22, 2017 at 1:37 AM, Erik Olofsson via llvm-dev < llvm-dev at lists.llvm.org> wrote:> On 17 Jan 2017, at 01:17, Chris Lattner via llvm-dev > <llvm-dev at lists.llvm.org> wrote: > > - The download size of a mono-repo is manageable, and seems scalable for > a project the size of LLVM (including reasonable growth over the next 10 > years). > > Did you consider that GitHub has a 1GB size limit/recommendation? > https://help.github.com/articles/what-is-my-disk-quota/No, it doesn't. It says "we recommend". If you have legitimate reasons, they are fine with it. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20170422/d3df6200/attachment.html>
> On Apr 22, 2017, at 1:37 AM, Erik Olofsson via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > On 17 Jan 2017, at 01:17, Chris Lattner via llvm-dev > <llvm-dev at lists.llvm.org> wrote: >> - The download size of a mono-repo is manageable, and seems scalable for a project the size of LLVM (including reasonable growth over the next 10 years). > > Did you consider that GitHub has a 1GB size limit/recommendation? > https://help.github.com/articles/what-is-my-disk-quota/ > > The full mono-repo is already approaching this limit: > llvm-project 1.5G (.git 871M) (GitHub API 830,702K)The correctly packed repo is closer to 500MB last time I checked.> On Tue, Jan 17, 2017 at 4:24 PM, David Chisnall via llvm-dev > <llvm-dev at lists.llvm.org> wrote: >> >> I would be in favour of a monorepo for everything that links against LLVM libraries and everything else being in separate repos. > > I agree fully. I work on a project that use submodules for external > dependencies. For llvm this means compiling and linking statically > with dependencies for Linux and OSX platforms. So these: > > (compiler-rt, libcxx, libcxxabi, libunwind) 141M (.git 60M) > > I would hesitate to add a dependency that use 1.5G disk space, so if > you go with the mono-repo approach I would probably use the supposed > read only mirror repos for these modules. > > This in turn would mean that the hurdle for contributing back to these > projects would increase and thus the the likelihood of contributions.That’s an optimization problem IMO, and optimizing should be done for the main use-case.> > Consolidating other projects with interdependencies into other > mono-repos would also make sense. E.g. libcxx with dependencies. > > > > The most important thing is to make a decision. I have some small > contributions just waiting for a sane contribution process (GitHub > pull requests) ;)Moving to GitHub does not automatically mean we will accept pull request. This will be another discussion after the move, so don’t hold your breath on it for now. But seriously, we have multiple options to contribute available right now: - `arc diff` will upload directly to phabricator - `git format-patch` (or `git diff`) and upload manually to phabricator - `git format-patch` (or `git diff`) and email to llvm-commit That shouldn’t prevent anyone from submitting a contribution. — Mehdi