llvm dev - Apr 2017 - Permissions for llvm-mirror - Setting up Libc++ Appveyor builders

> On Apr 20, 2017, at 12:30 PM, Eric Fiselier <eric at efcs.ca> wrote:
> 
> 
> 
> On Thu, Apr 20, 2017 at 11:06 AM, Mehdi Amini <mehdi.amini at apple.com
<mailto:mehdi.amini at apple.com>> wrote:
> 
>> On Apr 20, 2017, at 12:39 AM, Eric Fiselier <eric at efcs.ca
<mailto:eric at efcs.ca>> wrote:
>> 
>> 
>> 
>> On Wed, Apr 19, 2017 at 11:19 PM, Mehdi Amini <mehdi.amini at
apple.com <mailto:mehdi.amini at apple.com>> wrote:
>> What would be the status of these buildbots? Is it for your private
usage?
>> 
>> I intend for them to be public Windows buildbots for libc++.
> 
> 
> I’m not sure it’d be OK to send blame email to contributors based on this
though.
> 
> I don't see why not (at least once the bot is stable). Can you
elaborate?
I don’t think there is a precedent for having a bot that does not checkout from
SVN and email using the canonical SVN revision number.

So it does not seems like a given to me  (not that I’m against it) and would
require a discussion on the mailing-list first IMO.

— 
Mehdi



>  
> /Eric
> 
> 
> — 
> Mehdi
> 
> 
>> 
>> Otherwise having “project' bots” using a non-official mirror may
sound like a strange situation to me.
>> 
>> I agree it isn't ideal, but when/if LLVM moves to github it will be
trivial to re-configure for the official repositories.
>> I considered a number of other ways to setup Appveyor but I concluded
this was the best/easiest way to do it.
>> The other options I considered for configuring Appveyor are:
>> 
>> (1) Use the official LLVM github mirrors.
>>  
>> This has the issue of requiring the implementation of custom Git
webhooks, which would require
>> modifying and maintaining changes to the existing LLVM Git
infrastructure, which in itself
>> would require getting access to the LLVM servers to make the changes.
>> 
>> (2) Setup my own ever more unofficial github mirror 
>> 
>> This has all the same problems as using the existing github mirrors but
it requires
>> me to configure and maintain my own mirror, which is non-trivial.
>> 
>> (3) Don't use Appveyor at all
>> 
>> This requires finding Windows hardware to host the bots, which is the
main reason
>> I chose Appveyor to begin with. Even if hardware was available I would
prefer using
>> Appveyor since it provides more dominion over the environment than I
think
>> donated hardware could.
>> 
>> /Eric
>> 
>> 
>> — 
>> Mehdi
>> 
>>> On Apr 19, 2017, at 5:04 PM, Eric Fiselier via llvm-dev
<llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>>
wrote:
>>> 
>>> Adding cfe-dev list...
>>> 
>>> On Wed, Apr 19, 2017 at 5:50 PM, Eric Fiselier <eric at efcs.ca
<mailto:eric at efcs.ca>> wrote:
>>> Hi Will,
>>> 
>>> I would like to request collaborator permissions for the Libc++
github mirror.
>>> 
>>> I plan to use the access to setup Appveyor buildbots for libc++. In
order to do this I need to be listed as a collaborator on Github.
>>> 
>>> The alternative to Github access would be setting up the correct
webhooks for llvm.org/git/libcxx.git <http://llvm.org/git/libcxx.git>, but
this seems harder to both do and maintain.
>>> 
>>> /Eric
>>> 
>>> _______________________________________________
>>> LLVM Developers mailing list
>>> llvm-dev at lists.llvm.org <mailto:llvm-dev at
lists.llvm.org>
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
<http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev>
>> 
>> 
> 
> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20170420/67d82c62/attachment.html>

On Thu, Apr 20, 2017 at 4:55 PM, Mehdi Amini <mehdi.amini at apple.com>
wrote:
>
> On Apr 20, 2017, at 12:30 PM, Eric Fiselier <eric at efcs.ca> wrote:
>
>
>
> On Thu, Apr 20, 2017 at 11:06 AM, Mehdi Amini <mehdi.amini at
apple.com>
> wrote:
>
>>
>> On Apr 20, 2017, at 12:39 AM, Eric Fiselier <eric at efcs.ca>
wrote:
>>
>>
>>
>> On Wed, Apr 19, 2017 at 11:19 PM, Mehdi Amini <mehdi.amini at
apple.com>
>> wrote:
>>
>>> What would be the status of these buildbots? Is it for your private
>>> usage?
>>>
>>
>> I intend for them to be public Windows buildbots for libc++.
>>
>>
>>
>> I’m not sure it’d be OK to send blame email to contributors based on
this
>> though.
>>
>
> I don't see why not (at least once the bot is stable). Can you
elaborate?
>
>
> I don’t think there is a precedent for having a bot that does not checkout
> from SVN and email using the canonical SVN revision number.
>
I understand share your concern about the emails using nonsensical git
hashes as opposed to SVN revision numbers.
Apart from that I have no idea why the version control used by the CI
matters. It should have to effect on the build or the results.

>
> So it does not seems like a given to me  (not that I’m against it) and
> would require a discussion on the mailing-list first IMO.
>
We might as well continue having it now since it's been started. I'll
re-raise the issue in a month or so when the bot is
actually stable enough to consider sending emails.

>
> —
> Mehdi
>
>
>
>
>
> /Eric
>
>
>> —
>> Mehdi
>>
>>
>>
>> Otherwise having “project' bots” using a non-official mirror may
sound
>>> like a strange situation to me.
>>>
>>
>> I agree it isn't ideal, but when/if LLVM moves to github it will be
>> trivial to re-configure for the official repositories.
>> I considered a number of other ways to setup Appveyor but I concluded
>> this was the best/easiest way to do it.
>> The other options I considered for configuring Appveyor are:
>>
>> (1) Use the official LLVM github mirrors.
>>
>> This has the issue of requiring the implementation of custom Git
>> webhooks, which would require
>> modifying and maintaining changes to the existing LLVM Git
>> infrastructure, which in itself
>> would require getting access to the LLVM servers to make the changes.
>>
>> (2) Setup my own ever more unofficial github mirror
>>
>> This has all the same problems as using the existing github mirrors but
>> it requires
>> me to configure and maintain my own mirror, which is non-trivial.
>>
>> (3) Don't use Appveyor at all
>>
>> This requires finding Windows hardware to host the bots, which is the
>> main reason
>> I chose Appveyor to begin with. Even if hardware was available I would
>> prefer using
>> Appveyor since it provides more dominion over the environment than I
think
>> donated hardware could.
>>
>> /Eric
>>
>>
>>> —
>>> Mehdi
>>>
>>> On Apr 19, 2017, at 5:04 PM, Eric Fiselier via llvm-dev <
>>> llvm-dev at lists.llvm.org> wrote:
>>>
>>> Adding cfe-dev list...
>>>
>>> On Wed, Apr 19, 2017 at 5:50 PM, Eric Fiselier <eric at
efcs.ca> wrote:
>>>
>>>> Hi Will,
>>>>
>>>> I would like to request collaborator permissions for the Libc++
github
>>>> mirror.
>>>>
>>>> I plan to use the access to setup Appveyor buildbots for
libc++. In
>>>> order to do this I need to be listed as a collaborator on
Github.
>>>>
>>>> The alternative to Github access would be setting up the
correct
>>>> webhooks for llvm.org/git/libcxx.git, but this seems harder to
both do
>>>> and maintain.
>>>>
>>>> /Eric
>>>>
>>>
>>> _______________________________________________
>>> LLVM Developers mailing list
>>> llvm-dev at lists.llvm.org
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>>>
>>>
>>>
>>
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20170420/22af18b0/attachment.html>

> On Apr 20, 2017, at 7:03 PM, Eric Fiselier <eric at efcs.ca> wrote:
> 
> 
> 
> On Thu, Apr 20, 2017 at 4:55 PM, Mehdi Amini <mehdi.amini at apple.com
<mailto:mehdi.amini at apple.com>> wrote:
> 
>> On Apr 20, 2017, at 12:30 PM, Eric Fiselier <eric at efcs.ca
<mailto:eric at efcs.ca>> wrote:
>> 
>> 
>> 
>> On Thu, Apr 20, 2017 at 11:06 AM, Mehdi Amini <mehdi.amini at
apple.com <mailto:mehdi.amini at apple.com>> wrote:
>> 
>>> On Apr 20, 2017, at 12:39 AM, Eric Fiselier <eric at efcs.ca
<mailto:eric at efcs.ca>> wrote:
>>> 
>>> 
>>> 
>>> On Wed, Apr 19, 2017 at 11:19 PM, Mehdi Amini <mehdi.amini at
apple.com <mailto:mehdi.amini at apple.com>> wrote:
>>> What would be the status of these buildbots? Is it for your private
usage?
>>> 
>>> I intend for them to be public Windows buildbots for libc++.
>> 
>> 
>> I’m not sure it’d be OK to send blame email to contributors based on
this though.
>> 
>> I don't see why not (at least once the bot is stable). Can you
elaborate?
> 
> I don’t think there is a precedent for having a bot that does not checkout
from SVN and email using the canonical SVN revision number.
> 
> I understand share your concern about the emails using nonsensical git
hashes as opposed to SVN revision numbers.
> Apart from that I have no idea why the version control used by the CI
matters. It should have to effect on the build or the results.
I don’t know, but other people may have other concern that I don’t necessarily
anticipate..
>  
> 
> So it does not seems like a given to me  (not that I’m against it) and
would require a discussion on the mailing-list first IMO.
> 
> We might as well continue having it now since it's been started.
I'll re-raise the issue in a month or so when the bot is
> actually stable enough to consider sending emails.
I think it deserve a separate thread to deal with this, so that the thread title
help making sure no-one miss the discussion.

— 
Mehdi

-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20170420/df6b12c9/attachment.html>