On Wed, Mar 29, 2017 at 2:15 PM, Friedman, Eli <efriedma at codeaurora.org> wrote:> On 3/29/2017 1:05 PM, Hongbin Zheng wrote: > >> Hi Eli, >> >> Thanks. Do you mean ideally we should extend SimplifyIndVar to do the >> sdiv->udiv replacement? >> > > I haven't really looked into it closely, but it seems to make sense.Ok. Once I extend SimplifyIndVar, e.g. the simplifyUsersOfIV function. How I can add a regression test for the extension? simplifyUsersOfIV is not a pass. Thanks Hongbin> > -Eli > > -- > Employee of Qualcomm Innovation Center, Inc. > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux > Foundation Collaborative Project > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20170329/b497eb35/attachment.html>
On 3/29/2017 3:00 PM, Hongbin Zheng wrote:> > > On Wed, Mar 29, 2017 at 2:15 PM, Friedman, Eli > <efriedma at codeaurora.org <mailto:efriedma at codeaurora.org>> wrote: > > On 3/29/2017 1:05 PM, Hongbin Zheng wrote: > > Hi Eli, > > Thanks. Do you mean ideally we should extend SimplifyIndVar to > do the sdiv->udiv replacement? > > > I haven't really looked into it closely, but it seems to make sense. > > Ok. > > Once I extend SimplifyIndVar, e.g. the simplifyUsersOfIV function. > How I can add a regression test for the extension? simplifyUsersOfIV > is not a pass.It gets called by -indvars. -Eli -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20170329/1ae57082/attachment.html>
Hi Eli, I create a patch at https://reviews.llvm.org/D31488 Thanks Hongbin On Wed, Mar 29, 2017 at 3:18 PM, Friedman, Eli <efriedma at codeaurora.org> wrote:> On 3/29/2017 3:00 PM, Hongbin Zheng wrote: > > > > On Wed, Mar 29, 2017 at 2:15 PM, Friedman, Eli <efriedma at codeaurora.org> > wrote: > >> On 3/29/2017 1:05 PM, Hongbin Zheng wrote: >> >>> Hi Eli, >>> >>> Thanks. Do you mean ideally we should extend SimplifyIndVar to do the >>> sdiv->udiv replacement? >>> >> >> I haven't really looked into it closely, but it seems to make sense. > > Ok. > > Once I extend SimplifyIndVar, e.g. the simplifyUsersOfIV function. How I > can add a regression test for the extension? simplifyUsersOfIV is not a > pass. > > > It gets called by -indvars. > > -Eli > > -- > Employee of Qualcomm Innovation Center, Inc. > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20170329/a6f7c1c9/attachment.html>