llvm dev - Mar 2017 - Closing a Phabricator review

Hi,



I recently had a change that I put up for review on Phabricator accepted
and committed by somebody via the mailing list, but without the Phabricator
review being modified at all. The committer didn’t put the Phabricator
review number in the commit message, so the review remains open. Is there
any way of manually closing it? I couldn’t see under the list of available
actions an option to do so (it got committed, so abandoning doesn't seem
quite right). For reference, the review in question was
https://reviews/llvm.org/D30540. Any help will be much appreciated.



Thanks,


James
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20170315/39c08921/attachment.html>

Hi James,

I accepted the review in Phabricator (given it's already committed). You 
should be able to close it now: just above the comment box at the bottom 
of the review, you should be able to select "Close revision" from the 
"Add Action" drop-down.

Cheers,
Florian