Dmytro Yurchenko via llvm-dev
2017-Mar-14 09:54 UTC
[llvm-dev] Tiny patch for documentation
Hello there! Possibly wrong template argument for `make_error'. As the code example shows the implementation of `BadFileFormat' error class, I suppose that class also was meant to be used for `make_error'. Cheers, Dmytro -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20170314/e86babcb/attachment.html> -------------- next part -------------- diff --git docs/ProgrammersManual.rst docs/ProgrammersManual.rst index decac60..5b03eb8 100644 --- docs/ProgrammersManual.rst +++ docs/ProgrammersManual.rst @@ -486,7 +486,7 @@ that inherits from the ErrorInfo utility, E.g.: Error printFormattedFile(StringRef Path) { if (<check for valid format>) - return make_error<InvalidObjectFile>(Path); + return make_error<BadFileFormat>(Path); // print file contents. return Error::success(); }
Hi Dmytro, On 14/03/2017 09:54, Dmytro Yurchenko via llvm-dev wrote:> Hello there! > > Possibly wrong template argument for `make_error'. > > As the code example shows the implementation of `BadFileFormat' error > class, I suppose that class also was meant to be used for `make_error'. >Patches should be either sent to llvm-commits (http://lists.llvm.org/mailman/listinfo/llvm-commits) or submitted to https://reviews.llvm.org/ for code review. Cheers, Florian