llvm dev - Feb 2017 - compiler-rt linux-arm builtins/clear_cache.c depends on kernel headers

Hmm, I dont think that this is terrible.  However, since I dont belive that
Linux guarantees the stability of its interfaces, I think that adding a
trivial test for this would be waranteed.

On Sun, Feb 12, 2017 at 2:26 PM, Renato Golin <renato.golin at linaro.org>
wrote:
> On 26 January 2017 at 10:57, Joakim Sindholt via llvm-dev
> <llvm-dev at lists.llvm.org> wrote:
> > It's difficult to ascertain whether it's mixing with libc
headers
> > but if it is then that's a bug in its own right.
> > Either way, it's pulling in kernel headers for a single #defined
> > constant that's been part of the linux ABI for years now. This
> > makes it more difficult to cross compile for, in my opinion, no
> > good reason. So here's a patch to just place the #define inline.
>
> Hi Joakim,
>
> Sorry it took so long. I'm copying Saleem who knows more than I do
about
> this.
>
> That define seems harmless. I checked kernel 3.13 and current trunk
> and the defines are the same. For compatibility, I seriously doubt
> they're going to change it anytime soon.
>
> I'd just add a comment where that line is from
> (arch/arm/include/uapi/asm/unistd.h).
>
> Saleem, any objections?
>
> cheers,
> --renato
>


-- 
Saleem Abdulrasool
compnerd (at) compnerd (dot) org
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20170212/223891d3/attachment.html>

On 12 February 2017 at 15:18, Saleem Abdulrasool via llvm-dev
<llvm-dev at lists.llvm.org> wrote:
> Hmm, I dont think that this is terrible.  However, since I dont belive that
> Linux guarantees the stability of its interfaces, I think that adding a
> trivial test for this would be waranteed.
I think Linux is pretty far towards the conservative end on changing
syscalls (via the "don't break user space" rule that Linus is keen
on). Windows & macOS, you're on your own.

Tim.

On 13 February 2017 at 22:48, Tim Northover <t.p.northover at gmail.com>
wrote:
> I think Linux is pretty far towards the conservative end on changing
> syscalls (via the "don't break user space" rule that Linus is
keen
> on). Windows & macOS, you're on your own.
Ok, I committed in r295738. Let's see if this causes any trouble, but
I'm not expecting any.

Thanks Joakim!

cheers,
--renato