Davide Italiano via llvm-dev
2017-Jan-30 17:41 UTC
[llvm-dev] llvm return value propagation & asm
On Mon, Jan 30, 2017 at 9:34 AM, Reid Kleckner via llvm-dev <llvm-dev at lists.llvm.org> wrote:> We need to disable most forms of IPO on naked functions. We already do this > in DeadArgElimination.cpp. We need to do it in more places. >+1. Carlo, can you please open a bug? -- Davide "There are no solved problems; there are only problems that are more or less solved" -- Henri Poincare
Carlo Kok via llvm-dev
2017-Jan-31 10:47 UTC
[llvm-dev] llvm return value propagation & asm
On 2017-01-30 18:41, Davide Italiano wrote:> On Mon, Jan 30, 2017 at 9:34 AM, Reid Kleckner via llvm-dev > <llvm-dev at lists.llvm.org> wrote: >> We need to disable most forms of IPO on naked functions. We already do this >> in DeadArgElimination.cpp. We need to do it in more places. >> > > +1. Carlo, can you please open a bug? >Done https://llvm.org/bugs/show_bug.cgi?id=31811 -- Carlo Kok RemObjects Software
Davide Italiano via llvm-dev
2017-Feb-01 01:21 UTC
[llvm-dev] llvm return value propagation & asm
On Tue, Jan 31, 2017 at 2:47 AM, Carlo Kok <ck at remobjects.com> wrote:> > > On 2017-01-30 18:41, Davide Italiano wrote: >> >> On Mon, Jan 30, 2017 at 9:34 AM, Reid Kleckner via llvm-dev >> <llvm-dev at lists.llvm.org> wrote: >>> >>> We need to disable most forms of IPO on naked functions. We already do >>> this >>> in DeadArgElimination.cpp. We need to do it in more places. >>> >> >> +1. Carlo, can you please open a bug? >> > > Done > > https://llvm.org/bugs/show_bug.cgi?id=31811 >I committed a fix (r293727), this should be enough for IPSCCP. IPConstprop still needs to learn about the `naked` attribute, but that's not part of the default pipeline. If this really matters to you (and you use 4.0), you may consider asking for a backport, but maybe it's too late (and given it's not a regression maybe not really justifiable). commit dcf8ccaf1afac34fc8fe0f9d7a2131b84a710ba6 Author: davide <davide at 91177308-0d34-0410-b5e6-96231b3b80d8> Date: Wed Feb 1 01:01:22 2017 +0000 [IPSCCP] Teach how to not propagate return values of naked functions. Differential Revision: https://reviews.llvm.org/D29360 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk at 293727 91177308-0d34-0410-b5e6-96231b3b80d8 -- Davide "There are no solved problems; there are only problems that are more or less solved" -- Henri Poincare