Daniel Berlin via llvm-dev
2016-Dec-27 23:34 UTC
[llvm-dev] Call for testing/heads-up: NewGVN
On Tue, Dec 27, 2016 at 3:22 PM, Nemanja Ivanovic via llvm-dev < llvm-dev at lists.llvm.org> wrote:> I assume that this passes all the lit/lnt test cases on the platform that > the developers work on. >Yes I bootstrap/test it.> It causes 31 lnt test case failures on PPC. I've opened a bug with the one > that is easiest to reduce. > Also, I'm happy to assist by providing any further PPC specific > information you require regarding this. > > Thank you> Nemanja > > On Mon, Dec 26, 2016 at 9:55 PM, Mehdi Amini via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > >> Also: does clang bootstrap and pass the tests (and builds the test-suite >> correctly?). >> >> — >> Mehdi >> >> > On Dec 26, 2016, at 12:54 PM, Mehdi Amini via llvm-dev < >> llvm-dev at lists.llvm.org> wrote: >> > >> > Hi, >> > >> > I’m curious if the test-suite running cleanly with this flag? >> > (That would be a first step before wider testing). >> > >> > Thanks, >> > >> > — >> > Mehdi >> > >> >> On Dec 26, 2016, at 10:45 AM, Davide Italiano via llvm-dev < >> llvm-dev at lists.llvm.org> wrote: >> >> >> >> Hi everybody. >> >> NewGVN was recently committed and a few minute ago I added a flag to >> >> enable the new experimental pass. >> >> >> >> For the brave soul, passing `-mllvm -enable-newgvn` should do the >> >> trick. We'll be happy to receive bug reports to analyze/fix, bonus >> >> point if they contain a synthetic/reduced testcase. >> >> Open a bug linked to https://llvm.org/bugs/show_bug.cgi?id=30995 would >> >> be probably best so that all the people working on NewGVN will have >> >> visibility, but I'm aware there are issues with bugzilla registration >> >> disabled recently so if you have issues/don't have an account feel >> >> free to shoot me a mail directly and I'll open a bug on your behalf. >> >> >> >> Looking forward to hearing from you, >> >> >> >> -- >> >> Davide >> >> >> >> "There are no solved problems; there are only problems that are more >> >> or less solved" -- Henri Poincare >> >> _______________________________________________ >> >> LLVM Developers mailing list >> >> llvm-dev at lists.llvm.org >> >> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >> > >> > _______________________________________________ >> > LLVM Developers mailing list >> > llvm-dev at lists.llvm.org >> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >> >> _______________________________________________ >> LLVM Developers mailing list >> llvm-dev at lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >> > > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20161227/6f609bb9/attachment.html>
Daniel Berlin via llvm-dev
2016-Dec-28 01:26 UTC
[llvm-dev] Call for testing/heads-up: NewGVN
These are all caused by a set of failures to properly mark memory users as changed in some cases, and to initialize the memory operand equivalence table properly. I'm thinking how best to solve it. In the meantime, reverting the store equivalence changes should fix most of it (there is one other bug in updateReachableEdge that won't fix, where it misses marking memoryphi's) On Tue, Dec 27, 2016 at 3:34 PM, Daniel Berlin <dberlin at dberlin.org> wrote:> > > On Tue, Dec 27, 2016 at 3:22 PM, Nemanja Ivanovic via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > >> I assume that this passes all the lit/lnt test cases on the platform that >> the developers work on. >> > > Yes > I bootstrap/test it. > > >> It causes 31 lnt test case failures on PPC. I've opened a bug with the >> one that is easiest to reduce. >> Also, I'm happy to assist by providing any further PPC specific >> information you require regarding this. >> >> Thank you > > >> Nemanja >> >> On Mon, Dec 26, 2016 at 9:55 PM, Mehdi Amini via llvm-dev < >> llvm-dev at lists.llvm.org> wrote: >> >>> Also: does clang bootstrap and pass the tests (and builds the test-suite >>> correctly?). >>> >>> — >>> Mehdi >>> >>> > On Dec 26, 2016, at 12:54 PM, Mehdi Amini via llvm-dev < >>> llvm-dev at lists.llvm.org> wrote: >>> > >>> > Hi, >>> > >>> > I’m curious if the test-suite running cleanly with this flag? >>> > (That would be a first step before wider testing). >>> > >>> > Thanks, >>> > >>> > — >>> > Mehdi >>> > >>> >> On Dec 26, 2016, at 10:45 AM, Davide Italiano via llvm-dev < >>> llvm-dev at lists.llvm.org> wrote: >>> >> >>> >> Hi everybody. >>> >> NewGVN was recently committed and a few minute ago I added a flag to >>> >> enable the new experimental pass. >>> >> >>> >> For the brave soul, passing `-mllvm -enable-newgvn` should do the >>> >> trick. We'll be happy to receive bug reports to analyze/fix, bonus >>> >> point if they contain a synthetic/reduced testcase. >>> >> Open a bug linked to https://llvm.org/bugs/show_bug.cgi?id=30995 >>> would >>> >> be probably best so that all the people working on NewGVN will have >>> >> visibility, but I'm aware there are issues with bugzilla registration >>> >> disabled recently so if you have issues/don't have an account feel >>> >> free to shoot me a mail directly and I'll open a bug on your behalf. >>> >> >>> >> Looking forward to hearing from you, >>> >> >>> >> -- >>> >> Davide >>> >> >>> >> "There are no solved problems; there are only problems that are more >>> >> or less solved" -- Henri Poincare >>> >> _______________________________________________ >>> >> LLVM Developers mailing list >>> >> llvm-dev at lists.llvm.org >>> >> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >>> > >>> > _______________________________________________ >>> > LLVM Developers mailing list >>> > llvm-dev at lists.llvm.org >>> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >>> >>> _______________________________________________ >>> LLVM Developers mailing list >>> llvm-dev at lists.llvm.org >>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >>> >> >> >> _______________________________________________ >> LLVM Developers mailing list >> llvm-dev at lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >> >> >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20161227/d074a6e7/attachment-0001.html>
Daniel Berlin via llvm-dev
2016-Dec-28 04:17 UTC
[llvm-dev] Call for testing/heads-up: NewGVN
(and to be clear, reverting it would just hide the bugs pretty well, they'd fix it) I think i have a good way of fixing this properly, patch coming. On Tue, Dec 27, 2016 at 5:26 PM, Daniel Berlin <dberlin at dberlin.org> wrote:> These are all caused by a set of failures to properly mark memory users as > changed in some cases, and to initialize the memory operand equivalence > table properly. > > I'm thinking how best to solve it. > In the meantime, reverting the store equivalence changes should fix most > of it (there is one other bug in updateReachableEdge that won't fix, where > it misses marking memoryphi's) > > > On Tue, Dec 27, 2016 at 3:34 PM, Daniel Berlin <dberlin at dberlin.org> > wrote: > >> >> >> On Tue, Dec 27, 2016 at 3:22 PM, Nemanja Ivanovic via llvm-dev < >> llvm-dev at lists.llvm.org> wrote: >> >>> I assume that this passes all the lit/lnt test cases on the platform >>> that the developers work on. >>> >> >> Yes >> I bootstrap/test it. >> >> >>> It causes 31 lnt test case failures on PPC. I've opened a bug with the >>> one that is easiest to reduce. >>> Also, I'm happy to assist by providing any further PPC specific >>> information you require regarding this. >>> >>> Thank you >> >> >>> Nemanja >>> >>> On Mon, Dec 26, 2016 at 9:55 PM, Mehdi Amini via llvm-dev < >>> llvm-dev at lists.llvm.org> wrote: >>> >>>> Also: does clang bootstrap and pass the tests (and builds the >>>> test-suite correctly?). >>>> >>>> — >>>> Mehdi >>>> >>>> > On Dec 26, 2016, at 12:54 PM, Mehdi Amini via llvm-dev < >>>> llvm-dev at lists.llvm.org> wrote: >>>> > >>>> > Hi, >>>> > >>>> > I’m curious if the test-suite running cleanly with this flag? >>>> > (That would be a first step before wider testing). >>>> > >>>> > Thanks, >>>> > >>>> > — >>>> > Mehdi >>>> > >>>> >> On Dec 26, 2016, at 10:45 AM, Davide Italiano via llvm-dev < >>>> llvm-dev at lists.llvm.org> wrote: >>>> >> >>>> >> Hi everybody. >>>> >> NewGVN was recently committed and a few minute ago I added a flag to >>>> >> enable the new experimental pass. >>>> >> >>>> >> For the brave soul, passing `-mllvm -enable-newgvn` should do the >>>> >> trick. We'll be happy to receive bug reports to analyze/fix, bonus >>>> >> point if they contain a synthetic/reduced testcase. >>>> >> Open a bug linked to https://llvm.org/bugs/show_bug.cgi?id=30995 >>>> would >>>> >> be probably best so that all the people working on NewGVN will have >>>> >> visibility, but I'm aware there are issues with bugzilla registration >>>> >> disabled recently so if you have issues/don't have an account feel >>>> >> free to shoot me a mail directly and I'll open a bug on your behalf. >>>> >> >>>> >> Looking forward to hearing from you, >>>> >> >>>> >> -- >>>> >> Davide >>>> >> >>>> >> "There are no solved problems; there are only problems that are more >>>> >> or less solved" -- Henri Poincare >>>> >> _______________________________________________ >>>> >> LLVM Developers mailing list >>>> >> llvm-dev at lists.llvm.org >>>> >> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >>>> > >>>> > _______________________________________________ >>>> > LLVM Developers mailing list >>>> > llvm-dev at lists.llvm.org >>>> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >>>> >>>> _______________________________________________ >>>> LLVM Developers mailing list >>>> llvm-dev at lists.llvm.org >>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >>>> >>> >>> >>> _______________________________________________ >>> LLVM Developers mailing list >>> llvm-dev at lists.llvm.org >>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >>> >>> >> >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20161227/baf24919/attachment.html>