Johannes Doerfert via llvm-dev
2016-Nov-16 11:04 UTC
[llvm-dev] Highlighting trailing whitespaces on Phab?
On 11/14, Mehdi Amini via llvm-dev wrote:> Ideally I’d even really like to have a both checking for revision on > phab, clang-formatting them, and post a comment when there is a > mismatch :)I'd like that! -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 195 bytes Desc: Digital signature URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20161116/0df84004/attachment.sig>
Eric Liu via llvm-dev
2016-Nov-16 11:28 UTC
[llvm-dev] Highlighting trailing whitespaces on Phab?
I'm not sure how easy it is to get clang-format into Phabricator since it is mostly developed by (phab) upstream. I'll file feature request regarding trailing whitespaces and clang-format to upstream to see what upstream forks think. But a bot checking revision sounds great. It might also be useful to have the bot run clang-tidy and post findings/FixHints as comments on the patch. On Wed, Nov 16, 2016 at 12:05 PM Johannes Doerfert via llvm-dev < llvm-dev at lists.llvm.org> wrote:> On 11/14, Mehdi Amini via llvm-dev wrote: > > Ideally I’d even really like to have a both checking for revision on > > phab, clang-formatting them, and post a comment when there is a > > mismatch :) > I'd like that! > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20161116/42f0a20e/attachment.html>
Eric Liu via llvm-dev
2016-Nov-16 13:44 UTC
[llvm-dev] Highlighting trailing whitespaces on Phab?
So, I forwarded the request for highlighting trailing whitespaces to phabricator upstream (https://secure.phabricator.com/T11879), and upstream folks suggest we enable the Lint feature in Arcanist ( https://secure.phabricator.com/book/phabricator/article/arcanist_lint/). This will enforce the check when `arc diff` is run (reviewers wouldn't see the warnings though). There are two linters we might be interested in enabling: - cpplint (code style checker based on cpplint.py <https://github.com/google/styleguide>) - cppcheck (C++ linter based on cppcheck <http://cppcheck.sourceforge.net/>) Note that cpplint assumes google code style, but I think it can potentially be replaced it with clang-format with configurable code styles. On Wed, Nov 16, 2016 at 12:28 PM Eric Liu <ioeric at google.com> wrote: I'm not sure how easy it is to get clang-format into Phabricator since it is mostly developed by (phab) upstream. I'll file feature request regarding trailing whitespaces and clang-format to upstream to see what upstream forks think. But a bot checking revision sounds great. It might also be useful to have the bot run clang-tidy and post findings/FixHints as comments on the patch. On Wed, Nov 16, 2016 at 12:05 PM Johannes Doerfert via llvm-dev < llvm-dev at lists.llvm.org> wrote: On 11/14, Mehdi Amini via llvm-dev wrote:> Ideally I’d even really like to have a both checking for revision on > phab, clang-formatting them, and post a comment when there is a > mismatch :)I'd like that! _______________________________________________ LLVM Developers mailing list llvm-dev at lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20161116/ea19a6cc/attachment.html>