Hi, The LLVM variant we're building now contains usage of a third-party threading library, and we would like to push our work upstream in the future. Are third-party libraries welcomed to be added in LLVM? If yes, what folder structure should we arrange? B.R. -- Bekket McClane Department of Computer Science, National Tsing Hua University -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20161019/13639615/attachment.html>
> On Oct 18, 2016, at 6:28 PM, Bekket McClane via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > Hi, > The LLVM variant we're building now contains usage of a third-party threading library, and we would like to push our work upstream in the future.What is the motivation? For instance what is this doing that std::thread or llvm::ThreadPool is not providing? Why is it useful to have it in tree?> Are third-party libraries welcomed to be added in LLVM? If yes, what folder structure should we arrange?In general we avoid them as much as possible and need a really compelling justification to include one. Chris reinstated this position recently: http://lists.llvm.org/pipermail/llvm-dev/2016-September/105166.html <http://lists.llvm.org/pipermail/llvm-dev/2016-September/105166.html> — Mehdi -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20161018/856c1b99/attachment.html>
> Mehdi Amini <mehdi.amini at apple.com> 於 2016年10月19日 上午11:30 寫道： > > >> On Oct 18, 2016, at 6:28 PM, Bekket McClane via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote: >> >> Hi, >> The LLVM variant we're building now contains usage of a third-party threading library, and we would like to push our work upstream in the future. > > What is the motivation? > For instance what is this doing that std::thread or llvm::ThreadPool is not providing? Why is it useful to have it in tree?The library we’re using is actually a routine library which provides extremely fast context switching similar to Go routine. I think neither standard library nor LLVM support library provide this functionality.> > >> Are third-party libraries welcomed to be added in LLVM? If yes, what folder structure should we arrange? > > In general we avoid them as much as possible and need a really compelling justification to include one. > Chris reinstated this position recently: http://lists.llvm.org/pipermail/llvm-dev/2016-September/105166.html <http://lists.llvm.org/pipermail/llvm-dev/2016-September/105166.html>Thanks, we would take this policy into our consideration. B.R. McClane> > — > Mehdi >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20161019/9906f65b/attachment.html>