Hi all,
I want to match addition with 16bit integers. So I define a pattern
fragment as follows:
def simm16 : PatLeaf<(imm), [{ return isInt<16>(N->getSExtValue());
}]>;
Now I am confused between
(add R32:$dst, simm16:$im) and
(add R32:$dst, (i32 simm16:$im)).
Do both of them match the same pattern? Are they equivalent? If not what is
the difference?
I am also confused as to how ValueTypes relate to SDNodes as I think we are
able to use both of them as nodes.
--
Regards
Pratik Bhatu
Dual Degree(B.Tech + M.Tech), 5th Year
Computer Science and Engineering
IIT Hyderabad
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20160830/7df99b14/attachment.html>
Ryan Taylor via llvm-dev
2016-Aug-30 20:10 UTC
[llvm-dev] Tablegen pattern matching question
What are you trying to add, I see you have a result $dst of register class R32 and an imm src operand, what is being added? This looks more like a move to me. And in the second example you are trying to force simm16:$I'm to i32? -Ryan On Tue, Aug 30, 2016 at 1:21 PM, Bhatu via llvm-dev <llvm-dev at lists.llvm.org> wrote:> Hi all, > > I want to match addition with 16bit integers. So I define a pattern > fragment as follows: > def simm16 : PatLeaf<(imm), [{ return isInt<16>(N->getSExtValue()); }]>; > > Now I am confused between > (add R32:$dst, simm16:$im) and > (add R32:$dst, (i32 simm16:$im)). > > Do both of them match the same pattern? Are they equivalent? If not what > is the difference? > I am also confused as to how ValueTypes relate to SDNodes as I think we > are able to use both of them as nodes. > > -- > Regards > Pratik Bhatu > Dual Degree(B.Tech + M.Tech), 5th Year > Computer Science and Engineering > IIT Hyderabad > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160830/3153270c/attachment.html>
Craig Topper via llvm-dev
2016-Aug-30 23:04 UTC
[llvm-dev] Tablegen pattern matching question
Patterns are able to infer types based on constraints specified on the SDNode class (in this case the "add" node. The "add" node is defined as requiring both inputs to be the same type. I presume R32 register class is defined as only supporting i32 types. So the type of the immediate operand is inferred to be i32 and you don't need to specify it. You should get a build failure if you write (add R32:$dst, (i16 simm16:$im)). This will be a type constradiction since the operands of the add don't have the same type. ~Craig On Tue, Aug 30, 2016 at 1:10 PM, Ryan Taylor via llvm-dev < llvm-dev at lists.llvm.org> wrote:> What are you trying to add, I see you have a result $dst of register class > R32 and an imm src operand, what is being added? This looks more like a > move to me. And in the second example you are trying to force simm16:$I'm > to i32? > > -Ryan > > On Tue, Aug 30, 2016 at 1:21 PM, Bhatu via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > >> Hi all, >> >> I want to match addition with 16bit integers. So I define a pattern >> fragment as follows: >> def simm16 : PatLeaf<(imm), [{ return isInt<16>(N->getSExtValue()); }]>; >> >> Now I am confused between >> (add R32:$dst, simm16:$im) and >> (add R32:$dst, (i32 simm16:$im)). >> >> Do both of them match the same pattern? Are they equivalent? If not what >> is the difference? >> I am also confused as to how ValueTypes relate to SDNodes as I think we >> are able to use both of them as nodes. >> >> -- >> Regards >> Pratik Bhatu >> Dual Degree(B.Tech + M.Tech), 5th Year >> Computer Science and Engineering >> IIT Hyderabad >> >> _______________________________________________ >> LLVM Developers mailing list >> llvm-dev at lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >> >> > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160830/61319294/attachment.html>