Rafael Espíndola via llvm-dev
2016-Aug-26 16:19 UTC
[llvm-dev] [XRay][RFC] Tooling for XRay Trace Analysis
On 26 August 2016 at 11:40, Mehdi Amini <mehdi.amini at apple.com> wrote:> The lack of possibility of code sharing makes me sad :( > > CC: Rafael who has an outstanding patch to share code between LLVM and compiler-rt (demangler), which can be a future concern with the licensing difference Chris mentioned.I think the demangler patch is fine since it is copying code from libcxx-abi to llvm, so all code in there was OKed to be dual licensed. Cheers, Rafael
Mehdi Amini via llvm-dev
2016-Aug-26 16:42 UTC
[llvm-dev] [XRay][RFC] Tooling for XRay Trace Analysis
> On Aug 26, 2016, at 9:19 AM, Rafael Espíndola <rafael.espindola at gmail.com> wrote: > > On 26 August 2016 at 11:40, Mehdi Amini <mehdi.amini at apple.com> wrote: >> The lack of possibility of code sharing makes me sad :( >> >> CC: Rafael who has an outstanding patch to share code between LLVM and compiler-rt (demangler), which can be a future concern with the licensing difference Chris mentioned. > > > I think the demangler patch is fine since it is copying code from > libcxx-abi to llvm, so all code in there was OKed to be dual licensed.It is fine as is, but if someone contributes to the demangler in LLVM, one can’t take his patch and “backport” as-is to compiler-rt. — Mehdi
Rafael Espíndola via llvm-dev
2016-Aug-26 20:31 UTC
[llvm-dev] [XRay][RFC] Tooling for XRay Trace Analysis
On 26 August 2016 at 12:42, Mehdi Amini <mehdi.amini at apple.com> wrote:> >> On Aug 26, 2016, at 9:19 AM, Rafael Espíndola <rafael.espindola at gmail.com> wrote: >> >> On 26 August 2016 at 11:40, Mehdi Amini <mehdi.amini at apple.com> wrote: >>> The lack of possibility of code sharing makes me sad :( >>> >>> CC: Rafael who has an outstanding patch to share code between LLVM and compiler-rt (demangler), which can be a future concern with the licensing difference Chris mentioned. >> >> >> I think the demangler patch is fine since it is copying code from >> libcxx-abi to llvm, so all code in there was OKed to be dual licensed. > > It is fine as is, but if someone contributes to the demangler in LLVM, one can’t take his patch and “backport” as-is to compiler-rt.Yes, it has to go to compiler-rt first. Cheers, Rafael