llvm dev - Aug 2016 - [PATCH] Obsolete WebKit Calling Convention

Hi @ll,

I would like to obsolete and completely remove the WebKit Calling Convention.
The CC was originally added for FTL and there are no other users I am aware off.
Since WebKit moved away from LLVM a while ago I don’t see the need to keep the
dead code around anymore.

Please let me know if anyone happens to use this calling convention or has any
objection with removing it.

Thanks

Cheers,
Juergen

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Obsolete-WebKit-Calling-Convention.patch
Type: application/octet-stream
Size: 33650 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20160823/53d5fcd6/attachment-0001.obj>
-------------- next part --------------

Makes sense to me.

Watch out for the binary bitcode compatibility files for 3.{6,7,8}. We should
be able to rewrite 'webkit_jscc' to 'cc<n>', and should
update the calling
convention enums to make sure that that <n> isn't reused.

vedant
> On Aug 23, 2016, at 9:49 AM, Juergen Ributzka via llvm-dev <llvm-dev at
lists.llvm.org> wrote:
> 
> Hi @ll,
> 
> I would like to obsolete and completely remove the WebKit Calling
Convention. The CC was originally added for FTL and there are no other users I
am aware off. Since WebKit moved away from LLVM a while ago I don’t see the need
to keep the dead code around anymore.
> 
> Please let me know if anyone happens to use this calling convention or has
any objection with removing it.
> 
> Thanks
> 
> Cheers,
> Juergen
> 
> <0001-Obsolete-WebKit-Calling-Convention.patch>
> 
> 
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

> On Aug 23, 2016, at 11:34 AM, Vedant Kumar via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> 
> Makes sense to me.
I am not aware of any webkit calling convention users either.
> 
> Watch out for the binary bitcode compatibility files for 3.{6,7,8}. We
should
> be able to rewrite 'webkit_jscc' to 'cc<n>', and
should update the calling
> convention enums to make sure that that <n> isn't reused.
If possible I'd rather abort with an error message than rewriting to the
wrong calling convention.

- Matthias

SGTM.

-eric

On Tue, Aug 23, 2016 at 9:49 AM Juergen Ributzka via llvm-commits <
llvm-commits at lists.llvm.org> wrote:
> Hi @ll,
>
> I would like to obsolete and completely remove the WebKit Calling
> Convention. The CC was originally added for FTL and there are no other
> users I am aware off. Since WebKit moved away from LLVM a while ago I don’t
> see the need to keep the dead code around anymore.
>
> Please let me know if anyone happens to use this calling convention or has
> any objection with removing it.
>
> Thanks
>
> Cheers,
> Juergen
>
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20160823/ade7dd01/attachment.html>

SGTM

On 08/23/2016 09:49 AM, Juergen Ributzka via llvm-dev
wrote:
> Hi @ll,
>
> I would like to obsolete and completely remove the WebKit Calling
Convention. The CC was originally added for FTL and there are no other users I
am aware off. Since WebKit moved away from LLVM a while ago I don’t see the need
to keep the dead code around anymore.
>
> Please let me know if anyone happens to use this calling convention or has
any objection with removing it.
>
> Thanks
>
> Cheers,
> Juergen
>
>
>
>
>
>
>
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20160823/f8d00f86/attachment.html>