Thanks for noticing this, Geoff. I just landed r268050 which add a cmake option for this (and unifies XDEBUG and EXPENSIVE_CHECKS). This might make it easier to setup some build bots. Thank you, Filipe On Fri, Apr 22, 2016 at 8:40 PM, Geoff Berry via llvm-dev < llvm-dev at lists.llvm.org> wrote:> Bugs filed: > 27488 <https://llvm.org/bugs/show_bug.cgi?id=27488> librarie Scalar O > unassignedbugs at nondot.org NEW --- [StructurizeCFG] lit test hits assert > in verifyDomTree when compiled w/ XDEBUG > <https://llvm.org/bugs/show_bug.cgi?id=27488> 14:34:06 > 27487 <https://llvm.org/bugs/show_bug.cgi?id=27487> librarie Scalar O > unassignedbugs at nondot.org NEW --- [LoopVersioning] lit test hits invalid > domtree assert w/ XDEBUG <https://llvm.org/bugs/show_bug.cgi?id=27487> > 14:31:56 > 27486 <https://llvm.org/bugs/show_bug.cgi?id=27486> librarie Scalar O > unassignedbugs at nondot.org NEW --- [InductiveRangeCheckElimination] > invalidates domtree and hits asserts w/ XDEBUG > <https://llvm.org/bugs/show_bug.cgi?id=27486> 14:29:00 > 27485 <https://llvm.org/bugs/show_bug.cgi?id=27485> librarie Backend: > unassignedbugs at nondot.org NEW --- [X86] Codegen/X86/selectiondag-cse.ll > hits assert when LLVM compiled with XDEBUG > <https://llvm.org/bugs/show_bug.cgi?id=27485> 14:13:03 > 27483 <https://llvm.org/bugs/show_bug.cgi?id=27483> librarie Common C > unassignedbugs at nondot.org NEW --- [SelectionDAG] LegalizeTypes hits > asserts in PerformExpensiveChecks when compiled with XDEBUG > <https://llvm.org/bugs/show_bug.cgi?id=27483> 14:12:59 > 27484 <https://llvm.org/bugs/show_bug.cgi?id=27484> librarie Backend: > unassignedbugs at nondot.org NEW --- [ARM] Codegen/Thumb/segmented-stacks.ll > hits assert when llvm compiled w/ XDEBUG > <https://llvm.org/bugs/show_bug.cgi?id=27484> > > On 4/22/2016 12:11 PM, Geoff Berry via llvm-dev wrote: > > Yeah, they are just triggered by lit check tests. I’ll file some bugs > today, though it looks like Quentin may have already filed bugs for some of > these. > > > > -- > > Geoff Berry > > Employee of Qualcomm Innovation Center, Inc. > > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux > Foundation Collaborative Project > > > > *From:* Daniel Berlin [mailto:dberlin at dberlin.org <dberlin at dberlin.org>] > *Sent:* Friday, April 22, 2016 12:05 PM > *To:* Geoff Berry <gberry at codeaurora.org> <gberry at codeaurora.org> > *Cc:* llvm-dev <llvm-dev at lists.llvm.org> <llvm-dev at lists.llvm.org> > *Subject:* Re: [llvm-dev] XDEBUG build bots? > > > > > > > > On Thu, Apr 21, 2016 at 1:18 PM, Geoff Berry via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > > Hi All, > > Are there any bots that do any testing with clang/llvm built with XDEBUG > (i.e. expensive checking)? I'm seeing 36 lit tests that currently hit > asserts that are checked when XDEBUG is enabled. The checks that I'm > hitting are: > - DominatorTree::verifyDomTree() > > > > This seems super bad ;) > > Have a testcase? > > > > > _______________________________________________ > LLVM Developers mailing listllvm-dev at lists.llvm.orghttp://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev > > > -- > Geoff Berry > Employee of Qualcomm Innovation Center, Inc. > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project > > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160429/e8843089/attachment.html>
Would it make sense to include -verify-machineinstrs into XDEBUG ad well?> On Apr 29, 2016, at 8:36 AM, Filipe Cabecinhas via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > Thanks for noticing this, Geoff. > > I just landed r268050 which add a cmake option for this (and unifies XDEBUG and EXPENSIVE_CHECKS). This might make it easier to setup some build bots. > > Thank you, > > Filipe > >> On Fri, Apr 22, 2016 at 8:40 PM, Geoff Berry via llvm-dev <llvm-dev at lists.llvm.org> wrote: >> Bugs filed: >> >> 27488 librarie Scalar O unassignedbugs at nondot.org NEW --- [StructurizeCFG] lit test hits assert in verifyDomTree when compiled w/ XDEBUG 14:34:06 >> 27487 librarie Scalar O unassignedbugs at nondot.org NEW --- [LoopVersioning] lit test hits invalid domtree assert w/ XDEBUG 14:31:56 >> 27486 librarie Scalar O unassignedbugs at nondot.org NEW --- [InductiveRangeCheckElimination] invalidates domtree and hits asserts w/ XDEBUG 14:29:00 >> 27485 librarie Backend: unassignedbugs at nondot.org NEW --- [X86] Codegen/X86/selectiondag-cse.ll hits assert when LLVM compiled with XDEBUG 14:13:03 >> 27483 librarie Common C unassignedbugs at nondot.org NEW --- [SelectionDAG] LegalizeTypes hits asserts in PerformExpensiveChecks when compiled with XDEBUG 14:12:59 >> 27484 librarie Backend: unassignedbugs at nondot.org NEW --- [ARM] Codegen/Thumb/segmented-stacks.ll hits assert when llvm compiled w/ XDEBUG >> >>> On 4/22/2016 12:11 PM, Geoff Berry via llvm-dev wrote: >>> Yeah, they are just triggered by lit check tests. I’ll file some bugs today, though it looks like Quentin may have already filed bugs for some of these. >>> >>> >>> >>> -- >>> >>> Geoff Berry >>> >>> Employee of Qualcomm Innovation Center, Inc. >>> >>> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project >>> >>> >>> >>> From: Daniel Berlin [mailto:dberlin at dberlin.org] >>> Sent: Friday, April 22, 2016 12:05 PM >>> To: Geoff Berry <gberry at codeaurora.org> >>> Cc: llvm-dev <llvm-dev at lists.llvm.org> >>> Subject: Re: [llvm-dev] XDEBUG build bots? >>> >>> >>> >>> >>> >>> >>> >>> On Thu, Apr 21, 2016 at 1:18 PM, Geoff Berry via llvm-dev <llvm-dev at lists.llvm.org> wrote: >>> >>> Hi All, >>> >>> Are there any bots that do any testing with clang/llvm built with XDEBUG >>> (i.e. expensive checking)? I'm seeing 36 lit tests that currently hit >>> asserts that are checked when XDEBUG is enabled. The checks that I'm >>> hitting are: >>> - DominatorTree::verifyDomTree() >>> >>> >>> >>> This seems super bad ;) >>> >>> Have a testcase? >>> >>> >>> >>> >>> >>> _______________________________________________ >>> LLVM Developers mailing list >>> llvm-dev at lists.llvm.org >>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >> >> -- >> Geoff Berry >> Employee of Qualcomm Innovation Center, Inc. >> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project >> >> _______________________________________________ >> LLVM Developers mailing list >> llvm-dev at lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160429/b238d8ad/attachment.html>
I had a patch at some point that added a feature to lit that would *always* add the -verify-machineinstrs (unless disabled explicitely). Test that wouldn't pass were marked something like "XFAIL: verifymachineinstrs", but it would prevent from adding new failing tests and we could move towards a totally verifier-clean suite. -- Mehdi> On Apr 29, 2016, at 6:42 PM, Matthias Braun via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > Would it make sense to include -verify-machineinstrs into XDEBUG ad well? > > On Apr 29, 2016, at 8:36 AM, Filipe Cabecinhas via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote: > >> Thanks for noticing this, Geoff. >> >> I just landed r268050 which add a cmake option for this (and unifies XDEBUG and EXPENSIVE_CHECKS). This might make it easier to setup some build bots. >> >> Thank you, >> >> Filipe >> >> On Fri, Apr 22, 2016 at 8:40 PM, Geoff Berry via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote: >> Bugs filed: >> >> 27488 <https://llvm.org/bugs/show_bug.cgi?id=27488> librarie Scalar O unassignedbugs at nondot.org <mailto:unassignedbugs at nondot.org> NEW --- [StructurizeCFG] lit test hits assert in verifyDomTree when compiled w/ XDEBUG <https://llvm.org/bugs/show_bug.cgi?id=27488> 14:34:06 >> 27487 <https://llvm.org/bugs/show_bug.cgi?id=27487> librarie Scalar O unassignedbugs at nondot.org <mailto:unassignedbugs at nondot.org> NEW --- [LoopVersioning] lit test hits invalid domtree assert w/ XDEBUG <https://llvm.org/bugs/show_bug.cgi?id=27487> 14:31:56 >> 27486 <https://llvm.org/bugs/show_bug.cgi?id=27486> librarie Scalar O unassignedbugs at nondot.org <mailto:unassignedbugs at nondot.org> NEW --- [InductiveRangeCheckElimination] invalidates domtree and hits asserts w/ XDEBUG <https://llvm.org/bugs/show_bug.cgi?id=27486> 14:29:00 >> 27485 <https://llvm.org/bugs/show_bug.cgi?id=27485> librarie Backend: unassignedbugs at nondot.org <mailto:unassignedbugs at nondot.org> NEW --- [X86] Codegen/X86/selectiondag-cse.ll hits assert when LLVM compiled with XDEBUG <https://llvm.org/bugs/show_bug.cgi?id=27485> 14:13:03 >> 27483 <https://llvm.org/bugs/show_bug.cgi?id=27483> librarie Common C unassignedbugs at nondot.org <mailto:unassignedbugs at nondot.org> NEW --- [SelectionDAG] LegalizeTypes hits asserts in PerformExpensiveChecks when compiled with XDEBUG <https://llvm.org/bugs/show_bug.cgi?id=27483> 14:12:59 >> 27484 <https://llvm.org/bugs/show_bug.cgi?id=27484> librarie Backend: unassignedbugs at nondot.org <mailto:unassignedbugs at nondot.org> NEW --- [ARM] Codegen/Thumb/segmented-stacks.ll hits assert when llvm compiled w/ XDEBUG <https://llvm.org/bugs/show_bug.cgi?id=27484> >> >> On 4/22/2016 12:11 PM, Geoff Berry via llvm-dev wrote: >>> Yeah, they are just triggered by lit check tests. I’ll file some bugs today, though it looks like Quentin may have already filed bugs for some of these. >>> >>> >>> >>> -- >>> >>> Geoff Berry >>> >>> Employee of Qualcomm Innovation Center, Inc. >>> >>> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project >>> >>> >>> >>> From: Daniel Berlin [mailto:dberlin at dberlin.org <mailto:dberlin at dberlin.org>] >>> Sent: Friday, April 22, 2016 12:05 PM >>> To: Geoff Berry <gberry at codeaurora.org> <mailto:gberry at codeaurora.org> >>> Cc: llvm-dev <llvm-dev at lists.llvm.org> <mailto:llvm-dev at lists.llvm.org> >>> Subject: Re: [llvm-dev] XDEBUG build bots? >>> >>> >>> >>> >>> >>> >>> >>> On Thu, Apr 21, 2016 at 1:18 PM, Geoff Berry via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote: >>> >>> Hi All, >>> >>> Are there any bots that do any testing with clang/llvm built with XDEBUG >>> (i.e. expensive checking)? I'm seeing 36 lit tests that currently hit >>> asserts that are checked when XDEBUG is enabled. The checks that I'm >>> hitting are: >>> - DominatorTree::verifyDomTree() >>> >>> >>> >>> This seems super bad ;) >>> >>> Have a testcase? >>> >>> >>> >>> >>> >>> _______________________________________________ >>> LLVM Developers mailing list >>> llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org> >>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev> >> >> -- >> Geoff Berry >> Employee of Qualcomm Innovation Center, Inc. >> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project >> >> _______________________________________________ >> LLVM Developers mailing list >> llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org> >> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev> >> >> >> _______________________________________________ >> LLVM Developers mailing list >> llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org> >> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev> > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160502/c7ddfc31/attachment-0001.html>