llvm dev - Jan 2016 - Is MCRelocationInfo::createExprForRelocation used out of tree?

Hi all

The virtual method MCRelocationInfo::createExprForRelocation doesn’t appear to
have any callers.  Is anyone using it out of tree?

In tree, its overridden in X86ELFRelocationInfo.cpp and
X86MachORelocationInfo.cpp, but those overrides have 0% coverage
(http://llvm.org/reports/coverage/lib/Target/X86/MCTargetDesc/X86MachORelocationInfo.cpp.gcov.html)

I’d like to delete these methods and files, assuming they aren’t somehow in use
out of tree.

Thoughts?

Thanks,
Pete

Hi Jim, Rafael

As respective code owner and frequent committer to MC, any thoughts on this?

Cheers,
Pete
> On Jan 12, 2016, at 1:07 PM, Pete Cooper <peter_cooper at apple.com>
wrote:
> 
> Hi all
> 
> The virtual method MCRelocationInfo::createExprForRelocation doesn’t appear
to have any callers.  Is anyone using it out of tree?
> 
> In tree, its overridden in X86ELFRelocationInfo.cpp and
X86MachORelocationInfo.cpp, but those overrides have 0% coverage
(http://llvm.org/reports/coverage/lib/Target/X86/MCTargetDesc/X86MachORelocationInfo.cpp.gcov.html)
> 
> I’d like to delete these methods and files, assuming they aren’t somehow in
use out of tree.
> 
> Thoughts?
> 
> Thanks,
> Pete

Deleting LGTM. It is a leftover of MCAnalysis.

Cheers,
Rafael


On 14 January 2016 at 16:54, Pete Cooper <peter_cooper at apple.com>
wrote:
> Hi Jim, Rafael
>
> As respective code owner and frequent committer to MC, any thoughts on
this?
>
> Cheers,
> Pete
>> On Jan 12, 2016, at 1:07 PM, Pete Cooper <peter_cooper at
apple.com> wrote:
>>
>> Hi all
>>
>> The virtual method MCRelocationInfo::createExprForRelocation doesn’t
appear to have any callers.  Is anyone using it out of tree?
>>
>> In tree, its overridden in X86ELFRelocationInfo.cpp and
X86MachORelocationInfo.cpp, but those overrides have 0% coverage
(http://llvm.org/reports/coverage/lib/Target/X86/MCTargetDesc/X86MachORelocationInfo.cpp.gcov.html)
>>
>> I’d like to delete these methods and files, assuming they aren’t
somehow in use out of tree.
>>
>> Thoughts?
>>
>> Thanks,
>> Pete
>