llvm dev - Apr 2015 - [LLVMdev] [lld] Linker cannot handle sections with non-unique names

On Mon, Apr 20, 2015 at 1:44 AM, Shankar Easwaran <shankarke at gmail.com>
wrote:
> Attached patch fixes the issue.
Thanks for the quick fix. The patch LGTM if you add a test case.
Unfortunately yaml2obj does not support duplicated section names but
we can use a binary input file.

-- 
Simon Atanasyan

I plan to add a test case but couldn't add because of yaml2obj support. I am
adding that support to yaml2obj and obj2yaml and push this patch later. I
don't like the idea of adding binary files to the test repo as we need to
keep cleaning up later.


> On Apr 20, 2015, at 03:34, Simon Atanasyan <simon at atanasyan.com>
wrote:
> 
>> On Mon, Apr 20, 2015 at 1:44 AM, Shankar Easwaran <shankarke at
gmail.com> wrote:
>> Attached patch fixes the issue.
> 
> Thanks for the quick fix. The patch LGTM if you add a test case.
> Unfortunately yaml2obj does not support duplicated section names but
> we can use a binary input file.
> 
> -- 
> Simon Atanasyan

On 20 April 2015 at 10:59, Shankar Easwaram <shankarke at gmail.com>
wrote:
> I plan to add a test case but couldn't add because of yaml2obj support.
I am adding that support to yaml2obj and obj2yaml and push this patch later. I
don't like the idea of adding binary files to the test repo as we need to
keep cleaning up later.
IMHO checking in a binary would actually be better.

Binaries are the input to the linker. What is desired in here is to
test that lld can work with a binary produced by a current clang. That
should still be the case in 1 year, even if what clang is producing is
different. Using yaml2obj just makes that connection more tenuous.

Cheers,
Rafael

On Mon, Apr 20, 2015 at 7:59 AM, Shankar Easwaram <shankarke at gmail.com>
wrote:
> I plan to add a test case but couldn't add because of yaml2obj support.
I
> am adding that support to yaml2obj and obj2yaml and push this patch later.
> I don't like the idea of adding binary files to the test repo as we
need to
> keep cleaning up later.
>
Please make sure to pre-commit review this. I expect a bikeshed over the
syntax.

-- Sean Silva

>
>
>
> > On Apr 20, 2015, at 03:34, Simon Atanasyan <simon at
atanasyan.com> wrote:
> >
> >> On Mon, Apr 20, 2015 at 1:44 AM, Shankar Easwaran <shankarke at
gmail.com>
> wrote:
> >> Attached patch fixes the issue.
> >
> > Thanks for the quick fix. The patch LGTM if you add a test case.
> > Unfortunately yaml2obj does not support duplicated section names but
> > we can use a binary input file.
> >
> > --
> > Simon Atanasyan
>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20150420/0cbb7ff8/attachment.html>

Nothing wrong with going ahead with a temporary measure if the temporary
measure is reasonable (besides the discussion if checking in binary files
is desirable). Even if you plan to add a test written in YAML, it's better
to check in a binary at least for now than checking it in without any tests.

On Mon, Apr 20, 2015 at 7:59 AM, Shankar Easwaram <shankarke at gmail.com>
wrote:
> I plan to add a test case but couldn't add because of yaml2obj support.
I
> am adding that support to yaml2obj and obj2yaml and push this patch later.
> I don't like the idea of adding binary files to the test repo as we
need to
> keep cleaning up later.
>
>
>
> > On Apr 20, 2015, at 03:34, Simon Atanasyan <simon at
atanasyan.com> wrote:
> >
> >> On Mon, Apr 20, 2015 at 1:44 AM, Shankar Easwaran <shankarke at
gmail.com>
> wrote:
> >> Attached patch fixes the issue.
> >
> > Thanks for the quick fix. The patch LGTM if you add a test case.
> > Unfortunately yaml2obj does not support duplicated section names but
> > we can use a binary input file.
> >
> > --
> > Simon Atanasyan
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20150420/f9f2eb0a/attachment.html>