> On Mar 10, 2015, at 1:03 AM, Vassil Vassilev <vvasilev at cern.ch> wrote: > > On 09/03/15 21:52, Anna Zaks wrote: >> >> +Easily, some of the code snippets end up being copied dozens of >> +times, which leads to worse maintainability, understandability and logical >> +design. > Should be better now. >> >> The project description stresses code maintainability and logical design more than bug finding due to omissions in copy and pasted code. Reading this made me think of a check that would suggest people to replace copy and pasted code with a function call or something like that... Examples do stress the specific bugs that could be found, which is what I had in mind: >> >> + Copy-paste infrastructure could be used to build other "goodies". Some >> +examples and possible applications are: >> >> Is this intentional? If not, maybe we could rephrase a bit with more emphasis on bug finding. I would also make it a requirement to use the infrastructure for bug detection. > Well, partially yes, I wanted to have the project description as broad as possible so that interested students to specialized in a direction, in which they are most comfortable. Because IMO the project is bigger than 1 usual GSoC project. > I rephrased it to make it more focused towards bugs. Could you elaborate on the "I would also make it a requirement to use the infrastructure for bug detection.", please?I would prefer not to have pure infrastructure, but rather develop infrastructure along with uses of it. Bug finding is one such use. That would allow to set clear goals for the students and allow for better qualification of the infrastructure. (However, I see your point about making it open to students that are interested in using this infrastructure for other projects.)> > BTW, please feel free to submit a patch to the patch (:)), if you think something else requires fixing or better wording. >> >> Thanks for driving this! > Sure, thank you for reviewing! > Vassil >> Anna. >> >>> On Mar 9, 2015, at 1:54 AM, Vassil Vassilev <vvasilev at cern.ch <mailto:vvasilev at cern.ch>> wrote: >>> >>> Hi Anton, >>> (CC-ing the people who might be interested to review) >>> I am attaching the patch. >>> Many thanks, >>> Vassil >>> On 04/03/15 23:00, Anton Korobeynikov wrote: >>>> Please provide a patch to Open Projects list. >>>> >>>> On Wed, Mar 4, 2015 at 8:25 PM, Vassil Vassilev <vvasilev at cern.ch <mailto:vvasilev at cern.ch>> wrote: >>>>> On 17/02/15 09:47, Anton Korobeynikov wrote: >>>>>> John, >>>>>> >>>>>> Yes, I'm taking care about application as usual. >>>>> I saw the the LLVM mentoring org was accepted. Congrats! >>>>> Anton, could you tell me what is the procedure of submitting a proposal for >>>>> a project (I will be the mentor)? >>>>> Many thanks, >>>>> Vassil >>>>> >>>>>> On Tue, Feb 17, 2015 at 4:48 AM, Eric Christopher <echristo at gmail.com <mailto:echristo at gmail.com>> >>>>>> wrote: >>>>>>> I believe Anton was going to do so. >>>>>>> >>>>>>> >>>>>>> On Mon, Feb 16, 2015, 5:14 PM John Criswell <jtcriswel at gmail.com <mailto:jtcriswel at gmail.com>> wrote: >>>>>>>> Dear All, >>>>>>>> >>>>>>>> Has someone registered LLVM as an organization for Google Summer of Code >>>>>>>> 2015? I'm interested in mentoring a GSoC student this summer. >>>>>>>> >>>>>>>> -- John T. >>>>>>>> >>>>>>>> -- >>>>>>>> John Criswell >>>>>>>> Assistant Professor >>>>>>>> Department of Computer Science, University of Rochester >>>>>>>> http://www.cs.rochester.edu/u/criswell <http://www.cs.rochester.edu/u/criswell> >>>>>>>> >>>>>>>> _______________________________________________ >>>>>>>> LLVM Developers mailing list >>>>>>>> LLVMdev at cs.uiuc.edu <mailto:LLVMdev at cs.uiuc.edu> http://llvm.cs.uiuc.edu <http://llvm.cs.uiuc.edu/> >>>>>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev <http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev> >>>>> >>>> >>>> >>> >>> >>> -- >>> -------------------------------------------- >>> Q: Why is this email five sentences or less? >>> A: http://five.sentenc.es <http://five.sentenc.es/> >>> >>> <CopyPasteDetectorGSoC15.diff> >> > > <CopyPasteDetectorGSoC15_v2.diff>-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150310/7feb83f2/attachment.html>
On 10/03/15 19:13, Anna Zaks wrote:> >> On Mar 10, 2015, at 1:03 AM, Vassil Vassilev <vvasilev at cern.ch >> <mailto:vvasilev at cern.ch>> wrote: >> >> On 09/03/15 21:52, Anna Zaks wrote: >>> >>> +Easily, some of the code snippets end up being copied dozens of >>> +times, which leads to worse maintainability, understandability and >>> logical >>> +design. >> Should be better now. >>> >>> The project description stresses code maintainability and logical >>> design more than bug finding due to omissions in copy and pasted >>> code. Reading this made me think of a check that would suggest >>> people to replace copy and pasted code with a function call or >>> something like that... Examples do stress the specific bugs that >>> could be found, which is what I had in mind: >>> >>> + Copy-paste infrastructure could be used to build other >>> "goodies". Some >>> +examples and possible applications are: >>> >>> Is this intentional? If not, maybe we could rephrase a bit with more >>> emphasis on bug finding. I would also make it a requirement to use >>> the infrastructure for bug detection. >> Well, partially yes, I wanted to have the project description as >> broad as possible so that interested students to specialized in a >> direction, in which they are most comfortable. Because IMO the >> project is bigger than 1 usual GSoC project. >> I rephrased it to make it more focused towards bugs. Could you >> elaborate on the "I would also make it a requirement to use the >> infrastructure for bug detection.", please? > > I would prefer not to have pure infrastructure, but rather develop > infrastructure along with uses of it. Bug finding is one such use. > That would allow to set clear goals for the students and allow for > better qualification of the infrastructure.I see your point and I agree. I really want the proposal up soon. Can we discuss that in IRC, I think it would be easier for me? My nickname is vvassilev. Many thanks, Vassil> > (However, I see your point about making it open to students that are > interested in using this infrastructure for other projects.) > >> >> BTW, please feel free to submit a patch to the patch (:)), if you >> think something else requires fixing or better wording. >>> >>> Thanks for driving this! >> Sure, thank you for reviewing! >> Vassil >>> Anna. >>> >>>> On Mar 9, 2015, at 1:54 AM, Vassil Vassilev <vvasilev at cern.ch >>>> <mailto:vvasilev at cern.ch>> wrote: >>>> >>>> Hi Anton, >>>> (CC-ing the people who might be interested to review) >>>> I am attaching the patch. >>>> Many thanks, >>>> Vassil >>>> On 04/03/15 23:00, Anton Korobeynikov wrote: >>>>> Please provide a patch to Open Projects list. >>>>> >>>>> On Wed, Mar 4, 2015 at 8:25 PM, Vassil Vassilev <vvasilev at cern.ch >>>>> <mailto:vvasilev at cern.ch>> wrote: >>>>>> On 17/02/15 09:47, Anton Korobeynikov wrote: >>>>>>> John, >>>>>>> >>>>>>> Yes, I'm taking care about application as usual. >>>>>> I saw the the LLVM mentoring org was accepted. Congrats! >>>>>> Anton, could you tell me what is the procedure of submitting a >>>>>> proposal for >>>>>> a project (I will be the mentor)? >>>>>> Many thanks, >>>>>> Vassil >>>>>> >>>>>>> On Tue, Feb 17, 2015 at 4:48 AM, Eric Christopher >>>>>>> <echristo at gmail.com <mailto:echristo at gmail.com>> >>>>>>> wrote: >>>>>>>> I believe Anton was going to do so. >>>>>>>> >>>>>>>> >>>>>>>> On Mon, Feb 16, 2015, 5:14 PM John Criswell >>>>>>>> <jtcriswel at gmail.com <mailto:jtcriswel at gmail.com>> wrote: >>>>>>>>> Dear All, >>>>>>>>> >>>>>>>>> Has someone registered LLVM as an organization for Google >>>>>>>>> Summer of Code >>>>>>>>> 2015? I'm interested in mentoring a GSoC student this summer. >>>>>>>>> >>>>>>>>> -- John T. >>>>>>>>> >>>>>>>>> -- >>>>>>>>> John Criswell >>>>>>>>> Assistant Professor >>>>>>>>> Department of Computer Science, University of Rochester >>>>>>>>> http://www.cs.rochester.edu/u/criswell >>>>>>>>> >>>>>>>>> _______________________________________________ >>>>>>>>> LLVM Developers mailing list >>>>>>>>> LLVMdev at cs.uiuc.eduhttp://llvm.cs.uiuc.edu >>>>>>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >>>>>> >>>>> >>>>> >>>> >>>> >>>> -- >>>> -------------------------------------------- >>>> Q: Why is this email five sentences or less? >>>> A:http://five.sentenc.es <http://five.sentenc.es/> >>>> >>>> <CopyPasteDetectorGSoC15.diff> >>> >> >> <CopyPasteDetectorGSoC15_v2.diff> >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150311/265a8638/attachment.html>
> On Mar 11, 2015, at 2:14 AM, Vassil Vassilev <vvasilev at cern.ch> wrote: > > On 10/03/15 19:13, Anna Zaks wrote: >> >>> On Mar 10, 2015, at 1:03 AM, Vassil Vassilev <vvasilev at cern.ch <mailto:vvasilev at cern.ch>> wrote: >>> >>> On 09/03/15 21:52, Anna Zaks wrote: >>>> >>>> +Easily, some of the code snippets end up being copied dozens of >>>> +times, which leads to worse maintainability, understandability and logical >>>> +design. >>> Should be better now. >>>> >>>> The project description stresses code maintainability and logical design more than bug finding due to omissions in copy and pasted code. Reading this made me think of a check that would suggest people to replace copy and pasted code with a function call or something like that... Examples do stress the specific bugs that could be found, which is what I had in mind: >>>> >>>> + Copy-paste infrastructure could be used to build other "goodies". Some >>>> +examples and possible applications are: >>>> >>>> Is this intentional? If not, maybe we could rephrase a bit with more emphasis on bug finding. I would also make it a requirement to use the infrastructure for bug detection. >>> Well, partially yes, I wanted to have the project description as broad as possible so that interested students to specialized in a direction, in which they are most comfortable. Because IMO the project is bigger than 1 usual GSoC project. >>> I rephrased it to make it more focused towards bugs. Could you elaborate on the "I would also make it a requirement to use the infrastructure for bug detection.", please? >> >> I would prefer not to have pure infrastructure, but rather develop infrastructure along with uses of it. Bug finding is one such use. That would allow to set clear goals for the students and allow for better qualification of the infrastructure. > I see your point and I agree. I really want the proposal up soon. Can we discuss that in IRC, I think it would be easier for me? My nickname is vvassilev.I am not going to be online in the next couple of hours. I would just rewrite this a bit to make it clear that we expect some useful features being developed along with the copy and paste detection with bug finding as an example. Writing those features would be part of the project. If a student is interested in a feature other than bug finding, I’d expect them to specify what that is when they apply. (As far as I recall, the students also write proposals. I am not sure what is the workflow when they reply to our proposal.) I think the proposal is generally good. I’d just emphasize feature driven development in the goals. Anna.> Many thanks, > Vassil >> >> (However, I see your point about making it open to students that are interested in using this infrastructure for other projects.) >> >>> >>> BTW, please feel free to submit a patch to the patch (:)), if you think something else requires fixing or better wording. >>>> >>>> Thanks for driving this! >>> Sure, thank you for reviewing! >>> Vassil >>>> Anna. >>>> >>>>> On Mar 9, 2015, at 1:54 AM, Vassil Vassilev <vvasilev at cern.ch <mailto:vvasilev at cern.ch>> wrote: >>>>> >>>>> Hi Anton, >>>>> (CC-ing the people who might be interested to review) >>>>> I am attaching the patch. >>>>> Many thanks, >>>>> Vassil >>>>> On 04/03/15 23:00, Anton Korobeynikov wrote: >>>>>> Please provide a patch to Open Projects list. >>>>>> >>>>>> On Wed, Mar 4, 2015 at 8:25 PM, Vassil Vassilev <vvasilev at cern.ch <mailto:vvasilev at cern.ch>> wrote: >>>>>>> On 17/02/15 09:47, Anton Korobeynikov wrote: >>>>>>>> John, >>>>>>>> >>>>>>>> Yes, I'm taking care about application as usual. >>>>>>> I saw the the LLVM mentoring org was accepted. Congrats! >>>>>>> Anton, could you tell me what is the procedure of submitting a proposal for >>>>>>> a project (I will be the mentor)? >>>>>>> Many thanks, >>>>>>> Vassil >>>>>>> >>>>>>>> On Tue, Feb 17, 2015 at 4:48 AM, Eric Christopher <echristo at gmail.com <mailto:echristo at gmail.com>> >>>>>>>> wrote: >>>>>>>>> I believe Anton was going to do so. >>>>>>>>> >>>>>>>>> >>>>>>>>> On Mon, Feb 16, 2015, 5:14 PM John Criswell <jtcriswel at gmail.com <mailto:jtcriswel at gmail.com>> wrote: >>>>>>>>>> Dear All, >>>>>>>>>> >>>>>>>>>> Has someone registered LLVM as an organization for Google Summer of Code >>>>>>>>>> 2015? I'm interested in mentoring a GSoC student this summer. >>>>>>>>>> >>>>>>>>>> -- John T. >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> John Criswell >>>>>>>>>> Assistant Professor >>>>>>>>>> Department of Computer Science, University of Rochester >>>>>>>>>> http://www.cs.rochester.edu/u/criswell <http://www.cs.rochester.edu/u/criswell> >>>>>>>>>> >>>>>>>>>> _______________________________________________ >>>>>>>>>> LLVM Developers mailing list >>>>>>>>>> LLVMdev at cs.uiuc.edu <mailto:LLVMdev at cs.uiuc.edu> http://llvm.cs.uiuc.edu <http://llvm.cs.uiuc.edu/> >>>>>>>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev <http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev> >>>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> -------------------------------------------- >>>>> Q: Why is this email five sentences or less? >>>>> A: http://five.sentenc.es <http://five.sentenc.es/> >>>>> >>>>> <CopyPasteDetectorGSoC15.diff> >>>> >>> >>> <CopyPasteDetectorGSoC15_v2.diff> >> >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150311/024ab2b7/attachment.html>