Alan Garny
2015-Mar-10 16:52 UTC
[LLVMdev] LLVM 3.6: problems building on Windows using MSVC 2013
No, I am currently using MSVC 2013 Update 3. Why? Is there something I should (have) know(n)? Alan From: Zachary Turner [mailto:zturner at google.com] Sent: 10 March 2015 17:40 To: Alan Garny; llvmdev Subject: Re: [LLVMdev] LLVM 3.6: problems building on Windows using MSVC 2013 To be certain, are you using MSVC 2013 Update 4? On Tue, Mar 10, 2015 at 9:18 AM Alan Garny <agarny at hellix.com> wrote:> > So… my question is: why?! More importantly: what do I need to do to be > > able to export/import a class such as clang::driver::Compilation? > > It looks like MSVC is trying to synthesize and export the copy assignment > operator and copy constructur. This is interesting, as I thought it wouldn't do > that if the class turns out not to be non-copyable. > > Does adding the following to the class (and similarly for others that are > failing) work? > > Compilation& operator=(Compilation&) = delete; > Compilation(Compilation&) = deleteGood timing. This is the conclusion and solution to which I came too. I have tried it on my test case and it is working fine. I am now going to try it on my project and see how it goes, but at least that seems promising. Alan _______________________________________________ LLVM Developers mailing list LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150310/7a006af1/attachment.html>
Zachary Turner
2015-Mar-10 17:42 UTC
[LLVMdev] LLVM 3.6: problems building on Windows using MSVC 2013
Update 4 is the minimum required version. I don't know the exact details of what was fixed between Update 3 and Update 4, but currently if you have anything less than Update 4 our CMake warns about miscompiles and other things. On Tue, Mar 10, 2015 at 10:00 AM Alan Garny <agarny at hellix.com> wrote:> No, I am currently using MSVC 2013 Update 3. Why? Is there something I > should (have) know(n)? > > > > Alan > > > > *From:* Zachary Turner [mailto:zturner at google.com] > *Sent:* 10 March 2015 17:40 > *To:* Alan Garny; llvmdev > > > *Subject:* Re: [LLVMdev] LLVM 3.6: problems building on Windows using > MSVC 2013 > > > > To be certain, are you using MSVC 2013 Update 4? > > > > On Tue, Mar 10, 2015 at 9:18 AM Alan Garny <agarny at hellix.com> wrote: > > > > So… my question is: why?! More importantly: what do I need to do to be > > > able to export/import a class such as clang::driver::Compilation? > > > > It looks like MSVC is trying to synthesize and export the copy assignment > > operator and copy constructur. This is interesting, as I thought it > wouldn't do > > that if the class turns out not to be non-copyable. > > > > Does adding the following to the class (and similarly for others that are > > failing) work? > > > > Compilation& operator=(Compilation&) = delete; > > Compilation(Compilation&) = delete > > Good timing. This is the conclusion and solution to which I came too. I > have tried it on my test case and it is working fine. I am now going to try > it on my project and see how it goes, but at least that seems promising. > > Alan > > > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150310/035a8a07/attachment.html>
Alan Garny
2015-Mar-10 18:07 UTC
[LLVMdev] LLVM 3.6: problems building on Windows using MSVC 2013
Ok, thanks for the clarification. I don’t remember seeing any warnings when building LLVM+Clang the ‘normal’ way, but I have nonetheless upgraded to MSVC 2013 Update 4, just to be on the ‘safe side’. Alan From: Zachary Turner [mailto:zturner at google.com] Sent: 10 March 2015 18:42 To: Alan Garny; llvmdev Subject: Re: [LLVMdev] LLVM 3.6: problems building on Windows using MSVC 2013 Update 4 is the minimum required version. I don't know the exact details of what was fixed between Update 3 and Update 4, but currently if you have anything less than Update 4 our CMake warns about miscompiles and other things. On Tue, Mar 10, 2015 at 10:00 AM Alan Garny <agarny at hellix.com> wrote: No, I am currently using MSVC 2013 Update 3. Why? Is there something I should (have) know(n)? Alan From: Zachary Turner [mailto:zturner at google.com] Sent: 10 March 2015 17:40 To: Alan Garny; llvmdev Subject: Re: [LLVMdev] LLVM 3.6: problems building on Windows using MSVC 2013 To be certain, are you using MSVC 2013 Update 4? On Tue, Mar 10, 2015 at 9:18 AM Alan Garny <agarny at hellix.com> wrote:> > So… my question is: why?! More importantly: what do I need to do to be > > able to export/import a class such as clang::driver::Compilation? > > It looks like MSVC is trying to synthesize and export the copy assignment > operator and copy constructur. This is interesting, as I thought it wouldn't do > that if the class turns out not to be non-copyable. > > Does adding the following to the class (and similarly for others that are > failing) work? > > Compilation& operator=(Compilation&) = delete; > Compilation(Compilation&) = deleteGood timing. This is the conclusion and solution to which I came too. I have tried it on my test case and it is working fine. I am now going to try it on my project and see how it goes, but at least that seems promising. Alan _______________________________________________ LLVM Developers mailing list LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev _______________________________________________ LLVM Developers mailing list LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150310/25ae9371/attachment.html>