llvm dev - Feb 2015 - [LLVMdev] [PATCH] CMake: Use LLVM_VERSION_SUFFIX instead of hardcoded "svn" string

Signed-off-by: Sedat Dilek <sedat.dilek at gmail.com>
---
 CMakeLists.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index ed7aeb026f5d..60fe427e456e 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -66,7 +66,7 @@ set(LLVM_VERSION_PATCH 0)
 set(LLVM_VERSION_SUFFIX svn)
 
 if (NOT PACKAGE_VERSION)
-  set(PACKAGE_VERSION
"${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}svn")
+  set(PACKAGE_VERSION
"${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}${LLVM_VERSION_SUFFIX}")
 endif()
 
 option(LLVM_INSTALL_TOOLCHAIN_ONLY "Only include toolchain files in the
'install' target." OFF)
-- 
2.3.0

LGTM.

-Chris
> On Feb 27, 2015, at 3:27 AM, Sedat Dilek <sedat.dilek at gmail.com>
wrote:
> 
> Signed-off-by: Sedat Dilek <sedat.dilek at gmail.com>
> ---
> CMakeLists.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/CMakeLists.txt b/CMakeLists.txt
> index ed7aeb026f5d..60fe427e456e 100644
> --- a/CMakeLists.txt
> +++ b/CMakeLists.txt
> @@ -66,7 +66,7 @@ set(LLVM_VERSION_PATCH 0)
> set(LLVM_VERSION_SUFFIX svn)
> 
> if (NOT PACKAGE_VERSION)
> -  set(PACKAGE_VERSION
"${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}svn")
> +  set(PACKAGE_VERSION
"${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}${LLVM_VERSION_SUFFIX}")
> endif()
> 
> option(LLVM_INSTALL_TOOLCHAIN_ONLY "Only include toolchain files in
the 'install' target." OFF)
> -- 
> 2.3.0
> 
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

I meant to come back here and say I applied the patch in r230773. Thanks!

On Fri, Feb 27, 2015 at 12:45 PM, Chris Bieneman <beanz at apple.com>
wrote:
> LGTM.
>
> -Chris
>
> > On Feb 27, 2015, at 3:27 AM, Sedat Dilek <sedat.dilek at
gmail.com> wrote:
> >
> > Signed-off-by: Sedat Dilek <sedat.dilek at gmail.com>
> > ---
> > CMakeLists.txt | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/CMakeLists.txt b/CMakeLists.txt
> > index ed7aeb026f5d..60fe427e456e 100644
> > --- a/CMakeLists.txt
> > +++ b/CMakeLists.txt
> > @@ -66,7 +66,7 @@ set(LLVM_VERSION_PATCH 0)
> > set(LLVM_VERSION_SUFFIX svn)
> >
> > if (NOT PACKAGE_VERSION)
> > -  set(PACKAGE_VERSION
>
"${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}svn")
> > +  set(PACKAGE_VERSION
>
"${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}${LLVM_VERSION_SUFFIX}")
> > endif()
> >
> > option(LLVM_INSTALL_TOOLCHAIN_ONLY "Only include toolchain files
in the
> 'install' target." OFF)
> > --
> > 2.3.0
> >
> > _______________________________________________
> > LLVM Developers mailing list
> > LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>
>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20150227/9a38ae76/attachment.html>