llvm dev - Dec 2014 - [LLVMdev] [Compiler-rt] -march=aarch64 flag in gcc/clang

The point here is, if you are not building for Android.
You will hit this patch with cmake configuration
-DCOMPILER_RT_TEST_TRIPLE=aarch64-linux-gnu

+  elseif("${COMPILER_RT_TEST_TARGET_ARCH}" MATCHES
"aarch64")
+    test_target_arch(aarch64 "-march=aarch64")

I don't see "-march=aarch64" is a valid flag on either LLVM or
GCC.
Should we replace this with a flag which is valid for only aarch64 and works for
both LLVM and GCC ?

If the compiler-rt build works for others, I would like to see their cmake
recipe ?

--Sumanth G
-----Original Message-----
From: Tim Northover [mailto:t.p.northover at gmail.com] 
Sent: Wednesday, December 10, 2014 8:02 AM
To: Christophe Lyon
Cc: Renato Golin; Gundapaneni, Sumanth; llvmdev at cs.uiuc.edu; Kostya
Serebryany
Subject: Re: [Compiler-rt] -march=aarch64 flag in gcc/clang
> Not sure what r181130 is supposed to do, though, since it introduces a 
> buggy option.
I didn't even have compiler-rt checked out when I was doing that; I was just
trying to get the base check-all working. As I recall that option filtered
through to some llvm-lit config files. Though it might have been a .inc header.

Cheers.

Tim.

On 16 December 2014 at 21:12, Gundapaneni, Sumanth <sgundapa at
quicinc.com> wrote:
> The point here is, if you are not building for Android.
> You will hit this patch with cmake configuration
-DCOMPILER_RT_TEST_TRIPLE=aarch64-linux-gnu
>
> +  elseif("${COMPILER_RT_TEST_TARGET_ARCH}" MATCHES
"aarch64")
> +    test_target_arch(aarch64 "-march=aarch64")
>
> I don't see "-march=aarch64" is a valid flag on either LLVM
or GCC.
> Should we replace this with a flag which is valid for only aarch64 and
works for both LLVM and GCC ?
I think it should be -march=armv8-a
>
> If the compiler-rt build works for others, I would like to see their cmake
recipe ?
>
> --Sumanth G
> -----Original Message-----
> From: Tim Northover [mailto:t.p.northover at gmail.com]
> Sent: Wednesday, December 10, 2014 8:02 AM
> To: Christophe Lyon
> Cc: Renato Golin; Gundapaneni, Sumanth; llvmdev at cs.uiuc.edu; Kostya
Serebryany
> Subject: Re: [Compiler-rt] -march=aarch64 flag in gcc/clang
>
>> Not sure what r181130 is supposed to do, though, since it introduces a
>> buggy option.
>
> I didn't even have compiler-rt checked out when I was doing that; I was
just trying to get the base check-all working. As I recall that option filtered
through to some llvm-lit config files. Though it might have been a .inc header.
>
> Cheers.
>
> Tim.

On 16 December 2014 at 20:29, Christophe Lyon
<christophe.lyon at linaro.org> wrote:
>> I don't see "-march=aarch64" is a valid flag on either
LLVM or GCC.
>> Should we replace this with a flag which is valid for only aarch64 and
works for both LLVM and GCC ?
>
> I think it should be -march=armv8-a
Sorry folks, that was totally my fault and I was too busy to realise
it. I have just changed it to "armv8-a" on r224362. I'm building
it
now and it's working.

cheers,
--renato