Can anyone think of a good reason to keep this CMake variable around? AFAICT llvm should never need to be compiled with exception support, and the same applies for clang, lldb, lld, and all (?) other LLVM subprojects. If there's no reason to keep this around I can just remove it entirely. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140814/e9b291e7/attachment.html>
I thought Linux distros compile LLVM with RTTI and exceptions enabled when packaging. On Thu, Aug 14, 2014 at 3:33 PM, Zachary Turner <zturner at google.com> wrote:> Can anyone think of a good reason to keep this CMake variable around? > AFAICT llvm should never need to be compiled with exception support, and > the same applies for clang, lldb, lld, and all (?) other LLVM subprojects. > > If there's no reason to keep this around I can just remove it entirely. > > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140814/a33229dd/attachment.html>
On Thu, Aug 14, 2014 at 6:01 PM, Reid Kleckner <rnk at google.com> wrote:> I thought Linux distros compile LLVM with RTTI and exceptions enabled when > packaging. >The question is why. RTTI makes sense -- they may well need it. But exceptions should work fine in the rest of the application even if LLVM is compiled with them, no? -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140814/89a4faae/attachment.html>
On 14 August 2014 23:33, Zachary Turner <zturner at google.com> wrote:> Can anyone think of a good reason to keep this CMake variable around? > AFAICT llvm should never need to be compiled with exception support, and the > same applies for clang, lldb, lld, and all (?) other LLVM subprojects.I looked at something related to this fairly recently. The example in ``examples/ExceptionDemo/`` seems to require it. Also these files also use it lib/Transforms/Hello/CMakeLists.txt: if( NOT LLVM_REQUIRES_EH ) tools/bugpoint-passes/CMakeLists.txt: if( NOT LLVM_REQUIRES_EH ) I'm not entirely sure why though because I don't know what the export files are for and why RTTI or EH changes anything about the exported symbols. Are you aware I recently added the ``LLVM_ENABLE_EH`` CMake option [1] and that we actually export this information to clients of LLVM in LLVMConfig.cmake (as ``LLVM_ENABLE_EH``, see [2])? If you do decide to remove LLVM_REQUIRES_EH you need make sure that LLVM_ENABLE_EH doesn't break. [1] http://llvm.org/docs/CMake.html#frequently-used-cmake-variables [2] http://llvm.org/docs/CMake.html#embedding-llvm-in-your-project Thanks, Dan.