llvm dev - Jul 2014 - [LLVMdev] [compiler-rt] CMake bug in building ARM builtins library

On Tue, Jul 8, 2014 at 2:44 PM, sgundapa <sgundapa at codeaurora.org>
wrote:
> No. CMake has different way of treating the .S files
> Refer to http://www.cmake.org/Wiki/CMake/Assembler
>
> I have a patch which will make CMake treat the .S files as source files.
>
Let me guess, you should just call set_source_file_properties(<arm .S
files> PROPERTIES LANGUAGE C)?

> But, how I can run the unit tests.  I see from
> compiler-rt/test/CMakeLists.txt
>
> # BlocksRuntime and builtins testsuites are not yet ported to lit.
> # add_subdirectory(BlocksRuntime)
> # add_subdirectory(builtins)
>
> How do you run the unit tests for builtins?
>
Well, there is http://reviews.llvm.org/D4251 which adds support for running
the tests under CTest, but it's not yet reviewed.
There's also a "test/builtins/Unit/test" script, but I doubt it
will run
out of the box.

>
>
> --Sumanth G
> -----Original Message-----
> From: Renato Golin [mailto:renato.golin at linaro.org]
> Sent: Tuesday, July 08, 2014 12:19 PM
> To: Alexey Samsonov
> Cc: sgundapa; LLVM Dev
> Subject: Re: [LLVMdev] [compiler-rt] CMake bug in building ARM builtins
> library
>
> On 8 July 2014 19:47, Alexey Samsonov <vonosmas at gmail.com> wrote:
> > compiler-rt/lib/builtins/arm/*.S files are listed in arm_SOURCES
> > variable, and therefore should make it into the builtins static
> > library on ARM. Don't they?
>
> I assume so... But I'm not an expert in CMake.
>
>

-- 
Alexey Samsonov
vonosmas at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20140710/3d5e2271/attachment.html>

Yes, the fix is set_source_file_properties(<arm .S files> PROPERTIES
LANGUAGE C)?

I will try using your patch for running builtins tests in my local set up.

 

Thanks

--Sumanth G

 

On Tue, Jul 8, 2014 at 2:44 PM, sgundapa <sgundapa at codeaurora.org>
wrote:

No. CMake has different way of treating the .S files
Refer to http://www.cmake.org/Wiki/CMake/Assembler

I have a patch which will make CMake treat the .S files as source files.

 

Let me guess, you should just call set_source_file_properties(<arm .S
files> PROPERTIES LANGUAGE C)?

 

But, how I can run the unit tests.  I see from compiler-rt/test/CMakeLists.txt

# BlocksRuntime and builtins testsuites are not yet ported to lit.
# add_subdirectory(BlocksRuntime)
# add_subdirectory(builtins)

How do you run the unit tests for builtins?

 

Well, there is http://reviews.llvm.org/D4251 which adds support for running the
tests under CTest, but it's not yet reviewed.

There's also a "test/builtins/Unit/test" script, but I doubt it
will run out of the box.

 



--Sumanth G

-----Original Message-----
From: Renato Golin [mailto:renato.golin at linaro.org]
Sent: Tuesday, July 08, 2014 12:19 PM
To: Alexey Samsonov
Cc: sgundapa; LLVM Dev
Subject: Re: [LLVMdev] [compiler-rt] CMake bug in building ARM builtins library

On 8 July 2014 19:47, Alexey Samsonov <vonosmas at gmail.com>
wrote:
> compiler-rt/lib/builtins/arm/*.S files are listed in arm_SOURCES
> variable, and therefore should make it into the builtins static
> library on ARM. Don't they?
I assume so... But I'm not an expert in CMake.





 

-- 

Alexey Samsonov
vonosmas at gmail.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20140711/cb1ecabd/attachment.html>

I see a couple of issues here.

If I include .S files for ARM, the –no-integrated-as path complains about
Assembler errors.

The integrated-as path works fine though.

 

Since I am cross compiling, I cannot use the CTest framework from
http://reviews.llvm.org/D4251

I am writing the lit complaint files to run for cross-compiled unit tests. I
will push one when I am done testing it.

 

--Sumanth G

 

 

 

Yes, the fix is set_source_file_properties(<arm .S files> PROPERTIES
LANGUAGE C)?

I will try using your patch for running builtins tests in my local set up.

 

Thanks

--Sumanth G

 

On Tue, Jul 8, 2014 at 2:44 PM, sgundapa <sgundapa at codeaurora.org>
wrote:

No. CMake has different way of treating the .S files
Refer to http://www.cmake.org/Wiki/CMake/Assembler

I have a patch which will make CMake treat the .S files as source files.

 

Let me guess, you should just call set_source_file_properties(<arm .S
files> PROPERTIES LANGUAGE C)?

 

But, how I can run the unit tests.  I see from compiler-rt/test/CMakeLists.txt

# BlocksRuntime and builtins testsuites are not yet ported to lit.
# add_subdirectory(BlocksRuntime)
# add_subdirectory(builtins)

How do you run the unit tests for builtins?

 

Well, there is http://reviews.llvm.org/D4251 which adds support for running the
tests under CTest, but it's not yet reviewed.

There's also a "test/builtins/Unit/test" script, but I doubt it
will run out of the box.

 



--Sumanth G

-----Original Message-----
From: Renato Golin [mailto:renato.golin at linaro.org]
Sent: Tuesday, July 08, 2014 12:19 PM
To: Alexey Samsonov
Cc: sgundapa; LLVM Dev
Subject: Re: [LLVMdev] [compiler-rt] CMake bug in building ARM builtins library

On 8 July 2014 19:47, Alexey Samsonov <vonosmas at gmail.com>
wrote:
> compiler-rt/lib/builtins/arm/*.S files are listed in arm_SOURCES
> variable, and therefore should make it into the builtins static
> library on ARM. Don't they?
I assume so... But I'm not an expert in CMake.





 

-- 

Alexey Samsonov
vonosmas at gmail.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20140716/218a1711/attachment.html>

On 7/16/14, 6:09 PM, sgundapa wrote:
> I see a couple of issues here.
>
> If I include .S files for ARM, the –no-integrated-as path complains about
> Assembler errors.
>
> The integrated-as path works fine though.
>
These are very likely just differences between the old ARM assembler syntax and 
the new 'Unified' syntax.  Can you use an assembler that accepts UAL
syntax?

Regards,
Jon


-- 
Jon Roelofs
jonathan at codesourcery.com
CodeSourcery / Mentor Embedded