llvm dev - Jul 2014 - [LLVMdev] [compiler-rt] CMake bug in building ARM builtins library

I noticed the compiler-rt/lib/builtins/CmakeLists.txt is not including the
.S files in building clang_rt.builtins-arm.a

We need to tell the CMake build system that the .S files are also the source
files.

 

Is there any intention behind leaving the .S files not to compile?

If not, let me know and I will push a patch.

 

--Sumanth G

-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20140708/f7684413/attachment.html>

Hi,

compiler-rt/lib/builtins/arm/*.S files are listed in arm_SOURCES variable,
and therefore should make it into the builtins static library on ARM. Don't
they?


On Tue, Jul 8, 2014 at 11:25 AM, sgundapa <sgundapa at codeaurora.org>
wrote:
> I noticed the compiler-rt/lib/builtins/CmakeLists.txt is not including the
> .S files in building clang_rt.builtins-arm.a
>
> We need to tell the CMake build system that the .S files are also the
> source files.
>
>
>
> Is there any intention behind leaving the .S files not to compile?
>
> If not, let me know and I will push a patch.
>
>
>
> --Sumanth G
>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>
>

-- 
Alexey Samsonov
vonosmas at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20140708/b8275aba/attachment.html>

On 8 July 2014 19:25, sgundapa <sgundapa at codeaurora.org>
wrote:
> Is there any intention behind leaving the .S files not to compile?
It probably was just me being silly. If they compile well and pass all
the tests, please, add them.

cheers,
--renato

On 8 July 2014 19:47, Alexey Samsonov <vonosmas at gmail.com>
wrote:
> compiler-rt/lib/builtins/arm/*.S files are listed in arm_SOURCES variable,
> and therefore should make it into the builtins static library on ARM.
Don't
> they?
I assume so... But I'm not an expert in CMake.

On Tue, Jul 8, 2014 at 11:51 AM, Renato Golin <renato.golin at linaro.org>
wrote:
> On 8 July 2014 19:25, sgundapa <sgundapa at codeaurora.org> wrote:
> > Is there any intention behind leaving the .S files not to compile?
>
> It probably was just me being silly. If they compile well and pass all
> the tests, please, add them.
>
Well, there should be some attention paid to this.  Some of them are meant
for the soft ABI.  Some of them are only applicable to EABI environments,
and some of them are only for SJLJ exceptions.

The comments in the outstanding Makefile change to enable Windows on ARM
build contains comments categorizing them.

> cheers,
> --renato
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>


-- 
Saleem Abdulrasool
compnerd (at) compnerd (dot) org
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20140711/d4c69555/attachment.html>