Hi Chandler, Kai contributed the WIN64 SEH patch some time ago on llvm-commits: http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20131118/196105.html it was never completed. Kai also responded in this thread. I opened a phabricator for the patch http://reviews.llvm.org/D3418 Yaron 2014-04-18 12:31 GMT+03:00 Chandler Carruth <chandlerc at google.com>:> > On Tue, Apr 15, 2014 at 11:43 AM, Martell Malone <martellmalone at gmail.com>wrote: > >> This is mostly based on work done by kai from redstar.de >> > > Martell, you really cannot post patches for review or otherwise contribute > them to LLVM unless you authored the patch. If Kai authored the patch, then > Kai needs to contirbute it. > > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140418/7ffaf8e1/attachment.html>
On Fri, Apr 18, 2014 at 2:47 AM, Yaron Keren <yaron.keren at gmail.com> wrote:> Hi Chandler, > > Kai contributed the WIN64 SEH patch some time ago on llvm-commits: > > > http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20131118/196105.html > > it was never completed. Kai also responded in this thread. >Then please, do not start new threads with new people and no reference to the existing review. That makes accurate code review essentially impossible. I still don't know why you claimed part of the code was implemented by Ray Donnelly. If it was, then Kai shouldn't have contributed the patch either. Exactly who authored this code, and can they write the emails contributing it? -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140418/da549ee2/attachment.html>
Hi Chandler, There were five SEH releated patches posted in two threads in the last days. Two different patches in Martell e-mail starting this thread: the win64 seh (llvm) and the register names Three more related SEH patches in another thread: one for win64 seh clang, one for MinGW toolchain and another for unreachable prologue. To clarify and allow proper reviews for the different patches I opened reviews for four of them (the fifth got LGTM in the discussion but it does have the ownership issue you wrote) D3417 Emit a trap instruction for IR 'unreachable <http://reviews.llvm.org/D3417> D3418 SEH exceptions on Win64 (LLVM) <http://reviews.llvm.org/D3418> D3419 SEH exceptions on Win64 (clang part) <http://reviews.llvm.org/D3419> D3420 MinGW toolchain <http://reviews.llvm.org/D3420> Per your suggestion the link to the original discussion in D3418 was added. Code authors are: unreachable is by Vadim Chugunov. win64 seh llvm is by Kai Nacke + Martell re-posting. win64 seh clang is by Martell. mingw toolchain is by Martell. register names is by Ray Donnelly + Martell posting it. seh test for "register names" ( test is r206566) by myself. All but the "register names" patch were posted by their author on the llvm lists. Yaron -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140418/67f61883/attachment.html>