thr3ads.net - llvm dev - [LLVMdev] [cfe-dev] [Reminder] LLVM 3.4 Release Branching [Nov 2013]

If this information is useful, please help other people find it:
Share via:

Alexander Potapenko

2013-Nov-11 09:59 UTC

[LLVMdev] [cfe-dev] [Reminder] LLVM 3.4 Release Branching

Jack,

Where do the "-isysroot
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.8.sdk
-mmacosx-version-min=10.8" flags come from? I don't see them in your
CMake invocation - perhaps they're added via $CC or $CFLAGS? Is this
being done on purpose?

I can add a CMake step checking whether the current CFLAGS/LDFLAGS
allow to build an iossim binary, and skip building the iossim runtime
if that's impossible.
But in that case your compiler won't be able to build the iossim runtime at
all.

Alex

On Sun, Nov 10, 2013 at 7:50 PM, Jack Howarth <howarth at
bromo.med.uc.edu> wrote:> On Sun, Nov 10, 2013 at 06:11:16AM -0800, Bill Wendling wrote:
>> Good day!
>>
>> This is just a reminder that branching for the 3.4 release will occur
at this time:
>>
>>       Monday, November 18, 2013 at 7:00:00 PM PST / Tuesday, November
19, 2013 at 3:00:00 AM UTC
>>
>> What this means for you!
>> ------------------------
>>
>> * Please keep the release notes up to date -- There has been very few
commits to them. Please be proactive and update them with any significant
feature that was put in.
>>
>> * Keep the tree healthy -- Pay attention to buildbot failures and
regressions and fix them as quickly as possible.
>>
>> * Finish your features -- The 18th won't be the final day to submit
code, but you should have a significant portion of the feature finished by then.
I.e., a few minor changes, bug fixes, and clean ups. If you're going to be
late with your feature, please let me know ahead of time and we can figure
something out.
>>
>> * Fix bugs -- Go through the bug database and find those PRs which you
can fix easily. If a PR is a release blockers, then ask the code owner to bump
up the priority.
>>
>> This should be a wicked awesome release! :-)
>>
>> Share and enjoy!
>> -bw
>
> Current llvm/compiler-rt/clang svn is still broken on x86_64 darwin13 here
for a build with...
>
> cmake -DLLVM_BUILD_32_BITS:BOOL=OFF -DLLVM_TARGETS_TO_BUILD=X86 
-DCMAKE_INSTALL_PREFIX=/sw/opt/llvm-3.4 -DLLVM_ENABLE_ASSERTIONS=OFF
-DCMAKE_BUILD_TYPE=Release ..
>
> [ 54%] Building CXX object
projects/compiler-rt/lib/asan/CMakeFiles/RTAsan.iossim.dir/asan_allocator2.cc.o
> cd
/sw/src/fink.build/llvm34-3.4-0/llvm-3.4/build/projects/compiler-rt/lib/asan
&& /sw/var/lib/fink/path-prefix-clang/c++  
-DASAN_FLEXIBLE_MAPPING_AND_OFFSET=1 -DASAN_HAS_EXCEPTIONS=1 -DASAN_NEEDS_SEGV=1
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -fPIC
-fvisibility-inlines-hidden -Wall -W -Wno-unused-parameter -Wwrite-strings
-Wmissing-field-initializers -pedantic -Wno-long-long -Wcovered-switch-default
-Wnon-virtual-dtor -O3 -DNDEBUG -arch x86_64 -arch i386 -isysroot
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.8.sdk
-mmacosx-version-min=10.8
-I/sw/src/fink.build/llvm34-3.4-0/llvm-3.4/build/projects/compiler-rt/lib/asan
-I/sw/src/fink.build/llvm34-3.4-0/llvm-3.4/projects/compiler-rt/lib/asan
-I/sw/src/fink.build/llvm34-3.4-0/llvm-3.4/build/include
-I/sw/src/fink.build/llvm34-3.4-0/llvm-3.4/include
-I/sw/src/fink.build/llvm34-3.4-0/llvm-3.4/projects/compiler-rt/include
-I/sw/src/fink.build/llvm34-3.4!
>  -0/llvm-3.4/projects/compiler-rt/lib/asan/..     -fPIC -fno-builtin
-fno-exceptions -fomit-frame-pointer -funwind-tables -fno-stack-protector
-Wno-gnu -fvisibility=hidden -O3 -gline-tables-only -Wno-variadic-macros
-Wno-c99-extensions -Wno-non-virtual-dtor -fno-rtti
-mios-simulator-version-min=7.0 -isysroot
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator7.0.sdk
-o CMakeFiles/RTAsan.iossim.dir/asan_allocator2.cc.o -c
/sw/src/fink.build/llvm34-3.4-0/llvm-3.4/projects/compiler-rt/lib/asan/asan_allocator2.cc
> clang: error: invalid argument '-mmacosx-version-min=10.8' not
allowed with '-mios-simulator-version-min=7.0'
> clang: error: invalid argument '-mmacosx-version-min=10.8' not
allowed with '-mios-simulator-version-min=7.0'
> make[2]: ***
[projects/compiler-rt/lib/asan/CMakeFiles/RTAsan.iossim.dir/asan_allocator2.cc.o]
Error 1
> make[1]: ***
[projects/compiler-rt/lib/asan/CMakeFiles/RTAsan.iossim.dir/all] Error 2
> make: *** [all] Error 2
> ### execution of /tmp/fink.lUrKE failed, exit code 2
> ### execution of /tmp/fink.kVn0V failed, exit code 2
>
>>
>
>> _______________________________________________
>> LLVM Developers mailing list
>> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>
>
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev


-- 
Alexander Potapenko
Software Engineer
Google Moscow

Jack Howarth

2013-Nov-11 14:16 UTC

head link

[LLVMdev] [cfe-dev] [Reminder] LLVM 3.4 Release Branching

On Mon, Nov 11, 2013 at 01:59:25PM +0400, Alexander Potapenko
wrote:> Jack,
> 
> Where do the "-isysroot
>
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.8.sdk
> -mmacosx-version-min=10.8" flags come from? I don't see them in
your
> CMake invocation - perhaps they're added via $CC or $CFLAGS? Is this
> being done on purpose?
In the llvm-3.4 toplevel Makefile.rules file, I see...

ifeq ($(HOST_OS),Darwin)
 ifdef MACOSX_DEPLOYMENT_TARGET
  DARWIN_VERSION := $(MACOSX_DEPLOYMENT_TARGET)
 else
  DARWIN_VERSION := `sw_vers -productVersion`
 endif
  # Strip a number like 10.4.7 to 10.4
  DARWIN_VERSION := $(shell echo $(DARWIN_VERSION)| sed -E
's/(10.[0-9]).*/\1/')
  # Get "4" out of 10.4 for later pieces in the makefile.
  DARWIN_MAJVERS := $(shell echo $(DARWIN_VERSION)| sed -E
's/10.([0-9]).*/\1/')

  LoadableModuleOptions := -Wl,-flat_namespace -Wl,-undefined,suppress
  SharedLinkOptions := -dynamiclib
  ifdef DEPLOYMENT_TARGET
    SharedLinkOptions += $(DEPLOYMENT_TARGET)
  else
    ifneq ($(ARCH),ARM)
      SharedLinkOptions += -mmacosx-version-min=$(DARWIN_VERSION)
    endif
  endif
else
  SharedLinkOptions=-shared
endif

ifeq ($(TARGET_OS),Darwin)
  ifdef DEPLOYMENT_TARGET
    TargetCommonOpts += $(DEPLOYMENT_TARGET)
  else
    ifneq ($(ARCH),ARM)
      TargetCommonOpts += -mmacosx-version-min=$(DARWIN_VERSION)
    endif
  endif
endif
> 
> I can add a CMake step checking whether the current CFLAGS/LDFLAGS
> allow to build an iossim binary, and skip building the iossim runtime
> if that's impossible.
> But in that case your compiler won't be able to build the iossim
runtime at all.
> 
> Alex
> 
> On Sun, Nov 10, 2013 at 7:50 PM, Jack Howarth <howarth at
bromo.med.uc.edu> wrote:
> > On Sun, Nov 10, 2013 at 06:11:16AM -0800, Bill Wendling wrote:
> >> Good day!
> >>
> >> This is just a reminder that branching for the 3.4 release will
occur at this time:
> >>
> >>       Monday, November 18, 2013 at 7:00:00 PM PST / Tuesday,
November 19, 2013 at 3:00:00 AM UTC
> >>
> >> What this means for you!
> >> ------------------------
> >>
> >> * Please keep the release notes up to date -- There has been very
few commits to them. Please be proactive and update them with any significant
feature that was put in.
> >>
> >> * Keep the tree healthy -- Pay attention to buildbot failures and
regressions and fix them as quickly as possible.
> >>
> >> * Finish your features -- The 18th won't be the final day to
submit code, but you should have a significant portion of the feature finished
by then. I.e., a few minor changes, bug fixes, and clean ups. If you're
going to be late with your feature, please let me know ahead of time and we can
figure something out.
> >>
> >> * Fix bugs -- Go through the bug database and find those PRs which
you can fix easily. If a PR is a release blockers, then ask the code owner to
bump up the priority.
> >>
> >> This should be a wicked awesome release! :-)
> >>
> >> Share and enjoy!
> >> -bw
> >
> > Current llvm/compiler-rt/clang svn is still broken on x86_64 darwin13
here for a build with...
> >
> > cmake -DLLVM_BUILD_32_BITS:BOOL=OFF -DLLVM_TARGETS_TO_BUILD=X86 
-DCMAKE_INSTALL_PREFIX=/sw/opt/llvm-3.4 -DLLVM_ENABLE_ASSERTIONS=OFF
-DCMAKE_BUILD_TYPE=Release ..
> >
> > [ 54%] Building CXX object
projects/compiler-rt/lib/asan/CMakeFiles/RTAsan.iossim.dir/asan_allocator2.cc.o
> > cd
/sw/src/fink.build/llvm34-3.4-0/llvm-3.4/build/projects/compiler-rt/lib/asan
&& /sw/var/lib/fink/path-prefix-clang/c++  
-DASAN_FLEXIBLE_MAPPING_AND_OFFSET=1 -DASAN_HAS_EXCEPTIONS=1 -DASAN_NEEDS_SEGV=1
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -fPIC
-fvisibility-inlines-hidden -Wall -W -Wno-unused-parameter -Wwrite-strings
-Wmissing-field-initializers -pedantic -Wno-long-long -Wcovered-switch-default
-Wnon-virtual-dtor -O3 -DNDEBUG -arch x86_64 -arch i386 -isysroot
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.8.sdk
-mmacosx-version-min=10.8
-I/sw/src/fink.build/llvm34-3.4-0/llvm-3.4/build/projects/compiler-rt/lib/asan
-I/sw/src/fink.build/llvm34-3.4-0/llvm-3.4/projects/compiler-rt/lib/asan
-I/sw/src/fink.build/llvm34-3.4-0/llvm-3.4/build/include
-I/sw/src/fink.build/llvm34-3.4-0/llvm-3.4/include
-I/sw/src/fink.build/llvm34-3.4-0/llvm-3.4/projects/compiler-rt/include
-I/sw/src/fink.build/llvm34-3.4!
> >  -0/llvm-3.4/projects/compiler-rt/lib/asan/..     -fPIC -fno-builtin
-fno-exceptions -fomit-frame-pointer -funwind-tables -fno-stack-protector
-Wno-gnu -fvisibility=hidden -O3 -gline-tables-only -Wno-variadic-macros
-Wno-c99-extensions -Wno-non-virtual-dtor -fno-rtti
-mios-simulator-version-min=7.0 -isysroot
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator7.0.sdk
-o CMakeFiles/RTAsan.iossim.dir/asan_allocator2.cc.o -c
/sw/src/fink.build/llvm34-3.4-0/llvm-3.4/projects/compiler-rt/lib/asan/asan_allocator2.cc
> > clang: error: invalid argument '-mmacosx-version-min=10.8' not
allowed with '-mios-simulator-version-min=7.0'
> > clang: error: invalid argument '-mmacosx-version-min=10.8' not
allowed with '-mios-simulator-version-min=7.0'
> > make[2]: ***
[projects/compiler-rt/lib/asan/CMakeFiles/RTAsan.iossim.dir/asan_allocator2.cc.o]
Error 1
> > make[1]: ***
[projects/compiler-rt/lib/asan/CMakeFiles/RTAsan.iossim.dir/all] Error 2
> > make: *** [all] Error 2
> > ### execution of /tmp/fink.lUrKE failed, exit code 2
> > ### execution of /tmp/fink.kVn0V failed, exit code 2
> >
> >>
> >
> >> _______________________________________________
> >> LLVM Developers mailing list
> >> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> >> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
> >
> >
> > _______________________________________________
> > cfe-dev mailing list
> > cfe-dev at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
> 
> 
> 
> -- 
> Alexander Potapenko
> Software Engineer
> Google Moscow

Alexander Potapenko

2013-Nov-11 14:46 UTC

head link

[LLVMdev] [cfe-dev] [Reminder] LLVM 3.4 Release Branching

This file is for configure+make build, not CMake, so I'm not sure why
it's being included into your build (these failures aren't
reproducible for me).
Can you please list the exact steps you're doing to build LLVM with
CMake and make sure you don't have additional CFLAGS (LDFLAGS etc)
defined?

On Mon, Nov 11, 2013 at 6:16 PM, Jack Howarth <howarth at
bromo.med.uc.edu> wrote:> On Mon, Nov 11, 2013 at 01:59:25PM +0400, Alexander Potapenko wrote:
>> Jack,
>>
>> Where do the "-isysroot
>>
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.8.sdk
>> -mmacosx-version-min=10.8" flags come from? I don't see them
in your
>> CMake invocation - perhaps they're added via $CC or $CFLAGS? Is
this
>> being done on purpose?
>
> In the llvm-3.4 toplevel Makefile.rules file, I see...
>
> ifeq ($(HOST_OS),Darwin)
>  ifdef MACOSX_DEPLOYMENT_TARGET
>   DARWIN_VERSION := $(MACOSX_DEPLOYMENT_TARGET)
>  else
>   DARWIN_VERSION := `sw_vers -productVersion`
>  endif
>   # Strip a number like 10.4.7 to 10.4
>   DARWIN_VERSION := $(shell echo $(DARWIN_VERSION)| sed -E
's/(10.[0-9]).*/\1/')
>   # Get "4" out of 10.4 for later pieces in the makefile.
>   DARWIN_MAJVERS := $(shell echo $(DARWIN_VERSION)| sed -E
's/10.([0-9]).*/\1/')
>
>   LoadableModuleOptions := -Wl,-flat_namespace -Wl,-undefined,suppress
>   SharedLinkOptions := -dynamiclib
>   ifdef DEPLOYMENT_TARGET
>     SharedLinkOptions += $(DEPLOYMENT_TARGET)
>   else
>     ifneq ($(ARCH),ARM)
>       SharedLinkOptions += -mmacosx-version-min=$(DARWIN_VERSION)
>     endif
>   endif
> else
>   SharedLinkOptions=-shared
> endif
>
> ifeq ($(TARGET_OS),Darwin)
>   ifdef DEPLOYMENT_TARGET
>     TargetCommonOpts += $(DEPLOYMENT_TARGET)
>   else
>     ifneq ($(ARCH),ARM)
>       TargetCommonOpts += -mmacosx-version-min=$(DARWIN_VERSION)
>     endif
>   endif
> endif
>
>>
>> I can add a CMake step checking whether the current CFLAGS/LDFLAGS
>> allow to build an iossim binary, and skip building the iossim runtime
>> if that's impossible.
>> But in that case your compiler won't be able to build the iossim
runtime at all.
>>
>> Alex
>>
>> On Sun, Nov 10, 2013 at 7:50 PM, Jack Howarth <howarth at
bromo.med.uc.edu> wrote:
>> > On Sun, Nov 10, 2013 at 06:11:16AM -0800, Bill Wendling wrote:
>> >> Good day!
>> >>
>> >> This is just a reminder that branching for the 3.4 release
will occur at this time:
>> >>
>> >>       Monday, November 18, 2013 at 7:00:00 PM PST / Tuesday,
November 19, 2013 at 3:00:00 AM UTC
>> >>
>> >> What this means for you!
>> >> ------------------------
>> >>
>> >> * Please keep the release notes up to date -- There has been
very few commits to them. Please be proactive and update them with any
significant feature that was put in.
>> >>
>> >> * Keep the tree healthy -- Pay attention to buildbot failures
and regressions and fix them as quickly as possible.
>> >>
>> >> * Finish your features -- The 18th won't be the final day
to submit code, but you should have a significant portion of the feature
finished by then. I.e., a few minor changes, bug fixes, and clean ups. If
you're going to be late with your feature, please let me know ahead of time
and we can figure something out.
>> >>
>> >> * Fix bugs -- Go through the bug database and find those PRs
which you can fix easily. If a PR is a release blockers, then ask the code owner
to bump up the priority.
>> >>
>> >> This should be a wicked awesome release! :-)
>> >>
>> >> Share and enjoy!
>> >> -bw
>> >
>> > Current llvm/compiler-rt/clang svn is still broken on x86_64
darwin13 here for a build with...
>> >
>> > cmake -DLLVM_BUILD_32_BITS:BOOL=OFF -DLLVM_TARGETS_TO_BUILD=X86 
-DCMAKE_INSTALL_PREFIX=/sw/opt/llvm-3.4 -DLLVM_ENABLE_ASSERTIONS=OFF
-DCMAKE_BUILD_TYPE=Release ..
>> >
>> > [ 54%] Building CXX object
projects/compiler-rt/lib/asan/CMakeFiles/RTAsan.iossim.dir/asan_allocator2.cc.o
>> > cd
/sw/src/fink.build/llvm34-3.4-0/llvm-3.4/build/projects/compiler-rt/lib/asan
&& /sw/var/lib/fink/path-prefix-clang/c++  
-DASAN_FLEXIBLE_MAPPING_AND_OFFSET=1 -DASAN_HAS_EXCEPTIONS=1 -DASAN_NEEDS_SEGV=1
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -fPIC
-fvisibility-inlines-hidden -Wall -W -Wno-unused-parameter -Wwrite-strings
-Wmissing-field-initializers -pedantic -Wno-long-long -Wcovered-switch-default
-Wnon-virtual-dtor -O3 -DNDEBUG -arch x86_64 -arch i386 -isysroot
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.8.sdk
-mmacosx-version-min=10.8
-I/sw/src/fink.build/llvm34-3.4-0/llvm-3.4/build/projects/compiler-rt/lib/asan
-I/sw/src/fink.build/llvm34-3.4-0/llvm-3.4/projects/compiler-rt/lib/asan
-I/sw/src/fink.build/llvm34-3.4-0/llvm-3.4/build/include
-I/sw/src/fink.build/llvm34-3.4-0/llvm-3.4/include
-I/sw/src/fink.build/llvm34-3.4-0/llvm-3.4/projects/compiler-rt/include
-I/sw/src/fink.build/llvm34-3.4!
>> >  -0/llvm-3.4/projects/compiler-rt/lib/asan/..     -fPIC
-fno-builtin -fno-exceptions -fomit-frame-pointer -funwind-tables
-fno-stack-protector -Wno-gnu -fvisibility=hidden -O3 -gline-tables-only
-Wno-variadic-macros -Wno-c99-extensions -Wno-non-virtual-dtor -fno-rtti
-mios-simulator-version-min=7.0 -isysroot
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator7.0.sdk
-o CMakeFiles/RTAsan.iossim.dir/asan_allocator2.cc.o -c
/sw/src/fink.build/llvm34-3.4-0/llvm-3.4/projects/compiler-rt/lib/asan/asan_allocator2.cc
>> > clang: error: invalid argument '-mmacosx-version-min=10.8'
not allowed with '-mios-simulator-version-min=7.0'
>> > clang: error: invalid argument '-mmacosx-version-min=10.8'
not allowed with '-mios-simulator-version-min=7.0'
>> > make[2]: ***
[projects/compiler-rt/lib/asan/CMakeFiles/RTAsan.iossim.dir/asan_allocator2.cc.o]
Error 1
>> > make[1]: ***
[projects/compiler-rt/lib/asan/CMakeFiles/RTAsan.iossim.dir/all] Error 2
>> > make: *** [all] Error 2
>> > ### execution of /tmp/fink.lUrKE failed, exit code 2
>> > ### execution of /tmp/fink.kVn0V failed, exit code 2
>> >
>> >>
>> >
>> >> _______________________________________________
>> >> LLVM Developers mailing list
>> >> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
>> >> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>> >
>> >
>> > _______________________________________________
>> > cfe-dev mailing list
>> > cfe-dev at cs.uiuc.edu
>> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
>>
>>
>>
>> --
>> Alexander Potapenko
>> Software Engineer
>> Google Moscow


-- 
Alexander Potapenko
Software Engineer
Google Moscow

Reasonably Related Threads

Search for more seemingly similar threads

llvm dev - Nov 2013 - [LLVMdev] [cfe-dev] [Reminder] LLVM 3.4 Release Branching

[LLVMdev] [cfe-dev] [Reminder] LLVM 3.4 Release Branching

[LLVMdev] [cfe-dev] [Reminder] LLVM 3.4 Release Branching

[LLVMdev] [cfe-dev] [Reminder] LLVM 3.4 Release Branching

Reasonably Related Threads