llvm dev - Nov 2013 - [LLVMdev] SLP vectorizer turned on in commit r190916 which says nothing about it - how to turn it off?

Revision 190916

Commit message:

"Lift alignment restrictions for load/store folding on 
VINSERTF128/VEXTRACTF128. Fixes PR17268."




Actual contents of the commit includes


Index: tools/opt/opt.cpp
==================================================================---
tools/opt/opt.cpp   (revision 190915)
+++ tools/opt/opt.cpp   (revision 190916)
@@ -462,6 +462,7 @@
                                 DisableLoopUnrolling : OptLevel == 0;

    Builder.LoopVectorize = OptLevel > 1 && SizeLevel < 2;
+  Builder.SLPVectorize = true;

    Builder.populateFunctionPassManager(FPM);
    Builder.populateModulePassManager(MPM);







I think that should not be there?

There should at least be a way to turn the SLP optimizer off?

It breaks things on our architecture(TCE) which I'm now porting to use 
llvm 3.4

This looks like it was an oversight; there is already a -vectorize-slp option
exported by the PassManagerBuilder that should control this default.

 -Hal

----- Original Message -----
> Revision 190916
> 
> Commit message:
> 
> "Lift alignment restrictions for load/store folding on
> VINSERTF128/VEXTRACTF128. Fixes PR17268."
> 
> 
> 
> 
> Actual contents of the commit includes
> 
> 
> Index: tools/opt/opt.cpp
> ==================================================================> ---
tools/opt/opt.cpp   (revision 190915)
> +++ tools/opt/opt.cpp   (revision 190916)
> @@ -462,6 +462,7 @@
>                                  DisableLoopUnrolling : OptLevel =>     
0;
> 
>     Builder.LoopVectorize = OptLevel > 1 && SizeLevel < 2;
> +  Builder.SLPVectorize = true;
> 
>     Builder.populateFunctionPassManager(FPM);
>     Builder.populateModulePassManager(MPM);
> 
> 
> 
> 
> 
> 
> 
> I think that should not be there?
> 
> There should at least be a way to turn the SLP optimizer off?
> 
> It breaks things on our architecture(TCE) which I'm now porting to
> use
> llvm 3.4
> 
> 
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
> 
-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory