Katsuhiro Ueno
2013-Aug-03 03:08 UTC
[LLVMdev] bug of tail call optimization on x86 target
Hi Tim, Thank you for your quick response.> I'm not convinced that's the best solution, at least conceptually. > SlotSize really is an unsigned quantity, and though it's unlikely we'd > like 0x80000000 to be interpreted as positive, rather than negative if > it ever does occur.I totally agree with you. I rewrote my fix and made a test case according to your suggestion. All of them are included in the attached file. Thanks and regards, Katsuhiro Ueno -------------- next part -------------- A non-text attachment was scrubbed... Name: x86-tailcallopt-fix-2.diff Type: application/octet-stream Size: 2947 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20130803/901297c7/attachment.obj>
Hi Katsuhiro,> I rewrote my fix and made a test case according to your suggestion. > All of them are included in the attached file.Thanks very much for doing that and taking the time in the first place to make the patch. It looked good to me so I committed it in r187703. It'll automatically make its way into the 3.4 release later this year. Cheers. Tim.
Katsuhiro Ueno
2013-Aug-04 12:50 UTC
[LLVMdev] bug of tail call optimization on x86 target
Hi Tim,> Thanks very much for doing that and taking the time in the first place > to make the patch. It looked good to me so I committed it in r187703. > > It'll automatically make its way into the 3.4 release later this year.Thank you very much for your cooperation and merging my patch. We are looking forward to the 3.4 release. Best regards, Katsuhiro Ueno