llvm dev - Jun 2013 - [LLVMdev] [PATCH] Add host feature detection for Qualcomm CPUs

Hi,

I would like to add host feature detection for Qualcomm CPUs. The
implementation models
the feature detection for ARM CPUs. Is this OK to commit?

Thanks,
Tobi
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20130610/caeabd25/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-host-CPU-feature-detection-for-Qualcomm-CPUs.patch
Type: application/octet-stream
Size: 1389 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20130610/caeabd25/attachment.obj>

Hi Tobi,

[cc llvm-commits]

I don't understand why you need to replicate all that - why can't you
just change:

if (Implementer == "0x41") // ARM Ltd.

To:

if (Implementer == "0x41" || Implementer == "0x31")

?

It looks like the feature strings will be the same - and in fact we grabbed them
straight from the Linux kernel source which returns the same strings for
ARM-like CPUs (QC or ARM).

Cheers,

James

________________________________________
From: Tobias Grosser [grosser at google.com]
Sent: 10 June 2013 21:18
To: LLVMdev at cs.uiuc.edu
Cc: James Molloy
Subject: [PATCH] Add host feature detection for Qualcomm CPUs

Hi,

I would like to add host feature detection for Qualcomm CPUs. The implementation
models
the feature detection for ARM CPUs. Is this OK to commit?

Thanks,
Tobi

-- IMPORTANT NOTICE: The contents of this email and any attachments are
confidential and may also be privileged. If you are not the intended recipient,
please notify the sender immediately and do not disclose the contents to any
other person, use it for any purpose, or store or copy the information in any
medium.  Thank you.

On 10 June 2013 21:35, James Molloy <James.Molloy at arm.com> wrote:
> if (Implementer == "0x41" || Implementer == "0x31")
>
0x51 you mean? I agree with James, should be just a matter of adding the
new case on the existing condition.

cheers,
--renato
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20130610/4dc7d9e7/attachment.html>

On Jun 10, 2013, at 1:18 PM, Tobias Grosser <grosser at google.com> wrote:
> Hi,
> 
> I would like to add host feature detection for Qualcomm CPUs. The
implementation models
> the feature detection for ARM CPUs. Is this OK to commit?
Sure, LGTM

-Chris