On Thu, Mar 28, 2013 at 1:46 PM, Anton Korobeynikov <asl at math.spbu.ru> wrote:>> Sounds fine to me. I just wanted some convenient and consistent naming. >> I think it conflicts a bit with the triples (-win32 currently means >> msvc I think), > Right. But this is again a historical (and LLVM-specific) artifact, > because I doubt anyone uses such triplet outside to mean msvc > compatibility. >Fair enough. Mostly most of the triples that exist aren't very useful for strict msvc compatibility since it wasn't a mode that gcc embraced :)>> but that'll probably be ok ultimately - internal function names are easy to >> refactor if we decide to change the naming later. > +1, but they should not confuse someone who reads / reviews the code :) >Yup, it was confusing in the first place which is why I'm commenting here :) -eric
On Thu, Mar 28, 2013 at 1:49 PM, Eric Christopher <echristo at gmail.com>wrote:> On Thu, Mar 28, 2013 at 1:46 PM, Anton Korobeynikov <asl at math.spbu.ru> > wrote: > >> Sounds fine to me. I just wanted some convenient and consistent naming. > >> I think it conflicts a bit with the triples (-win32 currently means > >> msvc I think), > > Right. But this is again a historical (and LLVM-specific) artifact, > > because I doubt anyone uses such triplet outside to mean msvc > > compatibility. > > > > Fair enough. Mostly most of the triples that exist aren't very useful for > strict > msvc compatibility since it wasn't a mode that gcc embraced :)Yeah, right now we have the -cxx-abi microsoft flag. We could put msvc in the triplet "environment" but that sounds like a windmill that doesn't need tilting.> >> but that'll probably be ok ultimately - internal function names are > easy to > >> refactor if we decide to change the naming later. > > +1, but they should not confuse someone who reads / reviews the code :) > > > > Yup, it was confusing in the first place which is why I'm commenting here > :) > > -eric > _______________________________________________ > cfe-dev mailing list > cfe-dev at cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20130328/e0cacaea/attachment.html>
On Thu, Mar 28, 2013 at 1:54 PM, Reid Kleckner <rnk at google.com> wrote:> On Thu, Mar 28, 2013 at 1:49 PM, Eric Christopher <echristo at gmail.com> > wrote: >> >> On Thu, Mar 28, 2013 at 1:46 PM, Anton Korobeynikov <asl at math.spbu.ru> >> wrote: >> >> Sounds fine to me. I just wanted some convenient and consistent naming. >> >> I think it conflicts a bit with the triples (-win32 currently means >> >> msvc I think), >> > Right. But this is again a historical (and LLVM-specific) artifact, >> > because I doubt anyone uses such triplet outside to mean msvc >> > compatibility. >> > >> >> Fair enough. Mostly most of the triples that exist aren't very useful for >> strict >> msvc compatibility since it wasn't a mode that gcc embraced :) > > > Yeah, right now we have the -cxx-abi microsoft flag. We could put msvc in > the triplet "environment" but that sounds like a windmill that doesn't need > tilting. >Not right now for sure :) -eric
Maybe Matching Threads
- [LLVMdev] [cfe-dev] Handling SRet on Windows x86
- [LLVMdev] [cfe-dev] Handling SRet on Windows x86
- [LLVMdev] [cfe-dev] Handling SRet on Windows x86
- Configure Dovecot for GSSAPI [formerly: Looking for GSSAPI config]
- Configure Dovecot for GSSAPI [formerly: Looking for GSSAPI config]