llvm dev - Jan 2013 - [LLVMdev] [cfe-dev] RFC: put commit messages in *-commits subject lines?

Jordan Rose wrote:
> +John C and Daniel, who have access to the servers.
> 
> Way back when this thread was first active I asked around off-list where
this needs to happen, and Daniel and Tanya said this (respectively):
> 
> >> I'd prefer to stick with using either svn-mailer or svnnotify,
as those are the ones we use in other places. svnnotify in particular is very
full featured, although we would need to install it on the server but that is
straightforward.
> >> 
> > Maybe. The server is very out of date, and there are no packages
anymore for it.. so if its just one file then that might work ;)
> > 
> > I need to get John C. to update the OS again. He didn't do it and
then Zac came early.. so it never got done. But its time and needs to be done.
Once thats done, it will allow us to upgrade llvm.org much easier.
> 
> Sebastian, maybe you can psas your full config file on to John and Daniel?
I started looking at this problem in a blind way:
> I see that currently the commit emails contain this marker in the header:
> X-Mailer: svnmailer-1.0.9
> So the following fixes assume that we are running svnmailer-1.0.9.
If somebody can send me the current config file from the server, I will modify
that, test locally, and send back a patch.  If you decide to switch to
svnnotify,
you wouldn't need my fixes, but I would still be happy to help if needed.

Let's get this bug fixed ;-)

Thanks,
Sebastian
-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The
Linux Foundation

Hi Sebastion,

I've attached the current configuration file from the server.

I'm not sure how far you want to go down the "trying to get realize
nice
summary path" lines, but if svn_mailer somehow supported running an
external script to process the commit and come up with the path that would
be ideal for integration on the server.

 - Daniel


On Fri, Jan 25, 2013 at 12:59 PM, Sebastian Pop <spop at codeaurora.org>
wrote:
> Jordan Rose wrote:
> > +John C and Daniel, who have access to the servers.
> >
> > Way back when this thread was first active I asked around off-list
where
> this needs to happen, and Daniel and Tanya said this (respectively):
> >
> > >> I'd prefer to stick with using either svn-mailer or
svnnotify, as
> those are the ones we use in other places. svnnotify in particular is very
> full featured, although we would need to install it on the server but that
> is straightforward.
> > >>
> > > Maybe. The server is very out of date, and there are no packages
> anymore for it.. so if its just one file then that might work ;)
> > >
> > > I need to get John C. to update the OS again. He didn't do it
and then
> Zac came early.. so it never got done. But its time and needs to be done.
> Once thats done, it will allow us to upgrade llvm.org much easier.
> >
> > Sebastian, maybe you can psas your full config file on to John and
> Daniel?
>
> I started looking at this problem in a blind way:
>
> > I see that currently the commit emails contain this marker in the
header:
> > X-Mailer: svnmailer-1.0.9
> > So the following fixes assume that we are running svnmailer-1.0.9.
>
> If somebody can send me the current config file from the server, I will
> modify
> that, test locally, and send back a patch.  If you decide to switch to
> svnnotify,
> you wouldn't need my fixes, but I would still be happy to help if
needed.
>
> Let's get this bug fixed ;-)
>
> Thanks,
> Sebastian
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted
> by The Linux Foundation
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20130125/f3c70d0b/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: svn-mailer.conf
Type: application/octet-stream
Size: 22160 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20130125/f3c70d0b/attachment.obj>

Hi Daniel,

Daniel Dunbar wrote:
> Hi Sebastion,
> 
> I've attached the current configuration file from the server.
> 
> I'm not sure how far you want to go down the "trying to get
realize nice
> summary path" lines, but if svn_mailer somehow supported running an
> external script to process the commit and come up with the path that would
> be ideal for integration on the server.
I think you could modify the sources of svn_mailer to add such a hook.  When I
first investigated this issue, I ended on a bug report from the debian project
that fixed the subject line with a one line patch:
> To get the first line of the log message as a subject line, please apply
this
> one line patch:
http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=17;bug=379534
> Note that you can directly patch the installed script: on my machine it is
> located in
/usr/local/lib/python2.7/dist-packages/svnmailer/notifier/_mail.py
For your convenience, here is the patch from that debian bug report:


svnmailer: add log substitution for subject templates

Add first line of commit log as a substitution variable for
*_subject_template, E.G. add %(log)s to use.

Signed-off-by: Peter Korsgaard <jacmet at sunsite.dk>

Index: svnmailer-1.0.8/src/lib/svnmailer/notifier/_mail.py
==================================================================---
svnmailer-1.0.8.orig/src/lib/svnmailer/notifier/_mail.py	2008-05-27
14:56:27.000000000 +0200
+++ svnmailer-1.0.8/src/lib/svnmailer/notifier/_mail.py	2008-05-27
15:01:50.000000000 +0200
@@ -314,6 +314,7 @@
             'part'    : countprefix,
             'files'   : self._getPrefixedFiles(changeset),
             'dirs'    : self._getPrefixedDirectories(changeset),
+            'log'     : self.getLog().split('\n',1)[0],
         }
 
         # We may try twice, first with files/dirs = files



Sebastian
-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The
Linux Foundation