Dmitri Gribenko <gribozavr at gmail.com> writes:> On Tue, Jan 15, 2013 at 7:07 PM, <dag at cray.com> wrote: >> Dmitri Gribenko <gribozavr at gmail.com> writes: >> >>> On Tue, Jan 15, 2013 at 2:43 AM, <greened at obbligato.org> wrote: >>>> The document here explains pretty well how to add a buildslave to the >>>> buildbot: >>>> >>>> http://llvm.org/docs/HowToAddABuilder.html >>>> >>>> However, it's not clear to me how to add a new build config. I would >>>> like to add a buildslave that builds with -Werror so we can catch and >>>> correct warnings early. >>>> >>>> How should I go about adding a new build configuration? Do I edit >>>> one of the .py files in zorg? >>> >>> Can you get the desired effect with --with-extra-options=? >> >> Probably, but where do I put that? > > It is a configure argument that specifies extra options to compile > with. For buildbots, it is the extra_configure_args parameter for > getClangBuildFactory (look at examples in builders.py).Right, I get that. Actually I would probably use --enable-werror. Should I create a patch for builders.py to add a new config? Is there a way to map a config so that it only even builds on a certain buildslave? I don't want to burden other builders with my config. -David
On Tue, Jan 15, 2013 at 8:24 PM, <dag at cray.com> wrote:> Dmitri Gribenko <gribozavr at gmail.com> writes: > >> On Tue, Jan 15, 2013 at 7:07 PM, <dag at cray.com> wrote: >>> Dmitri Gribenko <gribozavr at gmail.com> writes: >>> >>>> On Tue, Jan 15, 2013 at 2:43 AM, <greened at obbligato.org> wrote: >>>>> The document here explains pretty well how to add a buildslave to the >>>>> buildbot: >>>>> >>>>> http://llvm.org/docs/HowToAddABuilder.html >>>>> >>>>> However, it's not clear to me how to add a new build config. I would >>>>> like to add a buildslave that builds with -Werror so we can catch and >>>>> correct warnings early. >>>>> >>>>> How should I go about adding a new build configuration? Do I edit >>>>> one of the .py files in zorg? >>>> >>>> Can you get the desired effect with --with-extra-options=? >>> >>> Probably, but where do I put that? >> >> It is a configure argument that specifies extra options to compile >> with. For buildbots, it is the extra_configure_args parameter for >> getClangBuildFactory (look at examples in builders.py). > > Right, I get that. Actually I would probably use --enable-werror. > > Should I create a patch for builders.py to add a new config?Yes. Send it to llvm-commits and CC Galina Kistanova.> Is there a way to map a config so that it only even builds on a certain > buildslave? I don't want to burden other builders with my config.Just edit one entry for your builder in builders.py, it will not affect others. (Or add a new one if you are adding a new builder.) Dmitri -- main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if (j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/
Dmitri Gribenko <gribozavr at gmail.com> writes:>> Right, I get that. Actually I would probably use --enable-werror. >> >> Should I create a patch for builders.py to add a new config? > > Yes. Send it to llvm-commits and CC Galina Kistanova.Ok, cool. Thanks!>> Is there a way to map a config so that it only even builds on a certain >> buildslave? I don't want to burden other builders with my config. > > Just edit one entry for your builder in builders.py, it will not > affect others. (Or add a new one if you are adding a new builder.)Ok. -David