Joe Abbey
2012-Nov-26 01:16 UTC
[LLVMdev] Improve Covered Default Switch detection (keep try)
Here's a reduced version of the previous patch. Keeping it dead simple. jabbeymbp:build jabbey$ cmake .. -- Performing Test CXX_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG -- Performing Test CXX_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG - Success -- Performing Test C_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG -- Performing Test C_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG - Failed jabbeymbp:build jabbey$ CC=/usr/bin/clang cmake .. -- Performing Test CXX_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG -- Performing Test CXX_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG - Success -- Performing Test C_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG -- Performing Test C_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG - Success Ok to commit? Joe -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20121125/6d1ed082/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: improved-covered-default-switch-detection-reduced.patch Type: application/octet-stream Size: 1357 bytes Desc: improved-covered-default-switch-detection-reduced.patch URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20121125/6d1ed082/attachment.obj> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20121125/6d1ed082/attachment.htm>
David Blaikie
2012-Nov-26 02:01 UTC
[LLVMdev] [llvm-commits] Improve Covered Default Switch detection (keep try)
As per discussion on IRC this looks good (enough) to me for commit. Hopefully if others have better/other ideas about how to do this with CMake they can provide it in post commit review. Thanks for the fix, - David On Sun, Nov 25, 2012 at 5:16 PM, Joe Abbey <jabbey at arxan.com> wrote:> Here's a reduced version of the previous patch. > > Keeping it dead simple. > > jabbeymbp:build jabbey$ cmake .. > > -- Performing Test CXX_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG > -- Performing Test CXX_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG - Success > -- Performing Test C_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG > -- Performing Test C_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG - Failed > > jabbeymbp:build jabbey$ CC=/usr/bin/clang cmake .. > > -- Performing Test CXX_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG > -- Performing Test CXX_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG - Success > -- Performing Test C_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG > -- Performing Test C_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG - Success > > Ok to commit? > > Joe > > > _______________________________________________ > llvm-commits mailing list > llvm-commits at cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits >
Joe Abbey
2012-Nov-26 02:04 UTC
[LLVMdev] [llvm-commits] Improve Covered Default Switch detection (keep try)
r168577 Cheers, Joe On Nov 25, 2012, at 9:01 PM, David Blaikie <dblaikie at gmail.com> wrote:> As per discussion on IRC this looks good (enough) to me for commit. > Hopefully if others have better/other ideas about how to do this with > CMake they can provide it in post commit review. > > Thanks for the fix, > - David > > On Sun, Nov 25, 2012 at 5:16 PM, Joe Abbey <jabbey at arxan.com> wrote: >> Here's a reduced version of the previous patch. >> >> Keeping it dead simple. >> >> jabbeymbp:build jabbey$ cmake .. >> >> -- Performing Test CXX_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG >> -- Performing Test CXX_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG - Success >> -- Performing Test C_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG >> -- Performing Test C_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG - Failed >> >> jabbeymbp:build jabbey$ CC=/usr/bin/clang cmake .. >> >> -- Performing Test CXX_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG >> -- Performing Test CXX_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG - Success >> -- Performing Test C_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG >> -- Performing Test C_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG - Success >> >> Ok to commit? >> >> Joe >> >> >> _______________________________________________ >> llvm-commits mailing list >> llvm-commits at cs.uiuc.edu >> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits >>
Possibly Parallel Threads
- [LLVMdev] [llvm-commits] Improve Covered Default Switch detection (keep try)
- [LLVMdev] [llvm-commits] Improved Covered Default Switch detection
- [LLVMdev] Improved Covered Default Switch detection
- [LLVMdev] [llvm-commits] Improved Covered Default Switch detection
- [LLVMdev] [llvm-commits] Improved Covered Default Switch detection