Hi all, Unfortunately, all my Hunks are failed when I apply : patch -p1 < da.patch command. The problem might be due to the fact that da.patch file was created against revision 167549, but I am on revision 167719 (I believe the most recent one). I am not sure if this cause the problem ? But Preston may I ask you to generate the patch file against revison 167719 ? Thanks in advance. On Tue, Nov 13, 2012 at 9:41 AM, Arnaldo <arnaldo.cruz at upr.edu> wrote:> Preston, thanks for the explanation and patch. Now it's printing the > direction and distance values. > > > On Tue, Nov 13, 2012 at 12:22 PM, Preston Briggs <preston.briggs at gmail.com > > wrote: > >> Erkan, you're right. Sorry about that. >> Attached is the most recent version. >> >> Preston >> >> >> >> Hi Preston, >>> I am trying to use DA as well. I used your example and commands that you >>> wrote in order to get DA information. >>> However, it does not report any dependence info. >>> I am wondering whether your local copy differs from the one on the >>> repository ? >>> Thanks. >>> Erkan. >> >> >> >> ---------- Forwarded message ---------- >> From: Preston Briggs <preston.briggs at gmail.com> >> Date: Wed, Nov 7, 2012 at 12:51 PM >> Subject: DependenceAnalysis patch >> To: "llvm-commits at cs.uiuc.edu" <llvm-commits at cs.uiuc.edu>, Chandler >> Carruth <chandlerc at google.com>, Hal Finkel <hfinkel at anl.gov>, Benjamin >> Kramer <benny.kra at gmail.com> >> >> >> Here's a patch that covers the problems reported by Chandler last week. >> It checks the base pointer of each GEP to be sure they are loop >> invariant. The patch also updates the -analyze functionality so that all >> pairs of memory references are tested. Finally, all the test cases have >> been updated. >> >> I haven't yet updated DA to analyze pairs of pointer dereferences. I >> wanted to get the initial correction in place first. I also expect that >> analyzer pointer derefs will benefit from delinearization and am hoping it >> gets incorporated soon. >> >> If someone could review this change and check it in, if appropriate, I'd >> be obliged. >> >> Thanks, >> Preston >> >> >> >-- Best Regards, Erkan Diken ------------------ -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20121113/8a489d59/attachment.html>
On 13.11.2012, at 10:46, erkan diken <erkandiken at gmail.com> wrote: Hi all, Unfortunately, all my Hunks are failed when I apply : patch -p1 < da.patch command. The problem might be due to the fact that da.patch file was created against revision 167549, but I am on revision 167719 (I believe the most recent one). I am not sure if this cause the problem ? But Preston may I ask you to generate the patch file against revison 167719 ? Thanks in advance. The patch to print all dependences is in trunk, you don't need the patch for it anymore. Related thread: http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20121112/155651.html - Ben On Tue, Nov 13, 2012 at 9:41 AM, Arnaldo <arnaldo.cruz at upr.edu> wrote:> Preston, thanks for the explanation and patch. Now it's printing the > direction and distance values. > > > On Tue, Nov 13, 2012 at 12:22 PM, Preston Briggs <preston.briggs at gmail.com > > wrote: > >> Erkan, you're right. Sorry about that. >> Attached is the most recent version. >> >> Preston >> >> >> >> Hi Preston, >>> I am trying to use DA as well. I used your example and commands that you >>> wrote in order to get DA information. >>> However, it does not report any dependence info. >>> I am wondering whether your local copy differs from the one on the >>> repository ? >>> Thanks. >>> Erkan. >> >> >> >> ---------- Forwarded message ---------- >> From: Preston Briggs <preston.briggs at gmail.com> >> Date: Wed, Nov 7, 2012 at 12:51 PM >> Subject: DependenceAnalysis patch >> To: "llvm-commits at cs.uiuc.edu" <llvm-commits at cs.uiuc.edu>, Chandler >> Carruth <chandlerc at google.com>, Hal Finkel <hfinkel at anl.gov>, Benjamin >> Kramer <benny.kra at gmail.com> >> >> >> Here's a patch that covers the problems reported by Chandler last week. >> It checks the base pointer of each GEP to be sure they are loop >> invariant. The patch also updates the -analyze functionality so that all >> pairs of memory references are tested. Finally, all the test cases have >> been updated. >> >> I haven't yet updated DA to analyze pairs of pointer dereferences. I >> wanted to get the initial correction in place first. I also expect that >> analyzer pointer derefs will benefit from delinearization and am hoping it >> gets incorporated soon. >> >> If someone could review this change and check it in, if appropriate, I'd >> be obliged. >> >> Thanks, >> Preston >> >> >> >-- Best Regards, Erkan Diken ------------------ _______________________________________________ LLVM Developers mailing list LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20121114/d8992860/attachment.html>
Thanks Benjamin, yes it is ok now. On Wed, Nov 14, 2012 at 10:27 AM, Benjamin Kramer <benny.kra at gmail.com>wrote:> On 13.11.2012, at 10:46, erkan diken <erkandiken at gmail.com> wrote: > > Hi all, > > Unfortunately, all my Hunks are failed when I apply : patch -p1 < da.patch > command. > > The problem might be due to the fact that da.patch file was created > against revision 167549, but I am on revision 167719 (I believe the most > recent one). > I am not sure if this cause the problem ? But Preston may I ask you to > generate the patch file against revison 167719 ? > > Thanks in advance. > > > The patch to print all dependences is in trunk, you don't need the patch > for it anymore. > > Related thread: > http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20121112/155651.html > > - Ben > > > > On Tue, Nov 13, 2012 at 9:41 AM, Arnaldo <arnaldo.cruz at upr.edu> wrote: > >> Preston, thanks for the explanation and patch. Now it's printing the >> direction and distance values. >> >> >> On Tue, Nov 13, 2012 at 12:22 PM, Preston Briggs < >> preston.briggs at gmail.com> wrote: >> >>> Erkan, you're right. Sorry about that. >>> Attached is the most recent version. >>> >>> Preston >>> >>> >>> >>> Hi Preston, >>>> I am trying to use DA as well. I used your example and commands that >>>> you wrote in order to get DA information. >>>> However, it does not report any dependence info. >>>> I am wondering whether your local copy differs from the one on the >>>> repository ? >>>> Thanks. >>>> Erkan. >>> >>> >>> >>> ---------- Forwarded message ---------- >>> From: Preston Briggs <preston.briggs at gmail.com> >>> Date: Wed, Nov 7, 2012 at 12:51 PM >>> Subject: DependenceAnalysis patch >>> To: "llvm-commits at cs.uiuc.edu" <llvm-commits at cs.uiuc.edu>, Chandler >>> Carruth <chandlerc at google.com>, Hal Finkel <hfinkel at anl.gov>, Benjamin >>> Kramer <benny.kra at gmail.com> >>> >>> >>> Here's a patch that covers the problems reported by Chandler last week. >>> It checks the base pointer of each GEP to be sure they are loop >>> invariant. The patch also updates the -analyze functionality so that all >>> pairs of memory references are tested. Finally, all the test cases have >>> been updated. >>> >>> I haven't yet updated DA to analyze pairs of pointer dereferences. I >>> wanted to get the initial correction in place first. I also expect that >>> analyzer pointer derefs will benefit from delinearization and am hoping it >>> gets incorporated soon. >>> >>> If someone could review this change and check it in, if appropriate, I'd >>> be obliged. >>> >>> Thanks, >>> Preston >>> >>> >>> >> > > > -- > Best Regards, > Erkan Diken > ------------------ > > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev > >-- Best Regards, Erkan Diken ------------------ -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20121114/af74c0f9/attachment.html>