On the topic of code owners: Would it make sense to add target-specific code owners for the codegen targets? Some of the targets are more esoteric (e.g. NVPTX, CellSPU, AMDGPU) and may benefit from more fine-grained code ownership. On Mon, Nov 12, 2012 at 11:26 AM, Renato Golin <rengolin at systemcall.org>wrote:> On 12 November 2012 15:55, Meador Inge <meadori at codesourcery.com> wrote: > > Another point to address is whether there can be more than one owner in a > > particular area. > > There might be more than one code expert per area, which can be > referenced by the code owner, but I wouldn't have more than one owner. > > Owning part of the code means you'll have to keep a sharper eye on > particular changes than others and should raise concerns when they're > due, and not to take the blame for breaking or charged for fixing > broken code. > > -- > cheers, > --renato > > http://systemcall.org/ > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >-- Thanks, Justin Holewinski -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20121112/093d3290/attachment.html>
On Nov 12, 2012, at 8:56 AM, Justin Holewinski <justin.holewinski at gmail.com> wrote:> On the topic of code owners: > > Would it make sense to add target-specific code owners for the codegen targets? Some of the targets are more esoteric (e.g. NVPTX, CellSPU, AMDGPU) and may benefit from more fine-grained code ownership.It definitely makes sense to have code owners for each subdirectory of lib/Target. -Chris
----- Original Message -----> From: "Chris Lattner" <clattner at apple.com> > To: "Justin Holewinski" <justin.holewinski at gmail.com> > Cc: "LLVM Developers Mailing List" <llvmdev at cs.uiuc.edu> > Sent: Monday, November 12, 2012 11:30:26 AM > Subject: Re: [LLVMdev] RFC: Code Ownership > > > On Nov 12, 2012, at 8:56 AM, Justin Holewinski > <justin.holewinski at gmail.com> wrote: > > > On the topic of code owners: > > > > Would it make sense to add target-specific code owners for the > > codegen targets? Some of the targets are more esoteric (e.g. > > NVPTX, CellSPU, AMDGPU) and may benefit from more fine-grained > > code ownership. > > It definitely makes sense to have code owners for each subdirectory > of lib/Target.Chris, Evan, I would like to take ownership responsibility for Target/PowerPC. I have discussed this with our IBM contributors and Roman, and all agree. Thanks again, Hal> > -Chris > > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >-- Hal Finkel Postdoctoral Appointee Leadership Computing Facility Argonne National Laboratory