llvm dev - Jun 2012 - [LLVMdev] [llvm-commits] How to define macros in a tablegen file?

Sebastian,

If not a test, how about a patch in the documentation for TableGen about 
this new feature that you're making available?

-- 
Evandro Menezes          Austin, TX          emenezes at codeaurora.org
Qualcomm Innovation Center, Inc is a member of the Code Aurora Forum


On 06/20/12 16:02, Sebastian Pop wrote:
> On Wed, Jun 20, 2012 at 3:40 PM, Villmow, Micah<Micah.Villmow at
amd.com>  wrote:
>> Possible to add a test case?
>
> I am not really sure what I would check.
>
> At first, I thought to add a testcase to test/TableGen; as this patch
> does not modify tablegen, it doesn't make sense.
>
> What kind of test should I write for this?  The test should be a
> tablegen file that includes "llvm/Target/TargetSelectionDAG.td"
or
> "llvm/Target/Target.td", and I haven't seen any of these in
the
> testsuite.
>
> Sebastian

On Thu, Jun 21, 2012 at 10:31 AM, Evandro Menezes
<emenezes at codeaurora.org> wrote:
> Sebastian,
>
> If not a test, how about a patch in the documentation for TableGen about
> this new feature that you're making available?
That's a good point.  I will prepare a patch for the docs.

Thanks for your review!
Sebastian
-- 
Qualcomm Innovation Center, Inc is a member of Code Aurora Forum

Make sure to pull from the repo because the TableGen docs have been moved
from HTML to reStructuredText very, very recently; it would be unfortunate
if you did your work on the now-nonexistent HTML version, only to find that
that file no longer exists.

--Sean Silva

On Thu, Jun 21, 2012 at 8:33 AM, Sebastian Pop <spop at codeaurora.org>
wrote:
> On Thu, Jun 21, 2012 at 10:31 AM, Evandro Menezes
> <emenezes at codeaurora.org> wrote:
> > Sebastian,
> >
> > If not a test, how about a patch in the documentation for TableGen
about
> > this new feature that you're making available?
>
> That's a good point.  I will prepare a patch for the docs.
>
> Thanks for your review!
> Sebastian
> --
> Qualcomm Innovation Center, Inc is a member of Code Aurora Forum
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20120621/e4f805a9/attachment.html>