llvm dev - Nov 2011 - [LLVMdev] Instrumentation passes and -O0 optimization level

On Nov 29, 2011, at 11:26 PM, Alexander Potapenko wrote:
>> 
>> Alex,
>> Now, the patch is actually a bit confusing to me.
>> EP_AlwaysEnabled should mean "works with O0 after inliner and with
>= O1
>> somewhere late", but it doesn't look like it works this way
(otherwise, you
>> wouldn't need to call PMBuilder.addExtension twice).
>> ?
> This was actually my question to Devang.
> Any other suggestions for the EP name?
OK, I withdraw my suggestion :)

-
Devang

+cfe-commits (as the patch touches both llvm and clang)

On Wed, Nov 30, 2011 at 9:33 AM, Devang Patel <dpatel at apple.com> wrote:
>
> On Nov 29, 2011, at 11:26 PM, Alexander Potapenko wrote:
>
> >>
> >> Alex,
> >> Now, the patch is actually a bit confusing to me.
> >> EP_AlwaysEnabled should mean "works with O0 after inliner and
with >= O1
> >> somewhere late", but it doesn't look like it works this
way (otherwise,
> you
> >> wouldn't need to call PMBuilder.addExtension twice).
> >> ?
> > This was actually my question to Devang.
> > Any other suggestions for the EP name?
>
> OK, I withdraw my suggestion :)
>
Does anyone else have comments to the original patch (attached)?
Thanks,

--kcc




>
> -
> Devang
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20111130/e004b56e/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang.patch
Type: text/x-patch
Size: 1819 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20111130/e004b56e/attachment.bin>

On Wed, Nov 30, 2011 at 11:04 AM, Kostya Serebryany <kcc at google.com>
wrote:
> +cfe-commits (as the patch touches both llvm and clang)
>
> On Wed, Nov 30, 2011 at 9:33 AM, Devang Patel <dpatel at apple.com>
wrote:
>
>>
>> On Nov 29, 2011, at 11:26 PM, Alexander Potapenko wrote:
>>
>> >>
>> >> Alex,
>> >> Now, the patch is actually a bit confusing to me.
>> >> EP_AlwaysEnabled should mean "works with O0 after inliner
and with >>> O1
>> >> somewhere late", but it doesn't look like it works
this way
>> (otherwise, you
>> >> wouldn't need to call PMBuilder.addExtension twice).
>> >> ?
>> > This was actually my question to Devang.
>> > Any other suggestions for the EP name?
>>
>> OK, I withdraw my suggestion :)
>>
>
> Does anyone else have comments to the original patch (attached)?
> Thanks,
>
I already commented (and gave a reminder to send to cfe-commits as well for
patches to both).

it LGTM. =]
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20111130/feb158b0/attachment.html>