llvm dev - Sep 2011 - [LLVMdev] Bug in TargetRegistry.h?

Hi,

The code @ line 584 of TargetRegistry.h effectively suppresses specifying any
AsmStreamer constructor function but stock createAsmStreamer one. Is it by
intention or condition should be replaced with != ?

Best regards,

  Max

On Thu, Sep 8, 2011 at 12:12 AM, Max Kazakov <max.kazakov at gmail.com>
wrote:
> Hi,
>
> The code @ line 584 of TargetRegistry.h effectively suppresses specifying
any
> AsmStreamer constructor function but stock createAsmStreamer one. Is it by
> intention or condition should be replaced with != ?
Hi Max,

are you sure that you have the tip-of-tree version of
include/llvm/Support/TargetRegistry.h?

   static void RegisterMCInstrAnalysis(Target &T,
                                        Target::MCInstrAnalysisCtorFnTy Fn) {
      // Ignore duplicate registration.
      if (!T.MCInstrAnalysisCtorFn)
        T.MCInstrAnalysisCtorFn = Fn;
    } // line 584 is here


krasin
>
> Best regards,
>
>  Max
>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>

Hi Ivan,

Sorry for the confusion - in the latest version it is line 760:

    static void RegisterAsmStreamer(Target &T, Target::AsmStreamerCtorTy Fn)
{
      if (T.AsmStreamerCtorFn == createAsmStreamer)
        T.AsmStreamerCtorFn = Fn;
    }

Best regards,

  Max